)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7ae2fb46bddba66d937d485c0f91312f9ca04587","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"                      \u0027on the source node %s\u0027, cn.uuid,"},{"line_number":1238,"context_line":"                      instance\u003dinstance)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"    def delete_allocation_for_failed_resize(self, instance, node, flavor):"},{"line_number":1241,"context_line":"        \"\"\"Delete instance allocations for the node during a failed resize"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"        :param instance: The instance being resized/migrated."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d4027bb4","line":1240,"updated":"2017-08-24 19:49:44.000000000","message":"Personally I\u0027d refactor the above method instead of having this one be separate. By reading the names, it looks like this is for resize and the above is for migration, but it\u0027s really that this is for cold operations and the above is for live. They\u0027re really almost identical so I\u0027m not sure why we wouldn\u0027t just squash them together.","commit_id":"cac694fede5cf204e406c17140e7af1a0dfe5c02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4046b5df222749154c22eb3dc4526e194c832b52","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"                      \u0027on the source node %s\u0027, cn.uuid,"},{"line_number":1238,"context_line":"                      instance\u003dinstance)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"    def delete_allocation_for_failed_resize(self, instance, node, flavor):"},{"line_number":1241,"context_line":"        \"\"\"Delete instance allocations for the node during a failed resize"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"        :param instance: The instance being resized/migrated."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_74c187e4","line":1240,"in_reply_to":"7f287b81_d4027bb4","updated":"2017-08-24 20:07:29.000000000","message":"\u003e but it\u0027s really that this is for cold operations and the above is for live\n\ndelete_allocation_for_migrated_instance is actually only called for cold migrate/resize too. We don\u0027t involve the RT when doing a live migration.\n\nI can squash them in a follow up given time.","commit_id":"cac694fede5cf204e406c17140e7af1a0dfe5c02"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7ae2fb46bddba66d937d485c0f91312f9ca04587","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        then PUTs the resulting allocation back to the placement API for the"},{"line_number":1030,"context_line":"        consumer."},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"        We call this method on three occasions:"},{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"        1. On the source host during a confirm_resize() operation."},{"line_number":1035,"context_line":"        2. On the destination host during a revert_resize() operation."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_f46e9794","line":1032,"updated":"2017-08-24 19:49:44.000000000","message":"Maybe just omit the count since we\u0027ve increased it from one to three in the last 24 hours? :P","commit_id":"cac694fede5cf204e406c17140e7af1a0dfe5c02"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b9042b808ffcee9c9bc306b0bf1cbc62b51775c3","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        then PUTs the resulting allocation back to the placement API for the"},{"line_number":1030,"context_line":"        consumer."},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"        We call this method on three occasions:"},{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"        1. On the source host during a confirm_resize() operation."},{"line_number":1035,"context_line":"        2. On the destination host during a revert_resize() operation."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_8f9bbcc7","line":1032,"in_reply_to":"7f287b81_543b2bea","updated":"2017-08-24 20:12:23.000000000","message":"Oh you\u0027re right, I was thinking this was the scheduler doubling one we\u0027re now calling during force live migration...","commit_id":"cac694fede5cf204e406c17140e7af1a0dfe5c02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4046b5df222749154c22eb3dc4526e194c832b52","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"        then PUTs the resulting allocation back to the placement API for the"},{"line_number":1030,"context_line":"        consumer."},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"        We call this method on three occasions:"},{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"        1. On the source host during a confirm_resize() operation."},{"line_number":1035,"context_line":"        2. On the destination host during a revert_resize() operation."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_543b2bea","line":1032,"in_reply_to":"7f287b81_f46e9794","updated":"2017-08-24 20:07:29.000000000","message":"heh, just 2 to 3 here, the other one was something else....","commit_id":"cac694fede5cf204e406c17140e7af1a0dfe5c02"}]}