)]}'
{"nova/conf/notifications.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"61c054d1b474790d4dfa6343d74a7995750f813d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        \u0027default_publisher_id\u0027,"},{"line_number":68,"context_line":"        default\u003d\u0027$host\u0027,"},{"line_number":69,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":70,"context_line":"        help\u003d\"\"\""},{"line_number":71,"context_line":"Default publisher_id for outgoing notifications. If you consider routing"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_29770405","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":23},"updated":"2017-08-25 21:26:29.000000000","message":"I need to sort this out, but does oslo.config actually redirect this to CONF.host? Because I doubt it. Which would mean that the default is actually literally \"$host\" which would be wrong. Meaning this should probably default to None.","commit_id":"ff63b32eee73652ca3ec2fec69558790c8590b47"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3341bf990eb10eb8a55589fdfdb3df4cd547b11f","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        \u0027default_publisher_id\u0027,"},{"line_number":68,"context_line":"        default\u003d\u0027$host\u0027,"},{"line_number":69,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":70,"context_line":"        help\u003d\"\"\""},{"line_number":71,"context_line":"Default publisher_id for outgoing notifications. If you consider routing"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_9e598d36","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":23},"in_reply_to":"7f287b81_29770405","updated":"2017-08-25 22:40:40.000000000","message":"I did some testing locally and it looks like oslo.config actually does resolve the default to another option using the $.","commit_id":"ff63b32eee73652ca3ec2fec69558790c8590b47"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"66a94d02dfc7a1ccbccc617e1dea75a4cc62a0b4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        deprecated_name\u003d\u0027default_notification_level\u0027,"},{"line_number":64,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        \u0027default_publisher_id\u0027,"},{"line_number":68,"context_line":"        default\u003d\u0027$host\u0027,"},{"line_number":69,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_c0fb9c76","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":14},"updated":"2017-08-28 08:59:19.000000000","message":"No point changing the type of this since it\u0027s deprecated","commit_id":"27cd4dd70b5a51919ce0091ab4247f65e5a27526"}],"releasenotes/notes/bug-1713150-default_publisher_id-f46f4f6a39347951.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"204e5f713b6cdc71f52593197037441ffe965e04","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[notifications]/default_publisher_id`` configuration option now"},{"line_number":5,"context_line":"    defaults to ``[DEFAULT]/host`` rather than ``[DEFAULT]/my_ip``. The code"},{"line_number":6,"context_line":"    was always doing this if left unset anyway, so this is mostly just for"},{"line_number":7,"context_line":"    documentation purposes."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f287b81_7e75c163","line":7,"range":{"start_line":5,"start_character":67,"end_line":7,"end_character":27},"updated":"2017-08-25 22:53:25.000000000","message":"Not really true, it would interpolate $my_ip.","commit_id":"9a9a0d5a3c81cf4c76e483d5fc97be3fd7c9f08f"}]}