)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d479174d86ef859afcf622af2909d66a6d275427","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[wip] Fix nova assisted volume snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When performing nova assisted volume snapshots, the nova api does"},{"line_number":10,"context_line":"not receive the instance id, fetching it from the BDM."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Since we do not know which cell to target when fetching the BDM, we"},{"line_number":13,"context_line":"have to iterate through *all* of them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_bc077482","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":54},"updated":"2017-08-29 15:46:39.000000000","message":"This is confusing in this sentence. Maybe say, \"the nova api does not receive the instance id, so there is not the usual instance lookup from the cell which automatically targets the context for the cell that the instance was pulled from, which is also where we\u0027d get the BDM.\"","commit_id":"de40d918fee3699d9e7ddeb9e7cb0ffdf272f351"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c2779c1f903b022935ac20971909af59d3bc083f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[wip] Fix nova assisted volume snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When performing nova assisted volume snapshots, the nova api does"},{"line_number":10,"context_line":"not receive the instance id, fetching it from the BDM."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Since we do not know which cell to target when fetching the BDM, we"},{"line_number":13,"context_line":"have to iterate through *all* of them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_9cc4b8f6","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":54},"in_reply_to":"7f287b81_bc077482","updated":"2017-08-29 15:54:43.000000000","message":"Done","commit_id":"de40d918fee3699d9e7ddeb9e7cb0ffdf272f351"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d479174d86ef859afcf622af2909d66a6d275427","unresolved":false,"context_lines":[{"line_number":4079,"context_line":""},{"line_number":4080,"context_line":"        bdm \u003d None"},{"line_number":4081,"context_line":"        for cell in CELLS:"},{"line_number":4082,"context_line":"            nova_context.set_target_cell(context, cell)"},{"line_number":4083,"context_line":"            try:"},{"line_number":4084,"context_line":"                bdm \u003d objects.BlockDeviceMapping.get_by_volume("},{"line_number":4085,"context_line":"                    context, volume_id, expected_attrs\u003d[\u0027instance\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_fc1e1cb9","line":4082,"range":{"start_line":4082,"start_character":12,"end_line":4082,"end_character":55},"updated":"2017-08-29 15:46:39.000000000","message":"Use the context manager instead:\n\nfor cell in CELLS:\n   with nova_context.target_cell(context, cell) as cctxt:\n       try:\n           return BDM.get_by_volume(cctxt, volume_id, ...)\n       except BDMNotFound:\n           continue\nraise VolumeBDMNotFound(...)","commit_id":"de40d918fee3699d9e7ddeb9e7cb0ffdf272f351"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c2779c1f903b022935ac20971909af59d3bc083f","unresolved":false,"context_lines":[{"line_number":4079,"context_line":""},{"line_number":4080,"context_line":"        bdm \u003d None"},{"line_number":4081,"context_line":"        for cell in CELLS:"},{"line_number":4082,"context_line":"            nova_context.set_target_cell(context, cell)"},{"line_number":4083,"context_line":"            try:"},{"line_number":4084,"context_line":"                bdm \u003d objects.BlockDeviceMapping.get_by_volume("},{"line_number":4085,"context_line":"                    context, volume_id, expected_attrs\u003d[\u0027instance\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_fc7dfcb1","line":4082,"range":{"start_line":4082,"start_character":12,"end_line":4082,"end_character":55},"in_reply_to":"7f287b81_fc1e1cb9","updated":"2017-08-29 15:54:43.000000000","message":"Didn\u0027t use the context manager so that the targeted cell remains set.","commit_id":"de40d918fee3699d9e7ddeb9e7cb0ffdf272f351"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"889685eb819d800e39fd10a789e51d32bdf4b11d","unresolved":false,"context_lines":[{"line_number":4079,"context_line":""},{"line_number":4080,"context_line":"        bdm \u003d None"},{"line_number":4081,"context_line":"        for cell in CELLS:"},{"line_number":4082,"context_line":"            nova_context.set_target_cell(context, cell)"},{"line_number":4083,"context_line":"            try:"},{"line_number":4084,"context_line":"                bdm \u003d objects.BlockDeviceMapping.get_by_volume("},{"line_number":4085,"context_line":"                    context, volume_id, expected_attrs\u003dexpected_attrs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b048b02c","line":4082,"range":{"start_line":4082,"start_character":12,"end_line":4082,"end_character":55},"updated":"2017-08-29 20:25:01.000000000","message":"Can we please add a comment either here or in the docstring that we purposefully leave the context targeted to the cell for the caller?","commit_id":"7438dd506b9a1d10a354622dd53cc23f09bd47c9"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"889685eb819d800e39fd10a789e51d32bdf4b11d","unresolved":false,"context_lines":[{"line_number":2891,"context_line":"    @mock.patch.object("},{"line_number":2892,"context_line":"        objects.BlockDeviceMapping, \u0027get_by_volume\u0027,"},{"line_number":2893,"context_line":"        return_value\u003dobjects.BlockDeviceMapping("},{"line_number":2894,"context_line":"                instance\u003dobjects.Instance("},{"line_number":2895,"context_line":"                launched_at\u003dtimeutils.utcnow(), uuid\u003duuids.instance_uuid,"},{"line_number":2896,"context_line":"                vm_state\u003dvm_states.SHELVED_OFFLOADED, task_state\u003dNone,"},{"line_number":2897,"context_line":"                host\u003dNone)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_300ba0d6","line":2894,"updated":"2017-08-29 20:25:01.000000000","message":"unrelated","commit_id":"7438dd506b9a1d10a354622dd53cc23f09bd47c9"}]}