)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1138fd2018eb70bc7fdca0e02bba0d8464f250d6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"management) rather than attempting to mock the internals of os_xenapi."},{"line_number":12,"context_line":"This issue was introduced when os_xenapi was split out from nova,"},{"line_number":13,"context_line":"but the UT were not similarly abstracted"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifdcddb63f64d5759640a62e8ddd3c276fa4fc743"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_bec0e57d","line":14,"updated":"2017-09-05 20:53:51.000000000","message":"If this fixes bug 1715217 we should mark it as such.","commit_id":"dcda184e3d7c90ac00a9c7f6c45cd5a36358afee"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6c1935a19736930231dc28d0f5eb00d925337d1a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"management) rather than attempting to mock the internals of os_xenapi."},{"line_number":12,"context_line":"This issue was introduced when os_xenapi was split out from nova,"},{"line_number":13,"context_line":"but the UT were not similarly abstracted"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifdcddb63f64d5759640a62e8ddd3c276fa4fc743"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_de8851c7","line":14,"in_reply_to":"7f287b81_bec0e57d","updated":"2017-09-05 21:20:30.000000000","message":"Also, this doesn\u0027t appear to fix all of the places that things fail. I pulled this down and ran it against os-xenapi 0.3.0 and things still blow up, so https://review.openstack.org/#/c/500968/ is still valid.","commit_id":"dcda184e3d7c90ac00a9c7f6c45cd5a36358afee"}],"nova/tests/unit/virt/xenapi/test_vmops.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1138fd2018eb70bc7fdca0e02bba0d8464f250d6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"except ImportError:"},{"line_number":21,"context_line":"    import six.moves.xmlrpc_client as xmlrpclib"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import base64"},{"line_number":24,"context_line":"from eventlet import greenthread"},{"line_number":25,"context_line":"import mock"},{"line_number":26,"context_line":"from os_xenapi.client import host_xenstore"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_5ee90118","line":23,"updated":"2017-09-05 20:53:51.000000000","message":"This is not a 3rd party import like eventlet, it should be in the first section with uuid above.","commit_id":"dcda184e3d7c90ac00a9c7f6c45cd5a36358afee"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1138fd2018eb70bc7fdca0e02bba0d8464f250d6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from eventlet import greenthread"},{"line_number":25,"context_line":"import mock"},{"line_number":26,"context_line":"from os_xenapi.client import host_xenstore"},{"line_number":27,"context_line":"import six"},{"line_number":28,"context_line":"import zlib"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from nova.compute import power_state"},{"line_number":31,"context_line":"from nova.compute import task_states"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_7e8cbd7e","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":11},"updated":"2017-09-05 20:53:51.000000000","message":"This is the 3rd party import section. zlib should go next to the uuid module import above.","commit_id":"dcda184e3d7c90ac00a9c7f6c45cd5a36358afee"}],"nova/virt/xenapi/fake.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"8c6f59a712ad50b917a6124fe8b954918c302ecc","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            return meth(*full_params)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    def call_xenapi(self, *args):"},{"line_number":902,"context_line":"        meth \u003d getattr(self, args[0], None)"},{"line_number":903,"context_line":"        if meth is None:"},{"line_number":904,"context_line":"            LOG.debug(\u0027Raising NotImplemented\u0027)"},{"line_number":905,"context_line":"            raise NotImplementedError("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_12107756","line":902,"updated":"2017-08-31 12:33:54.000000000","message":"A better fix would be to \"return self.xenapi_request(args[0], args[1:])\"","commit_id":"520c8acd6601e24e1dabe07736b77679703f5e59"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"69c5a5f787e1610b95cd77a92d284b8f1b5f6306","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            return meth(*full_params)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    def call_xenapi(self, *args):"},{"line_number":902,"context_line":"        meth \u003d getattr(self, args[0], None)"},{"line_number":903,"context_line":"        if meth is None:"},{"line_number":904,"context_line":"            LOG.debug(\u0027Raising NotImplemented\u0027)"},{"line_number":905,"context_line":"            raise NotImplementedError("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_63c12b54","line":902,"in_reply_to":"7f287b81_12107756","updated":"2017-08-31 14:03:41.000000000","message":"Looks so, just as session.py does in os-xenapi. :)","commit_id":"520c8acd6601e24e1dabe07736b77679703f5e59"}]}