)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5739cab296f8d0c3479503f492ad025e707a7222","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"                           \u0027status\u0027: \u0027ACTIVE\u0027}"},{"line_number":1688,"context_line":"        server \u003d self._wait_for_server_parameter(self.api, server,"},{"line_number":1689,"context_line":"                                                 expected_params)"},{"line_number":1690,"context_line":""},{"line_number":1691,"context_line":"        # Expect to have allocation and usages on both computes as the"},{"line_number":1692,"context_line":"        # source compute is still down"},{"line_number":1693,"context_line":"        source_rp_uuid \u003d self._get_provider_uuid_by_host(source_hostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_267f95ac","line":1690,"updated":"2017-09-01 14:42:26.000000000","message":"I\u0027m wondering if it worth a new patch set to plug a self._run_periodics() here to 1) show that running periodic healing will not fix the bug. 2) see if in the future periodic healing will overwrite a good allocation.","commit_id":"0d099fb3c82dcf3eabe701c8806ef65d33fe1df6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef4f7f9a4d198a2fd4c5a8b1c68e757b30265cfb","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"                           \u0027status\u0027: \u0027ACTIVE\u0027}"},{"line_number":1688,"context_line":"        server \u003d self._wait_for_server_parameter(self.api, server,"},{"line_number":1689,"context_line":"                                                 expected_params)"},{"line_number":1690,"context_line":""},{"line_number":1691,"context_line":"        # Expect to have allocation and usages on both computes as the"},{"line_number":1692,"context_line":"        # source compute is still down"},{"line_number":1693,"context_line":"        source_rp_uuid \u003d self._get_provider_uuid_by_host(source_hostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_5ca15495","line":1690,"in_reply_to":"7f287b81_267f95ac","updated":"2017-09-01 15:28:49.000000000","message":"Yeah good point. I was actually thinking of something similar late last night about running the periodics in a related test for a bug in the compute manager:\n\nhttps://review.openstack.org/#/c/499874/","commit_id":"0d099fb3c82dcf3eabe701c8806ef65d33fe1df6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5739cab296f8d0c3479503f492ad025e707a7222","unresolved":false,"context_lines":[{"line_number":1716,"context_line":"        self.compute1.start()"},{"line_number":1717,"context_line":"        self.admin_api.put_service("},{"line_number":1718,"context_line":"            source_compute_id, {\u0027forced_down\u0027: \u0027false\u0027})"},{"line_number":1719,"context_line":""},{"line_number":1720,"context_line":"        # When the source node starts up, the instance has moved so the"},{"line_number":1721,"context_line":"        # ResourceTracker should cleanup allocations for the source node."},{"line_number":1722,"context_line":"        source_usages \u003d self._get_provider_usages(source_rp_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_f945b244","line":1719,"updated":"2017-09-01 14:42:26.000000000","message":"ditto","commit_id":"0d099fb3c82dcf3eabe701c8806ef65d33fe1df6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"837c1f5a60b2e9a3fd6b0ce5f10aeed0f5c80aa6","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"            self.flavor1, source_hostname)"},{"line_number":1668,"context_line":""},{"line_number":1669,"context_line":"        source_compute_id \u003d self.admin_api.get_services("},{"line_number":1670,"context_line":"            host\u003dsource_hostname, binary\u003d\u0027nova-compute\u0027)[0][\u0027id\u0027]"},{"line_number":1671,"context_line":""},{"line_number":1672,"context_line":"        self.compute1.stop()"},{"line_number":1673,"context_line":"        # force it down to avoid waiting for the service group to time out"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_4f083427","line":1670,"updated":"2017-09-05 16:41:12.000000000","message":"I\u0027m not sure but I think we can get the service ID directly using the Service object like this :\n\n self.compute1.service_ref.id \n\nbut given we already have a full ton of tests calling the API for knowing that, it\u0027s just a nit.","commit_id":"f34b487db4864787ad92f5a7d6568f31812f1ddb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"86481d5ec880b726ea66ffe0f7c6c502c18a85ef","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"            self.flavor1, source_hostname)"},{"line_number":1668,"context_line":""},{"line_number":1669,"context_line":"        source_compute_id \u003d self.admin_api.get_services("},{"line_number":1670,"context_line":"            host\u003dsource_hostname, binary\u003d\u0027nova-compute\u0027)[0][\u0027id\u0027]"},{"line_number":1671,"context_line":""},{"line_number":1672,"context_line":"        self.compute1.stop()"},{"line_number":1673,"context_line":"        # force it down to avoid waiting for the service group to time out"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_2b747567","line":1670,"in_reply_to":"7f287b81_4f083427","updated":"2017-09-07 15:49:59.000000000","message":"I think we need the compute node uuid not the service id (or uuid). At lest I tried what you suggested and it didn\u0027t work","commit_id":"f34b487db4864787ad92f5a7d6568f31812f1ddb"}]}
