)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"75d73da2f03c0923e5e8d9a361b9078317051c4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem.os@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-01 13:56:38 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update docs for _destroy_evacuated_instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docstring on this method no longer reflects reality,"},{"line_number":10,"context_line":"and hasn\u0027t since we started filtering on migration records"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_6849e689","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":43},"updated":"2017-09-01 18:27:25.000000000","message":"_destroy_evacuated_instances, plural, dagnabbit","commit_id":"a996c1da53ea0d04f0d47b9eca0c8814601bfad8"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"05add4d82ee3858950e1fd715b8d8129fc6d654c","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        records where this is the source host and which were either started"},{"line_number":633,"context_line":"        (accepted) or complete (done). From those migration records, local"},{"line_number":634,"context_line":"        instances reported by the hypervisor are compared to the instances"},{"line_number":635,"context_line":"        for the migration records and those local guests are destroyed, along"},{"line_number":636,"context_line":"        with instance allocation records in Placement for this node."},{"line_number":637,"context_line":"        \"\"\""},{"line_number":638,"context_line":"        filters \u003d {"},{"line_number":639,"context_line":"            \u0027source_compute\u0027: self.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_3bd2ee35","line":636,"range":{"start_line":635,"start_character":72,"end_line":636,"end_character":68},"updated":"2017-09-04 10:02:39.000000000","message":"I would note that this is not the case right now due to the bug #1714924","commit_id":"aec81e7d98c1ca082abd157dab5cc83b5bedfd89"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a286ca65d6185bfe86796956f0307b737b30d720","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        records where this is the source host and which were either started"},{"line_number":633,"context_line":"        (accepted) or complete (done). From those migration records, local"},{"line_number":634,"context_line":"        instances reported by the hypervisor are compared to the instances"},{"line_number":635,"context_line":"        for the migration records and those local guests are destroyed, along"},{"line_number":636,"context_line":"        with instance allocation records in Placement for this node."},{"line_number":637,"context_line":"        \"\"\""},{"line_number":638,"context_line":"        filters \u003d {"},{"line_number":639,"context_line":"            \u0027source_compute\u0027: self.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_98cde186","line":636,"range":{"start_line":635,"start_character":72,"end_line":636,"end_character":68},"in_reply_to":"5f2577a7_d9d702ee","updated":"2017-09-18 11:36:22.000000000","message":"As we agreed on that the bug fix is to set the migration to error state I\u0027m OK with this note.","commit_id":"aec81e7d98c1ca082abd157dab5cc83b5bedfd89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f712c74c5c7d52935f2c575e4b2f0435b43a8206","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        records where this is the source host and which were either started"},{"line_number":633,"context_line":"        (accepted) or complete (done). From those migration records, local"},{"line_number":634,"context_line":"        instances reported by the hypervisor are compared to the instances"},{"line_number":635,"context_line":"        for the migration records and those local guests are destroyed, along"},{"line_number":636,"context_line":"        with instance allocation records in Placement for this node."},{"line_number":637,"context_line":"        \"\"\""},{"line_number":638,"context_line":"        filters \u003d {"},{"line_number":639,"context_line":"            \u0027source_compute\u0027: self.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_d9d702ee","line":636,"range":{"start_line":635,"start_character":72,"end_line":636,"end_character":68},"in_reply_to":"7f287b81_3bd2ee35","updated":"2017-09-16 13:54:04.000000000","message":"I\u0027m not sure if we care about that now since we agreed to set the migration status to \u0027error\u0027 if we fail to find a host in conductor. And if the evacuation fails in the dest compute then the migration status is \u0027failed\u0027 so in either of those failure cases, we won\u0027t process those migration records/instances here. So this is really just explaining what happens in the normal flow.","commit_id":"aec81e7d98c1ca082abd157dab5cc83b5bedfd89"}]}
