)]}'
{"nova/api/openstack/compute/schemas/server_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ac76b80e820e6beefcd316ab9241e5f1c012ef7e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027offset\u0027: parameter_types.common_query_param,"},{"line_number":60,"context_line":"        \u0027limit\u0027: parameter_types.common_query_param,"},{"line_number":61,"context_line":"    },"},{"line_number":62,"context_line":"    # For backward compatible changes"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_f7a6a7ab","line":59,"range":{"start_line":59,"start_character":9,"end_line":59,"end_character":52},"updated":"2017-09-05 08:21:07.000000000","message":"ditto","commit_id":"8be6ff89d35e1913dcca49a8016cc154f2142144"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ac76b80e820e6beefcd316ab9241e5f1c012ef7e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027offset\u0027: parameter_types.common_query_param,"},{"line_number":60,"context_line":"        \u0027limit\u0027: parameter_types.common_query_param,"},{"line_number":61,"context_line":"    },"},{"line_number":62,"context_line":"    # For backward compatible changes"},{"line_number":63,"context_line":"    \u0027additionalProperties\u0027: True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_3778af29","line":60,"range":{"start_line":60,"start_character":33,"end_line":60,"end_character":51},"updated":"2017-09-05 08:21:07.000000000","message":"this is not of type string. it should be non_negative_integer with multi param.\n\nBut this can lead to restrict the int convertible string like \u00271\u0027 which are allowed now and gets converted to int by utils.\nLet me check with Alex what we decided on this in original BP.","commit_id":"8be6ff89d35e1913dcca49a8016cc154f2142144"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1a3229a0ca62e560739792ec6f87a1a5342368e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027offset\u0027: parameter_types.common_query_param,"},{"line_number":60,"context_line":"        \u0027limit\u0027: parameter_types.common_query_param,"},{"line_number":61,"context_line":"    },"},{"line_number":62,"context_line":"    # For backward compatible changes"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_01d11255","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":52},"updated":"2017-09-24 15:48:27.000000000","message":"offset has to be int always.","commit_id":"7a1a9fb8b2c09e5a5c496aa7665bf3146aced270"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d5aa48e2adc6484e59b617a4bafacfd7bf232249","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027offset\u0027: parameter_types.common_query_param,"},{"line_number":60,"context_line":"        \u0027limit\u0027: parameter_types.common_query_param,"},{"line_number":61,"context_line":"    },"},{"line_number":62,"context_line":"    # For backward compatible changes"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_43812b4a","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":52},"in_reply_to":"7f515b1d_01d11255","updated":"2017-09-26 01:22:28.000000000","message":"yes, you are right","commit_id":"7a1a9fb8b2c09e5a5c496aa7665bf3146aced270"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1a3229a0ca62e560739792ec6f87a1a5342368e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027offset\u0027: parameter_types.common_query_param,"},{"line_number":60,"context_line":"        \u0027limit\u0027: parameter_types.common_query_param,"},{"line_number":61,"context_line":"    },"},{"line_number":62,"context_line":"    # For backward compatible changes"},{"line_number":63,"context_line":"    \u0027additionalProperties\u0027: True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_41d70a4d","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":51},"updated":"2017-09-24 15:48:27.000000000","message":"why limit needs to be string, we need to restrict it to integer only.","commit_id":"7a1a9fb8b2c09e5a5c496aa7665bf3146aced270"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d5aa48e2adc6484e59b617a4bafacfd7bf232249","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027offset\u0027: parameter_types.common_query_param,"},{"line_number":60,"context_line":"        \u0027limit\u0027: parameter_types.common_query_param,"},{"line_number":61,"context_line":"    },"},{"line_number":62,"context_line":"    # For backward compatible changes"},{"line_number":63,"context_line":"    \u0027additionalProperties\u0027: True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_e391379b","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":51},"in_reply_to":"7f515b1d_41d70a4d","updated":"2017-09-26 01:22:28.000000000","message":"ok, thanks","commit_id":"7a1a9fb8b2c09e5a5c496aa7665bf3146aced270"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8fe644d35e84ceb3101f6d70af2e0524cfe51ed3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027limit\u0027: parameter_types.single_param("},{"line_number":60,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":61,"context_line":"        \u0027offset\u0027: parameter_types.single_param("},{"line_number":62,"context_line":"             parameter_types.non_negative_integer),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_d91bce18","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":45},"updated":"2017-09-26 02:45:53.000000000","message":"this should be multi_param. in current code, we do accept the multi value and fetch the as per https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L202\n\nLet\u0027s not change the behavior and keep accepting the multi value. if we want to make in single value which is better we need version bump.","commit_id":"d5ade9a993aef05a4ffad892f9e15d509628d481"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"23746884020d57fe9825ad654e35416bc15b37e0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027limit\u0027: parameter_types.single_param("},{"line_number":60,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":61,"context_line":"        \u0027offset\u0027: parameter_types.single_param("},{"line_number":62,"context_line":"             parameter_types.non_negative_integer),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_c58174fd","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":45},"in_reply_to":"7f515b1d_d91bce18","updated":"2017-09-27 06:10:09.000000000","message":"ok","commit_id":"d5ade9a993aef05a4ffad892f9e15d509628d481"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8fe644d35e84ceb3101f6d70af2e0524cfe51ed3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027limit\u0027: parameter_types.single_param("},{"line_number":60,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":61,"context_line":"        \u0027offset\u0027: parameter_types.single_param("},{"line_number":62,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":63,"context_line":"    },"},{"line_number":64,"context_line":"    # For backward compatible changes"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_b916d2f0","line":61,"range":{"start_line":61,"start_character":34,"end_line":61,"end_character":46},"updated":"2017-09-26 02:45:53.000000000","message":"ditto","commit_id":"d5ade9a993aef05a4ffad892f9e15d509628d481"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9000c110fbdca0106dbd46eb788ffbe49199823a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"server_groups_query_param \u003d {"},{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":60,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":61,"context_line":"        \u0027offset\u0027: parameter_types.multi_params("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_6a0b7a23","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":58},"updated":"2017-10-25 13:24:07.000000000","message":"The API reference says this is a boolean but we don\u0027t actually care about the value, so this type is correct, and can be specified multiple times even though it\u0027s only needed once.","commit_id":"d4111fccb29e92e0d8aa77668a71d8173fcf8fdc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9000c110fbdca0106dbd46eb788ffbe49199823a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":60,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":61,"context_line":"        \u0027offset\u0027: parameter_types.multi_params("},{"line_number":62,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":63,"context_line":"    },"},{"line_number":64,"context_line":"    # For backward compatible changes"},{"line_number":65,"context_line":"    \u0027additionalProperties\u0027: True"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_e74203ab","line":62,"range":{"start_line":59,"start_character":8,"end_line":62,"end_character":51},"updated":"2017-10-25 13:24:07.000000000","message":"So these are OK because common.limited is already enforcing that they are ints \u003e\u003d 0.","commit_id":"d4111fccb29e92e0d8aa77668a71d8173fcf8fdc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27770d1a89dfaabe4a88c5b16f609b6cee23b924","unresolved":false,"context_lines":[{"line_number":55,"context_line":"server_groups_query_param \u003d {"},{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":60,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":61,"context_line":"        \u0027offset\u0027: parameter_types.multi_params("}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_42733cb2","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":58},"updated":"2017-11-22 16:15:24.000000000","message":"I tend to agree with @gmann that multi_param is more explicit than common_query_param. What exactly does common_query_param even mean? Basically, I\u0027d have to look it up since it\u0027s not obvious like \"multi_param\" is...","commit_id":"9edc8638766954d32be8ca3829b6814c941a025c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"18eb789ff5c588e372465bfd0c5810c824eb08dc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"server_groups_query_param \u003d {"},{"line_number":56,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":57,"context_line":"    \u0027properties\u0027: {"},{"line_number":58,"context_line":"        \u0027all_projects\u0027: parameter_types.common_query_param,"},{"line_number":59,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":60,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":61,"context_line":"        \u0027offset\u0027: parameter_types.multi_params("}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_d2bc9707","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":58},"in_reply_to":"ff82abbf_42733cb2","updated":"2017-11-28 06:33:27.000000000","message":"Done","commit_id":"9edc8638766954d32be8ca3829b6814c941a025c"}],"nova/api/openstack/compute/server_groups.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9000c110fbdca0106dbd46eb788ffbe49199823a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @extensions.expected_errors(())"},{"line_number":134,"context_line":"    @validation.query_schema(schema.server_groups_query_param)"},{"line_number":135,"context_line":"    def index(self, req):"},{"line_number":136,"context_line":"        \"\"\"Returns a list of server groups.\"\"\""},{"line_number":137,"context_line":"        context \u003d _authorize_context(req, \u0027index\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_87ceaf2a","line":134,"updated":"2017-10-25 13:24:07.000000000","message":"Since you\u0027re not specifying a min_version here, 2.0 is valid, correct? Then you should probably have at least one unit test passing 2.0 as the version to make sure this works.","commit_id":"d4111fccb29e92e0d8aa77668a71d8173fcf8fdc"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"00b6555adfa37bc0ac28f983731bbdd9568ee8d7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @extensions.expected_errors(())"},{"line_number":134,"context_line":"    @validation.query_schema(schema.server_groups_query_param)"},{"line_number":135,"context_line":"    def index(self, req):"},{"line_number":136,"context_line":"        \"\"\"Returns a list of server groups.\"\"\""},{"line_number":137,"context_line":"        context \u003d _authorize_context(req, \u0027index\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_969d5f0c","line":134,"in_reply_to":"3f4b6375_87ceaf2a","updated":"2017-10-30 01:13:25.000000000","message":"ok, will add a new one","commit_id":"d4111fccb29e92e0d8aa77668a71d8173fcf8fdc"}],"nova/tests/unit/api/openstack/compute/test_server_groups.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"17bcc169dbfc150ade0c7ca3267d04ad5c7ee7ef","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    def test_list_server_group_param_as_int(self):"},{"line_number":525,"context_line":"        self._test_list_server_group(api_version\u003d\u00272.1\u0027, limited\u003dTrue,"},{"line_number":526,"context_line":"            path\u003d\u0027/os-server-groups?all_projects\u003d1\u0027)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    def test_list_server_groups_rbac_admin_only(self):"},{"line_number":529,"context_line":"        # override policy to restrict to admin"},{"line_number":530,"context_line":"        rule_name \u003d sg_policies.POLICY_ROOT % \u0027index\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_143a00cb","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":0},"updated":"2017-09-28 01:52:17.000000000","message":"I want to see more test covering schema cases-\n- test_list_server_group_multiple_param should be for \u0027limit\u0027 and \u0027offset\u0027\n- test_list_server_group_negative_int_as_limit\n- test_list_server_group_string_as_limit\n- test_list_server_group_multi_param_with_string_as_offset\n- test_list_server_group_negative_int_as_offset\n- test_list_server_group_string_as_offset\n- test_list_server_group_multi_param_with_string_as_offset","commit_id":"59f9cf268037e422851e92ed415f6ab45991cc76"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"66d334d2299fd6eeca0e6e3e912ac26ec065e042","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _test_list_server_group_all(self, api_version\u003d\u00272.1\u0027):"},{"line_number":194,"context_line":"        self._test_list_server_group(api_version\u003dapi_version,"},{"line_number":195,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":196,"context_line":"            path\u003d\u0027/os-server-groups?all_projects\u003dTrue\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _test_list_server_group_offset_and_limit(self, api_version\u003d\u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_50907c95","line":195,"range":{"start_line":195,"start_character":20,"end_line":195,"end_character":39},"updated":"2017-11-28 10:32:52.000000000","message":"False","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c99b9e8473fe0138712a2383b24a836473fc273f","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _test_list_server_group_all(self, api_version\u003d\u00272.1\u0027):"},{"line_number":194,"context_line":"        self._test_list_server_group(api_version\u003dapi_version,"},{"line_number":195,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":196,"context_line":"            path\u003d\u0027/os-server-groups?all_projects\u003dTrue\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _test_list_server_group_offset_and_limit(self, api_version\u003d\u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_994dcf3f","line":195,"range":{"start_line":195,"start_character":20,"end_line":195,"end_character":39},"in_reply_to":"ff82abbf_50907c95","updated":"2017-11-28 13:07:22.000000000","message":"no, this should  be this value, not False \nas we changed to sting now..","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"8936f7b4a212512c6cffdde2dfc1ff7afd0974b3","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _test_list_server_group_all(self, api_version\u003d\u00272.1\u0027):"},{"line_number":194,"context_line":"        self._test_list_server_group(api_version\u003dapi_version,"},{"line_number":195,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":196,"context_line":"            path\u003d\u0027/os-server-groups?all_projects\u003dTrue\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _test_list_server_group_offset_and_limit(self, api_version\u003d\u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_f233c2a9","line":195,"range":{"start_line":195,"start_character":20,"end_line":195,"end_character":39},"in_reply_to":"ff82abbf_994dcf3f","updated":"2017-11-28 23:55:45.000000000","message":"In line 260, the value of \u0027limited\u0027 is not appended to a URL path if \u0027limited\u0027 is False.\nSo it can be False.","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c8d8563ad3db271b6cd1068cec99c1cd1295c434","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _test_list_server_group_all(self, api_version\u003d\u00272.1\u0027):"},{"line_number":194,"context_line":"        self._test_list_server_group(api_version\u003dapi_version,"},{"line_number":195,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":196,"context_line":"            path\u003d\u0027/os-server-groups?all_projects\u003dTrue\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _test_list_server_group_offset_and_limit(self, api_version\u003d\u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_646fe52a","line":195,"range":{"start_line":195,"start_character":20,"end_line":195,"end_character":39},"in_reply_to":"ff82abbf_f233c2a9","updated":"2017-11-29 08:14:42.000000000","message":"yes, thanks for point out","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"66d334d2299fd6eeca0e6e3e912ac26ec065e042","unresolved":false,"context_lines":[{"line_number":519,"context_line":"            limited\u003d\u0027\u0026offset\u003d2\u0026limit\u003d2\u0026limit\u003d1\u0026offset\u003d1\u0027,"},{"line_number":520,"context_line":"            path\u003d\u0027/os-server-groups?all_projects\u003dFalse\u0026all_projects\u003dTrue\u0027)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def test_list_server_group_unknow_param(self):"},{"line_number":523,"context_line":"        self._test_list_server_group(api_version\u003d\u00272.1\u0027,"},{"line_number":524,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":525,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dTrue\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_b010e84f","line":522,"range":{"start_line":522,"start_character":31,"end_line":522,"end_character":37},"updated":"2017-11-28 10:32:52.000000000","message":"unknown","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c99b9e8473fe0138712a2383b24a836473fc273f","unresolved":false,"context_lines":[{"line_number":519,"context_line":"            limited\u003d\u0027\u0026offset\u003d2\u0026limit\u003d2\u0026limit\u003d1\u0026offset\u003d1\u0027,"},{"line_number":520,"context_line":"            path\u003d\u0027/os-server-groups?all_projects\u003dFalse\u0026all_projects\u003dTrue\u0027)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def test_list_server_group_unknow_param(self):"},{"line_number":523,"context_line":"        self._test_list_server_group(api_version\u003d\u00272.1\u0027,"},{"line_number":524,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":525,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dTrue\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_b948d32c","line":522,"range":{"start_line":522,"start_character":31,"end_line":522,"end_character":37},"in_reply_to":"ff82abbf_b010e84f","updated":"2017-11-28 13:07:22.000000000","message":"Done","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"66d334d2299fd6eeca0e6e3e912ac26ec065e042","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":525,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dTrue\u0027)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def test_list_server_group_additional_param(self):"},{"line_number":528,"context_line":"        self._test_list_server_group(api_version\u003d\u00272.1\u0027,"},{"line_number":529,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":530,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dFalse\u0026all_projects\u003dTrue\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_f07190a9","line":527,"range":{"start_line":527,"start_character":8,"end_line":527,"end_character":47},"updated":"2017-11-28 10:32:52.000000000","message":"This and line 522 (test_list_server_group_unknow_param) are essentially the same.\nThe one can be deleted.","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c8d8563ad3db271b6cd1068cec99c1cd1295c434","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":525,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dTrue\u0027)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def test_list_server_group_additional_param(self):"},{"line_number":528,"context_line":"        self._test_list_server_group(api_version\u003d\u00272.1\u0027,"},{"line_number":529,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":530,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dFalse\u0026all_projects\u003dTrue\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_e464554c","line":527,"range":{"start_line":527,"start_character":8,"end_line":527,"end_character":47},"in_reply_to":"ff82abbf_92b4b6f3","updated":"2017-11-29 08:14:42.000000000","message":"ok, seems an alternative","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"8936f7b4a212512c6cffdde2dfc1ff7afd0974b3","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":525,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dTrue\u0027)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def test_list_server_group_additional_param(self):"},{"line_number":528,"context_line":"        self._test_list_server_group(api_version\u003d\u00272.1\u0027,"},{"line_number":529,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":530,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dFalse\u0026all_projects\u003dTrue\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_92b4b6f3","line":527,"range":{"start_line":527,"start_character":8,"end_line":527,"end_character":47},"in_reply_to":"ff82abbf_d95837fb","updated":"2017-11-28 23:55:45.000000000","message":"IMO, \u0027test_list_server_group_unknown_param\u0027 is redundant.\nIt should be removed.","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c99b9e8473fe0138712a2383b24a836473fc273f","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":525,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dTrue\u0027)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def test_list_server_group_additional_param(self):"},{"line_number":528,"context_line":"        self._test_list_server_group(api_version\u003d\u00272.1\u0027,"},{"line_number":529,"context_line":"            limited\u003d\u0027\u0026offset\u003d1\u0026limit\u003d1\u0027,"},{"line_number":530,"context_line":"            path\u003d\u0027/os-server-groups?dummy\u003dFalse\u0026all_projects\u003dTrue\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_d95837fb","line":527,"range":{"start_line":527,"start_character":8,"end_line":527,"end_character":47},"in_reply_to":"ff82abbf_f07190a9","updated":"2017-11-28 13:07:22.000000000","message":"this will check case \nall_projects (which is valid) + dummy (which is invalid)","commit_id":"fca8dd26fda8a0ade679e3444f57f885800edfe1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6454fee1c4025151aede409a36d56c3310525b9d","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _test_list_server_group_all(self, api_version\u003d\u00272.1\u0027):"},{"line_number":194,"context_line":"        self._test_list_server_group(api_version\u003dapi_version,"},{"line_number":195,"context_line":"            limited\u003d\u0027\u0027,"},{"line_number":196,"context_line":"            path\u003d\u0027/os-server-groups?all_projects\u003dTrue\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _test_list_server_group_offset_and_limit(self, api_version\u003d\u00272.1\u0027):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_77c5320a","line":195,"updated":"2017-11-30 14:47:59.000000000","message":"As the default value of limited is None and both None and \u0027\u0027 evaluated to False at L260 you can simply left out the limited parameter from this call.","commit_id":"b8ff742bd7c9f90461831ef01e21813f49d03eb1"}]}