)]}'
{"nova/privsep/fs.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7538cf720a13a65865a9f52cba2dddc2af8d0284","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"},{"line_number":113,"context_line":"def create_device_maps(device):"},{"line_number":114,"context_line":"    return processutils.execute(\u0027kpartx\u0027, \u0027-a\u0027, device, discard_warnings\u003dTrue)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_95b2cbe5","line":114,"range":{"start_line":114,"start_character":56,"end_line":114,"end_character":77},"updated":"2017-09-25 16:02:57.000000000","message":"this doesn\u0027t appear to be a valid argument for \u0027execute\u0027 - I see only references to this in \u0027trycmd\u0027 [1]. Did you mean to use the latter?\n\n[1] https://github.com/openstack/oslo.concurrency/blob/3.23.0/oslo_concurrency/processutils.py#L477-L483","commit_id":"1ea49cd40da92c4c93061fb8e4f6a9a31cf3648e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"09c620b72ff14f1d31ff8de3a773c0589f1a3ef5","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"},{"line_number":113,"context_line":"def create_device_maps(device):"},{"line_number":114,"context_line":"    return processutils.execute(\u0027kpartx\u0027, \u0027-a\u0027, device, discard_warnings\u003dTrue)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"@nova.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f4b6375_a0209849","line":114,"range":{"start_line":114,"start_character":56,"end_line":114,"end_character":77},"updated":"2017-10-24 12:23:35.000000000","message":"as stephen said, this isn\u0027t a valid parameter here (execute has so many params it only uses them as kwargs so this is just getting silently ignored).\n\nIt\u0027s worth deleting it.","commit_id":"527ec66ffc22513cddea18a2020fdb5d158aa4a7"}]}
