)]}'
{"id":"openstack%2Fnova~500968","triplet_id":"openstack%2Fnova~master~Ida4b8c33e8b3bbd03548648f8e57d923b255f35c","project":"openstack/nova","branch":"master","topic":"bug/1715217","hashtags":[],"change_id":"Ida4b8c33e8b3bbd03548648f8e57d923b255f35c","subject":"Make xen unit tests work with os-xenapi\u003e\u003d0.3.0","status":"MERGED","created":"2017-09-05 20:07:32.000000000","updated":"2017-09-07 02:38:33.000000000","submitted":"2017-09-06 18:03:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e21cf4bae364cb35951020106b63b5013758501d","_number":500968,"virtual_id_number":500968,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},{"value":0,"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},{"value":2,"date":"2017-09-06 18:03:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":2,"date":"2017-09-06 14:09:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":1,"date":"2017-09-06 09:37:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},{"value":2,"date":"2017-09-06 14:08:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2017-09-06 03:58:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},{"value":0,"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":1,"date":"2017-09-06 14:13:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},{"value":0,"date":"2017-09-07 02:38:33.000000000","post_submit":true,"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},{"value":0,"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-09-06 03:58:53.000000000","updated_by":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"reviewer":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"state":"REVIEWER"},{"updated":"2017-09-06 09:37:30.000000000","updated_by":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"reviewer":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"state":"REVIEWER"},{"updated":"2017-09-06 14:08:28.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2017-09-06 14:13:50.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2017-09-06 18:03:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-09-07 02:38:33.000000000","updated_by":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"reviewer":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"state":"REVIEWER"}],"messages":[{"id":"67ae8ac243080823e5fda48822ee45c6c95a8807","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-09-05 20:07:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"edea5365ee30086b06022f25484a3b2eedc9b5df","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2017-09-05 20:08:10.000000000","message":"Patch Set 1:\n\n* pci-test http://52.27.155.124/pci/500968/1 : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"82d41347c8020d5e486a56f1bd3550c596fb01f8","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2017-09-05 20:18:12.000000000","message":"Patch Set 1: Code-Review-1\n\nI would prefer the fix at https://review.openstack.org/#/c/499573/ were merged instead","accounts_in_message":[],"_revision_number":1},{"id":"f67e6ed2290611a02071f136a401c386ebae6e62","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-09-05 21:20:35.000000000","message":"Patch Set 1:\n\nThat doesn\u0027t fix the bug.","accounts_in_message":[],"_revision_number":1},{"id":"aab9de2993d5a012aa7dbe9d2e4deb936c8b3bf0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-05 21:27:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-docs-ubuntu-xenial http://docs-draft.openstack.org/68/500968/1/check/gate-nova-docs-ubuntu-xenial/75da9a7//doc/build/html/ : SUCCESS in 5m 46s\n- gate-nova-pep8-ubuntu-xenial http://logs.openstack.org/68/500968/1/check/gate-nova-pep8-ubuntu-xenial/0ba360b/ : SUCCESS in 8m 40s\n- gate-nova-python27-ubuntu-xenial http://logs.openstack.org/68/500968/1/check/gate-nova-python27-ubuntu-xenial/7a81298/ : SUCCESS in 12m 27s\n- gate-nova-python35 http://logs.openstack.org/68/500968/1/check/gate-nova-python35/acca6f6/ : SUCCESS in 12m 17s\n- gate-nova-tox-functional-ubuntu-xenial http://logs.openstack.org/68/500968/1/check/gate-nova-tox-functional-ubuntu-xenial/dd610f6/ : SUCCESS in 27m 39s\n- gate-nova-tox-functional-py35-ubuntu-xenial http://logs.openstack.org/68/500968/1/check/gate-nova-tox-functional-py35-ubuntu-xenial/941f598/ : SUCCESS in 20m 28s","accounts_in_message":[],"_revision_number":1},{"id":"930e0a0641eed7a3e0efeb604b4695ffb92e4280","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2017-09-05 22:35:07.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/68/500968/1/check/nova-out-of-tree-pvm/77f8553 : SUCCESS in 2h 27m 07s\n- nova-in-tree-pvm http://184.172.12.213/68/500968/1/check/nova-in-tree-pvm/e72f0e8 : FAILURE in 37m 31s","accounts_in_message":[],"_revision_number":1},{"id":"bae05cd2dd232002211cad0b994db28fa90aacea","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2017-09-05 23:52:13.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova-dsvm-full-tempest http://cloudbase-ci.com/nova/500968/1/ : SUCCESS in 2h 07m 38s","accounts_in_message":[],"_revision_number":1},{"id":"bf898d92abc926b69221a8eefca37149c32183e3","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2017-09-06 01:21:33.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-68-500968-1 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":1},{"id":"83e3ed342fc041960185fd19bee4aeffe2b96ef5","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2017-09-06 01:39:41.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/500968/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/2e7f39c : FAILURE in 1h 49m 30s","accounts_in_message":[],"_revision_number":1},{"id":"dccf0c5da0ed4aad8e1b3a2bcdec42de86bcd363","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2017-09-06 03:31:58.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- dsvm-nova http://207.189.188.190/logs/68/500968/1/check-vote/ext-nova-zuul/94bcf1a : FAILURE in 1h 14m 05s","accounts_in_message":[],"_revision_number":1},{"id":"cf7536959cb8ae63f34ec767bc7ea564fd03f54e","author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"date":"2017-09-06 03:58:53.000000000","message":"Patch Set 1: Code-Review+1\n\nFor short term, I\u0027d suggest we merge this change to fix the bug. So that we can proceed quickly.\nAnd we can use https://review.openstack.org/#/c/499573 to do unit test refactoring to remove the incorrect dependence on os-xenapi internal implementations.","accounts_in_message":[],"_revision_number":1},{"id":"c847031fd5f5970c6d5384a0daf0957d8e080355","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2017-09-06 09:37:30.000000000","message":"Patch Set 1: Code-Review+1\n\nI really don\u0027t like the fact that Nova needs to change based on os-xenapi internals, but I guess this is OK until we can figure out the full fix for the mocking.\nIt looks like a lot of the stub UTs will need changing, so we need to look at a larger work unit to rework these to use mock properly","accounts_in_message":[],"_revision_number":1},{"id":"dd6099ae9dbd88d8152aaae6aede114b123fbea4","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-09-06 14:08:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"185828d0bc5a6036e3b5daa954fef746dccb95a8","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2017-09-06 14:09:23.000000000","message":"Patch Set 1: Code-Review+2\n\nI\u0027d like to wait for XenServer CI to tell me OK before approving that one.","accounts_in_message":[],"_revision_number":1},{"id":"f4749599361a2cce9b429da6b2617f4341a90407","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2017-09-06 14:13:50.000000000","message":"Patch Set 1: Workflow+1\n\nNevermind my previous comment, 3rd-party CIs only gate on Tempest tests...","accounts_in_message":[],"_revision_number":1},{"id":"ede3ba36d92bb8bfd24e48814b57a0f954a449ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-06 14:14:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f95aad7d27b4029f3e64c7ec5d12fa0d57d5218f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-06 18:03:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-nova-docs-ubuntu-xenial http://docs-draft.openstack.org/68/500968/1/gate/gate-nova-docs-ubuntu-xenial/5b16ea9//doc/build/html/ : SUCCESS in 5m 06s\n- gate-nova-pep8-ubuntu-xenial http://logs.openstack.org/68/500968/1/gate/gate-nova-pep8-ubuntu-xenial/df51291/ : SUCCESS in 8m 53s\n- gate-nova-python27-ubuntu-xenial http://logs.openstack.org/68/500968/1/gate/gate-nova-python27-ubuntu-xenial/bc0ad3c/ : SUCCESS in 12m 27s\n- gate-nova-python35 http://logs.openstack.org/68/500968/1/gate/gate-nova-python35/9573015/ : SUCCESS in 11m 54s\n- gate-nova-tox-functional-ubuntu-xenial http://logs.openstack.org/68/500968/1/gate/gate-nova-tox-functional-ubuntu-xenial/25bdad9/ : SUCCESS in 19m 33s\n- gate-nova-tox-functional-py35-ubuntu-xenial http://logs.openstack.org/68/500968/1/gate/gate-nova-tox-functional-py35-ubuntu-xenial/7252c19/ : SUCCESS in 18m 40s","accounts_in_message":[],"_revision_number":1},{"id":"b895d99cc908c3a2cc8caa4fc48457dd0f890fdd","date":"2017-09-06 18:03:54.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"81b99caae021593ba65f2fe6a2dbc0f9532d1c70","revisions":{"81b99caae021593ba65f2fe6a2dbc0f9532d1c70":{"kind":"REWORK","_number":1,"created":"2017-09-05 20:07:32.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/68/500968/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/500968/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/500968/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/500968/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/500968/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/500968/1"}}},"commit":{"parents":[{"commit":"f2b78c3a2057ae4e6f1ef36d87fb6cfb4e159326","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2b78c3a2057ae4e6f1ef36d87fb6cfb4e159326"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-09-05 20:06:31.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-09-05 20:06:31.000000000","tz":-240},"subject":"Make xen unit tests work with os-xenapi\u003e\u003d0.3.0","message":"Make xen unit tests work with os-xenapi\u003e\u003d0.3.0\n\nChange Ie1b49a206b57219083059871f326926cc4628142 in os-xenapi\n0.3.0 requires that the URL passed into the XenAPISession is\nan actual URL, which means we need to fix a bunch of unit tests.\n\nChange-Id: Ida4b8c33e8b3bbd03548648f8e57d923b255f35c\nCloses-Bug: #1715217\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/81b99caae021593ba65f2fe6a2dbc0f9532d1c70"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/81b99caae021593ba65f2fe6a2dbc0f9532d1c70"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f2b78c3a2057ae4e6f1ef36d87fb6cfb4e159326","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}