)]}'
{"nova/api/metadata/base.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84e83ad88c096c5152f2e0a5250628b9ae819850","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    \"\"\"Instance metadata.\"\"\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def __init__(self, instance, address\u003dNone, content\u003dNone, extra_md\u003dNone,"},{"line_number":113,"context_line":"                 network_info\u003dNone, vd_driver\u003dNone, network_metadata\u003dNone,"},{"line_number":114,"context_line":"                 request_context\u003dNone):"},{"line_number":115,"context_line":"        \"\"\"Creation of this object should basically cover all time consuming"},{"line_number":116,"context_line":"        collection.  Methods after that should not cause time delays due to"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_219b8218","line":113,"range":{"start_line":113,"start_character":36,"end_line":113,"end_character":50},"updated":"2017-09-07 09:20:41.000000000","message":"What is able to configure this? Can we remove this parameter? I would imagine it\u0027s only used by tests, which could be handled far easier with mock","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7bfc5fc6349203b487aa9c0ef489170eaa3922f7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    \"\"\"Instance metadata.\"\"\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def __init__(self, instance, address\u003dNone, content\u003dNone, extra_md\u003dNone,"},{"line_number":113,"context_line":"                 network_info\u003dNone, vd_driver\u003dNone, network_metadata\u003dNone,"},{"line_number":114,"context_line":"                 request_context\u003dNone):"},{"line_number":115,"context_line":"        \"\"\"Creation of this object should basically cover all time consuming"},{"line_number":116,"context_line":"        collection.  Methods after that should not cause time delays due to"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_af15159e","line":113,"range":{"start_line":113,"start_character":36,"end_line":113,"end_character":50},"in_reply_to":"7f287b81_219b8218","updated":"2017-09-28 03:43:44.000000000","message":"yes, seems only for test purpose","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84e83ad88c096c5152f2e0a5250628b9ae819850","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            self.content[key] \u003d contents"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if vd_driver is None:"},{"line_number":200,"context_line":"            driver \u003d \u0027nova.api.metadata.vendordata_json.JsonFileVendorData\u0027"},{"line_number":201,"context_line":"            vdclass \u003d importutils.import_class(driver)"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            vdclass \u003d vd_driver"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_a101b23a","line":201,"range":{"start_line":200,"start_character":0,"end_line":201,"end_character":54},"updated":"2017-09-07 09:20:41.000000000","message":"Instead of using importutils, can you simply import it the usual way at the top of the file?\n\n  from nova.api.metadata import vendordata_json","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7bfc5fc6349203b487aa9c0ef489170eaa3922f7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            self.content[key] \u003d contents"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if vd_driver is None:"},{"line_number":200,"context_line":"            driver \u003d \u0027nova.api.metadata.vendordata_json.JsonFileVendorData\u0027"},{"line_number":201,"context_line":"            vdclass \u003d importutils.import_class(driver)"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            vdclass \u003d vd_driver"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_af075582","line":201,"range":{"start_line":200,"start_character":0,"end_line":201,"end_character":54},"in_reply_to":"7f287b81_a101b23a","updated":"2017-09-28 03:43:44.000000000","message":"ok","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"}],"nova/tests/unit/test_metadata.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"c5c1c9a9866b8d81a216d084d031074b8218b23e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from nova.api.metadata import base"},{"line_number":42,"context_line":"from nova.api.metadata import handler"},{"line_number":43,"context_line":"from nova.api.metadata import password"},{"line_number":44,"context_line":"from nova.api.metadata import vendordata"},{"line_number":45,"context_line":"from nova.api.metadata import vendordata_dynamic"},{"line_number":46,"context_line":"from nova import block_device"},{"line_number":47,"context_line":"from nova.compute import flavors"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_363eb829","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":40},"updated":"2017-10-10 12:28:56.000000000","message":"PEP8","commit_id":"fdcee2631c00da8ba00219380d092bd60bd52ecf"}],"releasenotes/notes/remove_conf_vendordata_driver-b0cdeb6c503a3f0a.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84e83ad88c096c5152f2e0a5250628b9ae819850","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    conf.vendordata_driver was deprecated at 13.0.0 for removal, nova"},{"line_number":5,"context_line":"    remove the configuration option now."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_c1895eca","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":12},"updated":"2017-09-07 09:20:41.000000000","message":"Use \u0027upgrade\u0027 instead","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7bfc5fc6349203b487aa9c0ef489170eaa3922f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    conf.vendordata_driver was deprecated at 13.0.0 for removal, nova"},{"line_number":5,"context_line":"    remove the configuration option now."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_af7ab5ed","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":12},"in_reply_to":"7f287b81_c1895eca","updated":"2017-09-28 03:43:44.000000000","message":"Done","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84e83ad88c096c5152f2e0a5250628b9ae819850","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    conf.vendordata_driver was deprecated at 13.0.0 for removal, nova"},{"line_number":5,"context_line":"    remove the configuration option now."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_41644e22","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":40},"updated":"2017-09-07 09:20:41.000000000","message":"We should use rST formatting here. How about:\n\n  The ``[DEFAULT]vendordata_driver`` config option, which was\n  deprecated in nova 13.0.0, has now been removed.","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7bfc5fc6349203b487aa9c0ef489170eaa3922f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    conf.vendordata_driver was deprecated at 13.0.0 for removal, nova"},{"line_number":5,"context_line":"    remove the configuration option now."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_cf1bb1c7","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":40},"in_reply_to":"5f2577a7_becb4170","updated":"2017-09-28 03:43:44.000000000","message":"ok, will do","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"46ac29e8ec09790355b9737d1d174ac33e056713","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    conf.vendordata_driver was deprecated at 13.0.0 for removal, nova"},{"line_number":5,"context_line":"    remove the configuration option now."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f2577a7_becb4170","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":40},"in_reply_to":"7f287b81_41644e22","updated":"2017-09-13 15:43:54.000000000","message":"We should also mention the replacement and point at how to use it.","commit_id":"17572b91b97ed3324f2a74297cd4d9fcc2f14039"}]}