)]}'
{"nova/volume/cinder.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"fa9235843a9f3ee55c35f3b89c07e3525f613294","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # TODO(jamielennox): This should be using proper version discovery from"},{"line_number":119,"context_line":"    # the cinder service rather than just inspecting the URL for certain string"},{"line_number":120,"context_line":"    # values."},{"line_number":121,"context_line":"    version \u003d cinder_client.get_volume_api_from_url(url)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    if version !\u003d \u00273\u0027:"},{"line_number":124,"context_line":"        raise exception.UnsupportedCinderAPIVersion(version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_3de834b1","line":121,"range":{"start_line":121,"start_character":14,"end_line":121,"end_character":56},"updated":"2017-09-07 21:43:50.000000000","message":"Sure would like to see this using ksa discovery instead.\n\nMonty?","commit_id":"2e8afc9fa3ce4f4913acc9876eb7856a44889512"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"12ceb908ea9c0edfd721893f6a6686d59a7adf5b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # TODO(jamielennox): This should be using proper version discovery from"},{"line_number":119,"context_line":"    # the cinder service rather than just inspecting the URL for certain string"},{"line_number":120,"context_line":"    # values."},{"line_number":121,"context_line":"    version \u003d cinder_client.get_volume_api_from_url(url)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    if version !\u003d \u00273\u0027:"},{"line_number":124,"context_line":"        raise exception.UnsupportedCinderAPIVersion(version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_9e2269b8","line":121,"range":{"start_line":121,"start_character":14,"end_line":121,"end_character":56},"in_reply_to":"5f2577a7_d9f02294","updated":"2017-09-18 13:24:42.000000000","message":"Both should eventually be done through the ksa Adapter.  That said, I\u0027m not sure how much (if any) version discovery we want to do within the cinder client itself.","commit_id":"2e8afc9fa3ce4f4913acc9876eb7856a44889512"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"780a5fc14393b69157bd771c881bdcdaa4097dff","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # TODO(jamielennox): This should be using proper version discovery from"},{"line_number":119,"context_line":"    # the cinder service rather than just inspecting the URL for certain string"},{"line_number":120,"context_line":"    # values."},{"line_number":121,"context_line":"    version \u003d cinder_client.get_volume_api_from_url(url)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    if version !\u003d \u00273\u0027:"},{"line_number":124,"context_line":"        raise exception.UnsupportedCinderAPIVersion(version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_4db22096","line":121,"range":{"start_line":121,"start_character":14,"end_line":121,"end_character":56},"in_reply_to":"7f287b81_3de834b1","updated":"2017-09-08 13:12:45.000000000","message":"Sure, that\u0027s the TODO, which you can resolve in a separate patch if you want.","commit_id":"2e8afc9fa3ce4f4913acc9876eb7856a44889512"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"19b26abf138c94a37c82fa7dbfaf83c5be7d405d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # TODO(jamielennox): This should be using proper version discovery from"},{"line_number":119,"context_line":"    # the cinder service rather than just inspecting the URL for certain string"},{"line_number":120,"context_line":"    # values."},{"line_number":121,"context_line":"    version \u003d cinder_client.get_volume_api_from_url(url)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    if version !\u003d \u00273\u0027:"},{"line_number":124,"context_line":"        raise exception.UnsupportedCinderAPIVersion(version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d0d2275c","line":121,"range":{"start_line":121,"start_character":14,"end_line":121,"end_character":56},"in_reply_to":"7f287b81_4db22096","updated":"2017-09-08 13:37:51.000000000","message":"Yuh; I\u0027ve been thinking it makes the most sense to do on top of the use-ksa-adapter-for-endpoints work.","commit_id":"2e8afc9fa3ce4f4913acc9876eb7856a44889512"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fb7116137035283d0ff0751ad77a88bce0900bd7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # TODO(jamielennox): This should be using proper version discovery from"},{"line_number":119,"context_line":"    # the cinder service rather than just inspecting the URL for certain string"},{"line_number":120,"context_line":"    # values."},{"line_number":121,"context_line":"    version \u003d cinder_client.get_volume_api_from_url(url)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    if version !\u003d \u00273\u0027:"},{"line_number":124,"context_line":"        raise exception.UnsupportedCinderAPIVersion(version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_d9f02294","line":121,"range":{"start_line":121,"start_character":14,"end_line":121,"end_character":56},"in_reply_to":"7f287b81_d0d2275c","updated":"2017-09-16 13:57:59.000000000","message":"I\u0027m not sure why this should depend on that, they seem unrelated.","commit_id":"2e8afc9fa3ce4f4913acc9876eb7856a44889512"}]}