)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"404e03cf5d05ba24e2610354e7b255d268b95ee9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use Migration object in ComputeManagerMigrationTestCase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tests were using a Mock object as a Migration object, which failed to"},{"line_number":10,"context_line":"identify a mis-named field in the unit tests of a subsequent test."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I49008dc2026c0bdfb7f27fe197d34c6c57a9506e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_db0a651e","line":10,"updated":"2017-11-02 16:53:48.000000000","message":"This change looks fine but this sentence doesn\u0027t make sense to me. Where is the subsequent test with the mis-named field?","commit_id":"e6e1069e828c20658cb0791980117fd66ceeaf14"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4e3c37b9939a255301f80f30aae76cec6358fc45","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use Migration object in ComputeManagerMigrationTestCase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tests were using a Mock object as a Migration object, which failed to"},{"line_number":10,"context_line":"identify a mis-named field in the unit tests of a subsequent test."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I49008dc2026c0bdfb7f27fe197d34c6c57a9506e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_170b297d","line":10,"in_reply_to":"3f4b6375_db0a651e","updated":"2017-11-02 21:05:47.000000000","message":"As discussed on IRC, this is referring to mdbooth working on a test locally where he noticed his test passed even when he accessed non-existent attributes on a mocked Migration object.","commit_id":"e6e1069e828c20658cb0791980117fd66ceeaf14"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"421b2f5ef8de6b10d2edfb4fcd2992c711c54055","unresolved":false,"context_lines":[{"line_number":5683,"context_line":"            yield _finish_resize"},{"line_number":5684,"context_line":""},{"line_number":5685,"context_line":"    def test_finish_resize_failure(self):"},{"line_number":5686,"context_line":"        migration \u003d mock.NonCallableMagicMock()"},{"line_number":5687,"context_line":"        migration.status \u003d \u0027post-migrating\u0027"},{"line_number":5688,"context_line":""},{"line_number":5689,"context_line":"        with self._mock_finish_resize() as _finish_resize:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_db9a6560","side":"PARENT","line":5686,"range":{"start_line":5686,"start_character":25,"end_line":5686,"end_character":45},"updated":"2017-11-02 17:06:02.000000000","message":"Presumably these are NonCallable mocks for a reason - shouldn\u0027t we then be asserting something isn\u0027t getting called on them? Although that\u0027s a bit weird, usually we use non-callable mocks on method mocks, not entire objects.","commit_id":"86d9f0e8cb9b47bdb07cb389a0f262eb42a5b2d4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2a31d1b0c21681ce04b14340755fc5827c2a193d","unresolved":false,"context_lines":[{"line_number":5683,"context_line":"            yield _finish_resize"},{"line_number":5684,"context_line":""},{"line_number":5685,"context_line":"    def test_finish_resize_failure(self):"},{"line_number":5686,"context_line":"        migration \u003d mock.NonCallableMagicMock()"},{"line_number":5687,"context_line":"        migration.status \u003d \u0027post-migrating\u0027"},{"line_number":5688,"context_line":""},{"line_number":5689,"context_line":"        with self._mock_finish_resize() as _finish_resize:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_6d297888","side":"PARENT","line":5686,"range":{"start_line":5686,"start_character":25,"end_line":5686,"end_character":45},"in_reply_to":"3f4b6375_db9a6560","updated":"2017-11-02 17:26:21.000000000","message":"I dunno, NonCallable mock just means the mock itself isn\u0027t callable, like doing \"migration()\" after this would fail. It doesn\u0027t seem like that helps anything.","commit_id":"86d9f0e8cb9b47bdb07cb389a0f262eb42a5b2d4"}]}