)]}'
{"nova/objects/resource_provider.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"28e50caa9f5d75c60ad989a997aefe03470e6106","unresolved":false,"context_lines":[{"line_number":1840,"context_line":"            # Now add the allocations that were passed in."},{"line_number":1841,"context_line":"            for alloc in allocs:"},{"line_number":1842,"context_line":"                rp \u003d alloc.resource_provider"},{"line_number":1843,"context_line":"                rc_id \u003d _RC_CACHE.id_from_string(alloc.resource_class)"},{"line_number":1844,"context_line":"                ins_stmt \u003d _ALLOC_TBL.insert().values("},{"line_number":1845,"context_line":"                        resource_provider_id\u003drp.id,"},{"line_number":1846,"context_line":"                        resource_class_id\u003drc_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_622c7c99","line":1843,"range":{"start_line":1843,"start_character":24,"end_line":1843,"end_character":70},"updated":"2017-09-08 20:07:37.000000000","message":"Doesn\u0027t the ResourceClassNotFound comment belong closer to this? Where does _check_capacity_exceeded raise ResourceClassNotFound? Or is that not what the comment means?","commit_id":"e39ccd20482466aa2bcf430f75ef8cc0ae19c56d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf72181a19937abf5a3f39b21bc09c57ba79feb7","unresolved":false,"context_lines":[{"line_number":1840,"context_line":"            # Now add the allocations that were passed in."},{"line_number":1841,"context_line":"            for alloc in allocs:"},{"line_number":1842,"context_line":"                rp \u003d alloc.resource_provider"},{"line_number":1843,"context_line":"                rc_id \u003d _RC_CACHE.id_from_string(alloc.resource_class)"},{"line_number":1844,"context_line":"                ins_stmt \u003d _ALLOC_TBL.insert().values("},{"line_number":1845,"context_line":"                        resource_provider_id\u003drp.id,"},{"line_number":1846,"context_line":"                        resource_class_id\u003drc_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_82a088a7","line":1843,"in_reply_to":"5f2577a7_22743499","updated":"2017-09-08 20:20:06.000000000","message":"ah ok","commit_id":"e39ccd20482466aa2bcf430f75ef8cc0ae19c56d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f9c5f07fc3c31bef8fdbc447b68f3f2660046021","unresolved":false,"context_lines":[{"line_number":1840,"context_line":"            # Now add the allocations that were passed in."},{"line_number":1841,"context_line":"            for alloc in allocs:"},{"line_number":1842,"context_line":"                rp \u003d alloc.resource_provider"},{"line_number":1843,"context_line":"                rc_id \u003d _RC_CACHE.id_from_string(alloc.resource_class)"},{"line_number":1844,"context_line":"                ins_stmt \u003d _ALLOC_TBL.insert().values("},{"line_number":1845,"context_line":"                        resource_provider_id\u003drp.id,"},{"line_number":1846,"context_line":"                        resource_class_id\u003drc_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_22743499","line":1843,"in_reply_to":"5f2577a7_622c7c99","updated":"2017-09-08 20:09:41.000000000","message":"both do it, but check_capacity does it _first_ because it also calls id_from_string on the allocs","commit_id":"e39ccd20482466aa2bcf430f75ef8cc0ae19c56d"}]}