)]}'
{"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"79d91b19837e522f908a9fe0786f88b8f4826feb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return sorted(list(set(self._show_expected_attrs + expected_attrs)))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def show(self, request, instance, extend_address\u003dTrue,"},{"line_number":115,"context_line":"             show_extra_specs\u003dNone, show_AZ\u003dNone):"},{"line_number":116,"context_line":"        \"\"\"Detailed view of a single instance.\"\"\""},{"line_number":117,"context_line":"        ip_v4 \u003d instance.get(\u0027access_ip_v4\u0027)"},{"line_number":118,"context_line":"        ip_v6 \u003d instance.get(\u0027access_ip_v6\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6db5f431","line":115,"range":{"start_line":115,"start_character":36,"end_line":115,"end_character":48},"updated":"2018-07-02 23:17:00.000000000","message":"This show_AZ value pattern(None, True and False) seems confusable.\nDo we have True pattern in this argument?\n\nIn addition, we need corresponding unit tests for this new argument.","commit_id":"04e176b6b7487726c84792207d0fcd521514f0b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84d685147200ba033dbca7556e38c979e68b7835","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return sorted(list(set(self._show_expected_attrs + expected_attrs)))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def show(self, request, instance, extend_address\u003dTrue,"},{"line_number":115,"context_line":"             show_extra_specs\u003dNone, show_AZ\u003dNone):"},{"line_number":116,"context_line":"        \"\"\"Detailed view of a single instance.\"\"\""},{"line_number":117,"context_line":"        ip_v4 \u003d instance.get(\u0027access_ip_v4\u0027)"},{"line_number":118,"context_line":"        ip_v6 \u003d instance.get(\u0027access_ip_v6\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_70a59b47","line":115,"range":{"start_line":115,"start_character":36,"end_line":115,"end_character":48},"in_reply_to":"5f7c97a3_6db5f431","updated":"2018-07-05 06:10:49.000000000","message":"This is used to evaluate the policy also. none is where we will evaluate the policy check which is case of Detail method. Otherwise True or False is policy evaluated value to show_AZ","commit_id":"04e176b6b7487726c84792207d0fcd521514f0b4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"79d91b19837e522f908a9fe0786f88b8f4826feb","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            show_AZ \u003d context.can(eaz_policies.BASE_POLICY_NAME, fatal\u003dFalse)"},{"line_number":168,"context_line":"        if show_AZ:"},{"line_number":169,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":170,"context_line":"            server[\"server\"][\"OS-EXT-AZ:availability_zone\"] \u003d az or\u0027\u0027"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        if api_version_request.is_supported(request, min_version\u003d\"2.9\"):"},{"line_number":173,"context_line":"            server[\"server\"][\"locked\"] \u003d (True if instance[\"locked_by\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8d42d03a","line":170,"range":{"start_line":170,"start_character":65,"end_line":170,"end_character":69},"updated":"2018-07-02 23:17:00.000000000","message":"need a space between or and \u0027\u0027","commit_id":"04e176b6b7487726c84792207d0fcd521514f0b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84d685147200ba033dbca7556e38c979e68b7835","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            show_AZ \u003d context.can(eaz_policies.BASE_POLICY_NAME, fatal\u003dFalse)"},{"line_number":168,"context_line":"        if show_AZ:"},{"line_number":169,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":170,"context_line":"            server[\"server\"][\"OS-EXT-AZ:availability_zone\"] \u003d az or\u0027\u0027"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        if api_version_request.is_supported(request, min_version\u003d\"2.9\"):"},{"line_number":173,"context_line":"            server[\"server\"][\"locked\"] \u003d (True if instance[\"locked_by\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_90a2b73e","line":170,"range":{"start_line":170,"start_character":65,"end_line":170,"end_character":69},"in_reply_to":"5f7c97a3_8d42d03a","updated":"2018-07-05 06:10:49.000000000","message":"Done","commit_id":"04e176b6b7487726c84792207d0fcd521514f0b4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"79d91b19837e522f908a9fe0786f88b8f4826feb","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        :param func: Function used to format the server data"},{"line_number":214,"context_line":"        :param request: API request"},{"line_number":215,"context_line":"        :param servers: List of servers in dictionary format"},{"line_number":216,"context_line":"        :param coll_name: Name of collection, used to generate the next link"},{"line_number":217,"context_line":"                          for a pagination query"},{"line_number":218,"context_line":"        :returns: Server data in dictionary format"},{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        server_list \u003d [func(request, server,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4d84b85d","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":48},"updated":"2018-07-02 23:17:00.000000000","message":"need to add a new docstring here","commit_id":"04e176b6b7487726c84792207d0fcd521514f0b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84d685147200ba033dbca7556e38c979e68b7835","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        :param func: Function used to format the server data"},{"line_number":214,"context_line":"        :param request: API request"},{"line_number":215,"context_line":"        :param servers: List of servers in dictionary format"},{"line_number":216,"context_line":"        :param coll_name: Name of collection, used to generate the next link"},{"line_number":217,"context_line":"                          for a pagination query"},{"line_number":218,"context_line":"        :returns: Server data in dictionary format"},{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        server_list \u003d [func(request, server,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_30616312","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":48},"in_reply_to":"5f7c97a3_4d84b85d","updated":"2018-07-05 06:10:49.000000000","message":"Done","commit_id":"04e176b6b7487726c84792207d0fcd521514f0b4"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c83e925693be8211c7e573326564310633c893de","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        context \u003d request.environ[\u0027nova.context\u0027]"},{"line_number":166,"context_line":"        if show_AZ is None:"},{"line_number":167,"context_line":"            show_AZ \u003d context.can(eaz_policies.BASE_POLICY_NAME, fatal\u003dFalse)"},{"line_number":168,"context_line":"        if show_AZ:"},{"line_number":169,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":170,"context_line":"            server[\"server\"][\"OS-EXT-AZ:availability_zone\"] \u003d az or \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_873f9fb3","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":63},"updated":"2018-07-09 13:15:44.000000000","message":"Can we drop this policy now? https://github.com/openstack/nova/blob/master/nova/policies/extended_availability_zone.py#L39","commit_id":"eebc7addb6aad555d160cecd6e503b7c5175699f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a35460f5e1dc1cf6e95e668c4c3be6b5c167f1a7","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        context \u003d request.environ[\u0027nova.context\u0027]"},{"line_number":166,"context_line":"        if show_AZ is None:"},{"line_number":167,"context_line":"            show_AZ \u003d context.can(eaz_policies.BASE_POLICY_NAME, fatal\u003dFalse)"},{"line_number":168,"context_line":"        if show_AZ:"},{"line_number":169,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":170,"context_line":"            server[\"server\"][\"OS-EXT-AZ:availability_zone\"] \u003d az or \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_a60c10eb","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":63},"in_reply_to":"5f7c97a3_873f9fb3","updated":"2018-07-10 01:05:02.000000000","message":"I though of that (even removing all deprecated policy before merging the extensions code) but then i thought of doing that in Stein so that we give good amount of time (1 full cycle) to operator to modify their policy. \n\nThese were deprecated in Queens so i would like to give full Rocky cycle to operator and we then remove those policy in Stein.\n\nRemoving it now make our code easy while merging the extensions but for operator it might be little quick. \n\nWhat you say?","commit_id":"eebc7addb6aad555d160cecd6e503b7c5175699f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"817a57edf5f7cc72139a1bf4cac3d6e78ee56756","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if server[\"server\"][\"status\"] in self._progress_statuses:"},{"line_number":162,"context_line":"            server[\"server\"][\"progress\"] \u003d instance.get(\"progress\", 0)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        context \u003d request.environ[\u0027nova.context\u0027]"},{"line_number":165,"context_line":"        if show_AZ:"},{"line_number":166,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":167,"context_line":"            # NOTE(mriedem): The OS-EXT-AZ prefix should not be used for new"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_bc7bba89","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":49},"updated":"2018-08-15 22:24:12.000000000","message":"This context should be moved to line 166 where the context is used.","commit_id":"5606a35cadc9724ac422f21f9b374ea871b82d93"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f14a2145d3a2973eb9f3ab0c686d0454f2092b0f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if server[\"server\"][\"status\"] in self._progress_statuses:"},{"line_number":162,"context_line":"            server[\"server\"][\"progress\"] \u003d instance.get(\"progress\", 0)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        context \u003d request.environ[\u0027nova.context\u0027]"},{"line_number":165,"context_line":"        if show_AZ:"},{"line_number":166,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":167,"context_line":"            # NOTE(mriedem): The OS-EXT-AZ prefix should not be used for new"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_57427810","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":49},"in_reply_to":"3f79a3b5_bc7bba89","updated":"2018-08-16 08:27:40.000000000","message":"i kept this outside as this can be used for other code also. you can see in this series that other code merge use this context. now it will give error there.","commit_id":"5606a35cadc9724ac422f21f9b374ea871b82d93"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"817a57edf5f7cc72139a1bf4cac3d6e78ee56756","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        context \u003d request.environ[\u0027nova.context\u0027]"},{"line_number":165,"context_line":"        if show_AZ:"},{"line_number":166,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":167,"context_line":"            # NOTE(mriedem): The OS-EXT-AZ prefix should not be used for new"},{"line_number":168,"context_line":"            # attributes after v2.1. They are only in v2.1 for backward compat"},{"line_number":169,"context_line":"            # with v2.0."},{"line_number":170,"context_line":"            server[\"server\"][\"OS-EXT-AZ:availability_zone\"] \u003d az or \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_3c71ea76","line":167,"range":{"start_line":167,"start_character":14,"end_line":167,"end_character":18},"updated":"2018-08-15 22:24:12.000000000","message":"When reading this comment at this time, I was confused because we have already many microversion bumps but this code still works on the latest microversion. Maybe this can be TODO what we want to fix on some microversion bump instead of NOTE, I feel.\nThis is just a comment, not reason why -1.","commit_id":"5606a35cadc9724ac422f21f9b374ea871b82d93"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f14a2145d3a2973eb9f3ab0c686d0454f2092b0f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        context \u003d request.environ[\u0027nova.context\u0027]"},{"line_number":165,"context_line":"        if show_AZ:"},{"line_number":166,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":167,"context_line":"            # NOTE(mriedem): The OS-EXT-AZ prefix should not be used for new"},{"line_number":168,"context_line":"            # attributes after v2.1. They are only in v2.1 for backward compat"},{"line_number":169,"context_line":"            # with v2.0."},{"line_number":170,"context_line":"            server[\"server\"][\"OS-EXT-AZ:availability_zone\"] \u003d az or \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_b752ecdc","line":167,"range":{"start_line":167,"start_character":14,"end_line":167,"end_character":18},"in_reply_to":"3f79a3b5_3c71ea76","updated":"2018-08-16 08:27:40.000000000","message":"yeah, that is NOTE for new attributes addition which should not use OS-EXT-AZ prefix","commit_id":"5606a35cadc9724ac422f21f9b374ea871b82d93"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b5dc9bb5970c7616225e845de2370f71e018ddf1","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return sorted(list(set(self._show_expected_attrs + expected_attrs)))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def show(self, request, instance, extend_address\u003dTrue,"},{"line_number":114,"context_line":"             show_extra_specs\u003dNone, show_AZ\u003dTrue):"},{"line_number":115,"context_line":"        \"\"\"Detailed view of a single instance.\"\"\""},{"line_number":116,"context_line":"        ip_v4 \u003d instance.get(\u0027access_ip_v4\u0027)"},{"line_number":117,"context_line":"        ip_v6 \u003d instance.get(\u0027access_ip_v6\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_f606d820","line":114,"range":{"start_line":114,"start_character":41,"end_line":114,"end_character":43},"updated":"2018-08-20 17:08:40.000000000","message":"nit: wouldn\u0027t used lower-case but it\u0027s OK","commit_id":"f7bc040a923ebd1bf9bcbcf89b8ae6edf13c3c07"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b5dc9bb5970c7616225e845de2370f71e018ddf1","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if server[\"server\"][\"status\"] in self._progress_statuses:"},{"line_number":162,"context_line":"            server[\"server\"][\"progress\"] \u003d instance.get(\"progress\", 0)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if show_AZ:"},{"line_number":165,"context_line":"            context \u003d request.environ[\u0027nova.context\u0027]"},{"line_number":166,"context_line":"            az \u003d avail_zone.get_instance_availability_zone(context, instance)"},{"line_number":167,"context_line":"            # NOTE(mriedem): The OS-EXT-AZ prefix should not be used for new"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_d12ac67c","line":164,"updated":"2018-08-20 17:08:40.000000000","message":"At some point we should add a microversion (after this series is done, and maybe part of a cleanup series) where we can remove these conditionals for server update and rebuild so the response is the same as for show and detailed list. In that same microversion we could drop the old OS-EXT-AZ prefix.","commit_id":"f7bc040a923ebd1bf9bcbcf89b8ae6edf13c3c07"}]}