)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1993c5a16c2455de7f0f477bc8b66d945b407a5c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"information without \u0027objects\u0027 by default. The information like"},{"line_number":12,"context_line":"{u\u0027migrations\u0027: []} is returned to the client."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug #1236821"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iefbdf742d494e94bafc7f89a6af589a88ca28906"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATH%2F%2F1ZI%3D","line":14,"updated":"2013-10-09 07:48:47.000000000","message":"Could you use \"Closes-Bug: #XXXX\" instead of \"Fixes bug:\"?","commit_id":"69349c0ad849cd73a2535a92a2a95f152648c11b"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"211d6c2fb886766ea73f66e2a02bf524db7e1875","unresolved":false,"context_lines":[{"line_number":11,"context_line":"information without \u0027objects\u0027 by default. The information like"},{"line_number":12,"context_line":"{u\u0027migrations\u0027: []} is returned to the client."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug #1236821"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iefbdf742d494e94bafc7f89a6af589a88ca28906"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATH%2F%2F0%2Fc%3D","line":14,"in_reply_to":"AAAATH%2F%2F1ZI%3D","updated":"2013-10-09 10:06:29.000000000","message":"I will fix it. Thank you.","commit_id":"69349c0ad849cd73a2535a92a2a95f152648c11b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"27c1e6848c392ddf62992394a9ac28355f8c1b8e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{u\u0027migrations\u0027:{u\u0027objects\u0027:[]}}"},{"line_number":12,"context_line":"The client doesn\u0027t expect information of objects but primitive."},{"line_number":13,"context_line":"{u\u0027migrations\u0027:[]}"},{"line_number":14,"context_line":"This patch fixes this bug in V2 and V3 API."},{"line_number":15,"context_line":"The original testcase can\u0027t detect this bug, but after I fixed it,"},{"line_number":16,"context_line":"I found the API response\u0027s timestamp isn\u0027t in accordance with the"},{"line_number":17,"context_line":"sample file. This patch also fixes the sample file to make the test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATn%2F%2B30s%3D","line":14,"updated":"2013-11-19 05:25:12.000000000","message":"Please add a blank line for making the different changes clear.","commit_id":"d1d00881980961fd5e8c9d23623f7cc6a4da165d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"27c1e6848c392ddf62992394a9ac28355f8c1b8e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The client doesn\u0027t expect information of objects but primitive."},{"line_number":13,"context_line":"{u\u0027migrations\u0027:[]}"},{"line_number":14,"context_line":"This patch fixes this bug in V2 and V3 API."},{"line_number":15,"context_line":"The original testcase can\u0027t detect this bug, but after I fixed it,"},{"line_number":16,"context_line":"I found the API response\u0027s timestamp isn\u0027t in accordance with the"},{"line_number":17,"context_line":"sample file. This patch also fixes the sample file to make the test"},{"line_number":18,"context_line":"pass."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATn%2F%2B30c%3D","line":15,"updated":"2013-11-19 05:25:12.000000000","message":"Could you add the reason why current testcase cannot find this bug?","commit_id":"d1d00881980961fd5e8c9d23623f7cc6a4da165d"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"df964d94815f336ac9140fe5fb07675e33136101","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The client doesn\u0027t expect information of objects but primitive."},{"line_number":13,"context_line":"{u\u0027migrations\u0027:[]}"},{"line_number":14,"context_line":"This patch fixes this bug in V2 and V3 API."},{"line_number":15,"context_line":"The original testcase can\u0027t detect this bug, but after I fixed it,"},{"line_number":16,"context_line":"I found the API response\u0027s timestamp isn\u0027t in accordance with the"},{"line_number":17,"context_line":"sample file. This patch also fixes the sample file to make the test"},{"line_number":18,"context_line":"pass."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATn%2F%2B3lU%3D","line":15,"in_reply_to":"AAAATn%2F%2B30c%3D","updated":"2013-11-19 07:45:44.000000000","message":"Ken\u0027ichi Ohmichi\n\nThank you. I will modify the commit message to make it clearer.","commit_id":"d1d00881980961fd5e8c9d23623f7cc6a4da165d"}],"nova/api/openstack/compute/contrib/migrations.py":[{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"0acf9f807c4657c4f6d52e2140ca204aa40e4eea","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":60,"context_line":"        authorize(context, \"index\")"},{"line_number":61,"context_line":"        migrations \u003d self.compute_api.get_migrations(context, req.GET,"},{"line_number":62,"context_line":"                                                     want_objects\u003dFalse)"},{"line_number":63,"context_line":"        return {\u0027migrations\u0027: migrations}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FxJA%3D","line":62,"updated":"2013-10-10 04:41:51.000000000","message":"What do you do to V3 API ?","commit_id":"ab960172439b53a28d4ee33484ee2bda92d292bf"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"48edfc94f1c894030be0ae45e63a7a2e3204c9f9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":60,"context_line":"        authorize(context, \"index\")"},{"line_number":61,"context_line":"        migrations \u003d self.compute_api.get_migrations(context, req.GET,"},{"line_number":62,"context_line":"                                                     want_objects\u003dFalse)"},{"line_number":63,"context_line":"        return {\u0027migrations\u0027: migrations}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FxAo%3D","line":62,"in_reply_to":"AAAATH%2F%2FxJA%3D","updated":"2013-10-10 05:58:08.000000000","message":"This is the common method of V2 and V3","commit_id":"ab960172439b53a28d4ee33484ee2bda92d292bf"}],"nova/api/openstack/compute/plugins/v3/migrations.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"524306c57362ad49a5f17896b13fb0433c3963b8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":61,"context_line":"        authorize(context, \"index\")"},{"line_number":62,"context_line":"        migrations \u003d self.compute_api.get_migrations(context, req.GET,"},{"line_number":63,"context_line":"                                                     want_objects\u003dFalse)"},{"line_number":64,"context_line":"        return {\u0027migrations\u0027: migrations}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FX08%3D","line":63,"updated":"2013-10-17 02:20:41.000000000","message":"You should convert objects to primitives here.  The compute API should always return objects.","commit_id":"063c3a80f0419cfc7bf6ca80dd51da5dbdd29726"}],"nova/compute/api.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1993c5a16c2455de7f0f477bc8b66d945b407a5c","unresolved":false,"context_lines":[{"line_number":2940,"context_line":"        list_migration \u003d migration_obj.MigrationList.get_by_filters(context,"},{"line_number":2941,"context_line":"                                                                    filters)"},{"line_number":2942,"context_line":"        if not want_objects:"},{"line_number":2943,"context_line":"            return obj_base.obj_to_primitive(list_migration)"},{"line_number":2944,"context_line":"        else:"},{"line_number":2945,"context_line":"            return list_migration"},{"line_number":2946,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F1Yc%3D","line":2943,"updated":"2013-10-09 07:48:47.000000000","message":"Why should we add the argument \"want_objects\"?\nThis patch does not change the callers of get_migrations().","commit_id":"69349c0ad849cd73a2535a92a2a95f152648c11b"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"211d6c2fb886766ea73f66e2a02bf524db7e1875","unresolved":false,"context_lines":[{"line_number":2940,"context_line":"        list_migration \u003d migration_obj.MigrationList.get_by_filters(context,"},{"line_number":2941,"context_line":"                                                                    filters)"},{"line_number":2942,"context_line":"        if not want_objects:"},{"line_number":2943,"context_line":"            return obj_base.obj_to_primitive(list_migration)"},{"line_number":2944,"context_line":"        else:"},{"line_number":2945,"context_line":"            return list_migration"},{"line_number":2946,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F098%3D","line":2943,"in_reply_to":"AAAATH%2F%2F1Yc%3D","updated":"2013-10-09 10:06:29.000000000","message":"Thank you . I will set the want_objects argument to \u0027True\u0027 by default and the caller who doesn\u0027t want objects can set it to False.","commit_id":"69349c0ad849cd73a2535a92a2a95f152648c11b"},{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"0acf9f807c4657c4f6d52e2140ca204aa40e4eea","unresolved":false,"context_lines":[{"line_number":2935,"context_line":"                                        on_shared_storage\u003don_shared_storage,"},{"line_number":2936,"context_line":"                                        host\u003dhost)"},{"line_number":2937,"context_line":""},{"line_number":2938,"context_line":"    def get_migrations(self, context, filters, want_objects\u003dTrue):"},{"line_number":2939,"context_line":"        \"\"\"Get all migrations for the given filters.\"\"\""},{"line_number":2940,"context_line":"        list_migration \u003d migration_obj.MigrationList.get_by_filters(context,"},{"line_number":2941,"context_line":"                                                                    filters)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FxHs%3D","line":2938,"updated":"2013-10-10 04:41:51.000000000","message":"Do you think the cells? Such as nova/cells/messaging.py and nova/cells/messaging.py","commit_id":"ab960172439b53a28d4ee33484ee2bda92d292bf"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"48edfc94f1c894030be0ae45e63a7a2e3204c9f9","unresolved":false,"context_lines":[{"line_number":2935,"context_line":"                                        on_shared_storage\u003don_shared_storage,"},{"line_number":2936,"context_line":"                                        host\u003dhost)"},{"line_number":2937,"context_line":""},{"line_number":2938,"context_line":"    def get_migrations(self, context, filters, want_objects\u003dTrue):"},{"line_number":2939,"context_line":"        \"\"\"Get all migrations for the given filters.\"\"\""},{"line_number":2940,"context_line":"        list_migration \u003d migration_obj.MigrationList.get_by_filters(context,"},{"line_number":2941,"context_line":"                                                                    filters)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FxB4%3D","line":2938,"in_reply_to":"AAAATH%2F%2FxHs%3D","updated":"2013-10-10 05:58:08.000000000","message":"Thank you for your comment. I think this patch has no effect on cells.","commit_id":"ab960172439b53a28d4ee33484ee2bda92d292bf"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"9b3fc32991d0de0543009d6f644553b04a0f8174","unresolved":false,"context_lines":[{"line_number":2947,"context_line":"                                        on_shared_storage\u003don_shared_storage,"},{"line_number":2948,"context_line":"                                        host\u003dhost)"},{"line_number":2949,"context_line":""},{"line_number":2950,"context_line":"    def get_migrations(self, context, filters, want_objects\u003dTrue):"},{"line_number":2951,"context_line":"        \"\"\"Get all migrations for the given filters.\"\"\""},{"line_number":2952,"context_line":"        list_migration \u003d migration_obj.MigrationList.get_by_filters(context,"},{"line_number":2953,"context_line":"\t                                                            filters)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FX0g%3D","line":2950,"updated":"2013-10-17 02:24:14.000000000","message":"Please do not change this to optionally return objects.  When returning data from the API, form your API response from the object(s).","commit_id":"063c3a80f0419cfc7bf6ca80dd51da5dbdd29726"}],"nova/tests/api/openstack/compute/contrib/test_migrations.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"87b7809e2173668114e2ca6a50ea83a9d1f5ff1a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def test_index_serialization(self):"},{"line_number":113,"context_line":"        for migration in fake_migrations:"},{"line_number":114,"context_line":"            del migration[\u0027deleted_at\u0027]"},{"line_number":115,"context_line":"            del migration[\u0027deleted\u0027]"},{"line_number":116,"context_line":"        res_xml \u003d self.serializer.serialize({\u0027migrations\u0027: fake_migrations})"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        tree \u003d etree.XML(res_xml)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2BfWw%3D","line":115,"updated":"2013-11-25 15:17:02.000000000","message":"This alters the global migrations used for other things. Please copy them before you delete things from them.","commit_id":"93d6f3829394109d37de8614ec0f74d3b8c67f9a"}],"nova/tests/api/openstack/compute/plugins/v3/test_migrations.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"87b7809e2173668114e2ca6a50ea83a9d1f5ff1a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def test_index_serialization(self):"},{"line_number":114,"context_line":"        for migration in fake_migrations:"},{"line_number":115,"context_line":"            del migration[\u0027deleted_at\u0027]"},{"line_number":116,"context_line":"            del migration[\u0027deleted\u0027]"},{"line_number":117,"context_line":"        res_xml \u003d self.serializer.serialize({\u0027migrations\u0027: fake_migrations})"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        tree \u003d etree.XML(res_xml)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2BfVk%3D","line":116,"updated":"2013-11-25 15:17:02.000000000","message":"Same.","commit_id":"93d6f3829394109d37de8614ec0f74d3b8c67f9a"}]}