)]}'
{"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"3c31738b88aba80751d798110591cb1bec26751a","unresolved":false,"context_lines":[{"line_number":1597,"context_line":"        if self.agent_enabled(instance):"},{"line_number":1598,"context_line":"            vm_ref \u003d self._get_vm_opaque_ref(instance)"},{"line_number":1599,"context_line":"            agent \u003d self._get_agent(instance, vm_ref)"},{"line_number":1600,"context_line":"            self._inject_hostname(instance, vm_ref, False)"},{"line_number":1601,"context_line":"            agent.resetnetwork()"},{"line_number":1602,"context_line":"            self._remove_hostname(instance, vm_ref)"},{"line_number":1603,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F4OA%3D","line":1600,"updated":"2013-10-08 15:31:50.000000000","message":"I\u0027d think we would be calling reset_network() from a \u0027rescue\u0027 path as well.  Don\u0027t we need to add rescue arg to \u0027reset_network\u0027 and pass it through?","commit_id":"331e4d2c60f221a8dfd199959abaa3ff35e0162a"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"1a3f9ec54079e1364043c4ba0aeaa58d20d0a78d","unresolved":false,"context_lines":[{"line_number":1597,"context_line":"        if self.agent_enabled(instance):"},{"line_number":1598,"context_line":"            vm_ref \u003d self._get_vm_opaque_ref(instance)"},{"line_number":1599,"context_line":"            agent \u003d self._get_agent(instance, vm_ref)"},{"line_number":1600,"context_line":"            self._inject_hostname(instance, vm_ref, False)"},{"line_number":1601,"context_line":"            agent.resetnetwork()"},{"line_number":1602,"context_line":"            self._remove_hostname(instance, vm_ref)"},{"line_number":1603,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F3e0%3D","line":1600,"in_reply_to":"AAAATH%2F%2F4OA%3D","updated":"2013-10-08 18:43:34.000000000","message":"When I checked this, the rescue path didn\u0027t call reset_network.  That being said the comment is spot on.  I\u0027ll add it as an arg and fix this up.","commit_id":"331e4d2c60f221a8dfd199959abaa3ff35e0162a"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"3c31738b88aba80751d798110591cb1bec26751a","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"            # NOTE(jk0): Windows hostnames can only be \u003c\u003d 15 chars."},{"line_number":1614,"context_line":"            hostname \u003d hostname[:15]"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"        LOG.debug(_(\"Injecting hostname to xenstore %s\") % hostname,"},{"line_number":1617,"context_line":"                  instance\u003dinstance)"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"        @utils.synchronized(\u0027xenstore-\u0027 + instance[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F4Ow%3D","line":1616,"updated":"2013-10-08 15:31:50.000000000","message":"This will read kinda funny in the logs.  Maybe put a colon after \u0027xenstore\u0027 or maybe:  \"Injecting hostname (%s) to xenstore\".  (And \u0027to\u0027 probably should have been \u0027into\u0027 in the first place, hehe, but that\u0027s not your doing.)","commit_id":"331e4d2c60f221a8dfd199959abaa3ff35e0162a"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"1a3f9ec54079e1364043c4ba0aeaa58d20d0a78d","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"            # NOTE(jk0): Windows hostnames can only be \u003c\u003d 15 chars."},{"line_number":1614,"context_line":"            hostname \u003d hostname[:15]"},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"        LOG.debug(_(\"Injecting hostname to xenstore %s\") % hostname,"},{"line_number":1617,"context_line":"                  instance\u003dinstance)"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"        @utils.synchronized(\u0027xenstore-\u0027 + instance[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F3es%3D","line":1616,"in_reply_to":"AAAATH%2F%2F4Ow%3D","updated":"2013-10-08 18:43:34.000000000","message":"Will clean this one up as well.","commit_id":"331e4d2c60f221a8dfd199959abaa3ff35e0162a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8368ad08929b412283ff8de1b1056a770211ed03","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        def inject_instance_data_step(undo_mgr, vm_ref, vdis):"},{"line_number":444,"context_line":"            self._inject_instance_metadata(instance, vm_ref)"},{"line_number":445,"context_line":"            self._inject_auto_disk_config(instance, vm_ref)"},{"line_number":446,"context_line":"            if first_boot:"},{"line_number":447,"context_line":"                self._inject_hostname(instance, vm_ref, rescue)"},{"line_number":448,"context_line":"            self._file_inject_vm_settings(instance, vm_ref, vdis, network_info)"},{"line_number":449,"context_line":"            self.inject_network_info(instance, network_info, vm_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FwGY%3D","line":446,"updated":"2013-10-10 10:51:42.000000000","message":"Its probably worth a note saying this is only here so the windows PV tools pick it up and rename windows servers.","commit_id":"1a3b4fcaa687b0bb5a3b84bfe275c4fa5b6a0874"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"72a86ddd196b107a73344e9ef78a4bab7fda9595","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        def inject_instance_data_step(undo_mgr, vm_ref, vdis):"},{"line_number":444,"context_line":"            self._inject_instance_metadata(instance, vm_ref)"},{"line_number":445,"context_line":"            self._inject_auto_disk_config(instance, vm_ref)"},{"line_number":446,"context_line":"            if first_boot:"},{"line_number":447,"context_line":"                self._inject_hostname(instance, vm_ref, rescue)"},{"line_number":448,"context_line":"            self._file_inject_vm_settings(instance, vm_ref, vdis, network_info)"},{"line_number":449,"context_line":"            self.inject_network_info(instance, network_info, vm_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuQ8%3D","line":446,"in_reply_to":"AAAATH%2F%2FwGY%3D","updated":"2013-10-10 17:21:40.000000000","message":"Will do.","commit_id":"1a3b4fcaa687b0bb5a3b84bfe275c4fa5b6a0874"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8368ad08929b412283ff8de1b1056a770211ed03","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        def configure_booted_instance_step(undo_mgr, vm_ref):"},{"line_number":464,"context_line":"            if first_boot:"},{"line_number":465,"context_line":"                self._configure_new_instance_with_agent(instance, vm_ref,"},{"line_number":466,"context_line":"                        injected_files, admin_password)"},{"line_number":467,"context_line":"                self._remove_hostname(instance, vm_ref)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        @step"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FwGA%3D","line":466,"updated":"2013-10-10 10:51:42.000000000","message":"I am thinking if we can tidy this up too, probably not, but maybe.","commit_id":"1a3b4fcaa687b0bb5a3b84bfe275c4fa5b6a0874"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"72a86ddd196b107a73344e9ef78a4bab7fda9595","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        def configure_booted_instance_step(undo_mgr, vm_ref):"},{"line_number":464,"context_line":"            if first_boot:"},{"line_number":465,"context_line":"                self._configure_new_instance_with_agent(instance, vm_ref,"},{"line_number":466,"context_line":"                        injected_files, admin_password)"},{"line_number":467,"context_line":"                self._remove_hostname(instance, vm_ref)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        @step"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuQo%3D","line":466,"in_reply_to":"AAAATH%2F%2FwGA%3D","updated":"2013-10-10 17:21:40.000000000","message":"Hmmmm... how do we want this tidied up?","commit_id":"1a3b4fcaa687b0bb5a3b84bfe275c4fa5b6a0874"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8368ad08929b412283ff8de1b1056a770211ed03","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            if admin_password and not no_agent:"},{"line_number":677,"context_line":"                agent.set_admin_password(admin_password)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"            # Reset network config"},{"line_number":680,"context_line":"            agent.resetnetwork()"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def _prepare_instance_filter(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FwGs%3D","line":679,"updated":"2013-10-10 10:51:42.000000000","message":"Can we share code with this use?","commit_id":"1a3b4fcaa687b0bb5a3b84bfe275c4fa5b6a0874"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"72a86ddd196b107a73344e9ef78a4bab7fda9595","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            if admin_password and not no_agent:"},{"line_number":677,"context_line":"                agent.set_admin_password(admin_password)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"            # Reset network config"},{"line_number":680,"context_line":"            agent.resetnetwork()"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def _prepare_instance_filter(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuQU%3D","line":679,"in_reply_to":"AAAATH%2F%2FwGs%3D","updated":"2013-10-10 17:21:40.000000000","message":"I was tempted as to change this to the higher level call (reset_network).  Is that what you think?","commit_id":"1a3b4fcaa687b0bb5a3b84bfe275c4fa5b6a0874"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8368ad08929b412283ff8de1b1056a770211ed03","unresolved":false,"context_lines":[{"line_number":1597,"context_line":"        if self.agent_enabled(instance):"},{"line_number":1598,"context_line":"            vm_ref \u003d self._get_vm_opaque_ref(instance)"},{"line_number":1599,"context_line":"            agent \u003d self._get_agent(instance, vm_ref)"},{"line_number":1600,"context_line":"            self._inject_hostname(instance, vm_ref, rescue)"},{"line_number":1601,"context_line":"            agent.resetnetwork()"},{"line_number":1602,"context_line":"            self._remove_hostname(instance, vm_ref)"},{"line_number":1603,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FwF8%3D","line":1600,"updated":"2013-10-10 10:51:42.000000000","message":"Can we have a unit test for this please?","commit_id":"1a3b4fcaa687b0bb5a3b84bfe275c4fa5b6a0874"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"72a86ddd196b107a73344e9ef78a4bab7fda9595","unresolved":false,"context_lines":[{"line_number":1597,"context_line":"        if self.agent_enabled(instance):"},{"line_number":1598,"context_line":"            vm_ref \u003d self._get_vm_opaque_ref(instance)"},{"line_number":1599,"context_line":"            agent \u003d self._get_agent(instance, vm_ref)"},{"line_number":1600,"context_line":"            self._inject_hostname(instance, vm_ref, rescue)"},{"line_number":1601,"context_line":"            agent.resetnetwork()"},{"line_number":1602,"context_line":"            self._remove_hostname(instance, vm_ref)"},{"line_number":1603,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuRA%3D","line":1600,"in_reply_to":"AAAATH%2F%2FwF8%3D","updated":"2013-10-10 17:21:40.000000000","message":"Do you want a test for reset_network or inject_hostname?   Inject hostname already has a unit test around it in test_vmops.","commit_id":"1a3b4fcaa687b0bb5a3b84bfe275c4fa5b6a0874"}]}