)]}'
{"nova/api/openstack/compute/contrib/floating_ips.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"9918eca51b4a278a5f95c07e408523dbbe350017","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        authorize(context)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if not self._is_digit(id):"},{"line_number":135,"context_line":"            LOG.exception(\"Invalid id %s should be numeric\" % id)"},{"line_number":136,"context_line":"            raise exception.InvalidID(id\u003did)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F0fo%3D","line":135,"updated":"2013-10-09 12:29:42.000000000","message":"I don\u0027t think we should log an exception for this since this is an incoming API parameter. Just raising the exception below should be sufficient.","commit_id":"ae3ca695d4080210ba6578f2ffc154b372dbccf4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"a98676119308d71ba9df741483f5c36f500cdb4f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        authorize(context)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if not self._is_digit(id):"},{"line_number":135,"context_line":"            LOG.exception(\"Invalid id %s should be numeric\" % id)"},{"line_number":136,"context_line":"            raise exception.InvalidID(id\u003did)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F0SU%3D","line":135,"in_reply_to":"AAAATH%2F%2F0fo%3D","updated":"2013-10-09 13:23:55.000000000","message":"Seems logging the exception is also OK, but we may need to support I18N.","commit_id":"ae3ca695d4080210ba6578f2ffc154b372dbccf4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"a98676119308d71ba9df741483f5c36f500cdb4f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        authorize(context)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        if not self._is_digit(id):"},{"line_number":186,"context_line":"            LOG.exception(\"Invalid id %s should be numeric\" % id)"},{"line_number":187,"context_line":"            raise exception.InvalidID(id\u003did)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        # get the floating ip object"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F0Wk%3D","line":186,"updated":"2013-10-09 13:23:55.000000000","message":"Should support I18N","commit_id":"ae3ca695d4080210ba6578f2ffc154b372dbccf4"}]}