)]}'
{"nova/tests/functional/regressions/test_bug_1713783.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5788109c187f6dab374e30a3c0174acf4aa49527","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(FailedEvacuateStateTests, self).setUp()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # NOTE(elod.illes): in pike and newer releases the DiskFilter is not"},{"line_number":49,"context_line":"        # part of the default filters, but in ocata it\u0027s still there, so the"},{"line_number":50,"context_line":"        # easiest way is to mock it here"},{"line_number":51,"context_line":"        disk_filter_patcher \u003d mock.patch("},{"line_number":52,"context_line":"            \u0027nova.scheduler.filters.disk_filter.DiskFilter.host_passes\u0027)"},{"line_number":53,"context_line":"        self.addCleanup(disk_filter_patcher.stop)"},{"line_number":54,"context_line":"        mock_disk_filter \u003d disk_filter_patcher.start()"},{"line_number":55,"context_line":"        mock_disk_filter.return_value \u003d True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.useFixture(policy_fixture.RealPolicyFixture())"},{"line_number":58,"context_line":"        self.useFixture(nova_fixtures.NeutronFixture(self))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_1ca95a7a","line":55,"range":{"start_line":48,"start_character":8,"end_line":55,"end_character":44},"updated":"2018-04-16 19:52:11.000000000","message":"There is a cleaner way we\u0027ve done this in backports for functional tests, e.g.:\n\nhttps://review.openstack.org/#/c/560162/1/nova/tests/functional/regressions/test_bug_1718512.py@85\n\nSo let\u0027s do that instead of rely on mock.\n\nThis should probably also be mentioned in the commit message.","commit_id":"e4bf5b99d3fa4ffa4ffa906cb95f35c130f747e9"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0e8894bd010ef48c26f04d5fda5ffd848a9663b8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(FailedEvacuateStateTests, self).setUp()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # NOTE(elod.illes): in pike and newer releases the DiskFilter is not"},{"line_number":49,"context_line":"        # part of the default filters, but in ocata it\u0027s still there, so the"},{"line_number":50,"context_line":"        # easiest way is to mock it here"},{"line_number":51,"context_line":"        disk_filter_patcher \u003d mock.patch("},{"line_number":52,"context_line":"            \u0027nova.scheduler.filters.disk_filter.DiskFilter.host_passes\u0027)"},{"line_number":53,"context_line":"        self.addCleanup(disk_filter_patcher.stop)"},{"line_number":54,"context_line":"        mock_disk_filter \u003d disk_filter_patcher.start()"},{"line_number":55,"context_line":"        mock_disk_filter.return_value \u003d True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.useFixture(policy_fixture.RealPolicyFixture())"},{"line_number":58,"context_line":"        self.useFixture(nova_fixtures.NeutronFixture(self))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_6b40c036","line":55,"range":{"start_line":48,"start_character":8,"end_line":55,"end_character":44},"in_reply_to":"9f6a8fd7_1ca95a7a","updated":"2018-04-17 09:58:21.000000000","message":"Yes, that is much nicer. Thanks! Done, both comment.","commit_id":"e4bf5b99d3fa4ffa4ffa906cb95f35c130f747e9"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"6ff7d04f13a19283f5395e0892480387dc588ab9","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self._wait_for_notification_event_type(\u0027compute_task.rebuild_server\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        server \u003d self._wait_for_state_change(self.api, server, \u0027ERROR\u0027)"},{"line_number":122,"context_line":"        self.assertEqual(self.hostname, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Check migrations"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_353659e8","line":121,"range":{"start_line":121,"start_character":64,"end_line":121,"end_character":69},"updated":"2018-03-28 14:13:34.000000000","message":"Meanwhile due to bugfix of #1744325 the state of the server will be ERROR and not ACTIVE anymore in this case","commit_id":"e4bf5b99d3fa4ffa4ffa906cb95f35c130f747e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5788109c187f6dab374e30a3c0174acf4aa49527","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self._wait_for_notification_event_type(\u0027compute_task.rebuild_server\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        server \u003d self._wait_for_state_change(self.api, server, \u0027ERROR\u0027)"},{"line_number":122,"context_line":"        self.assertEqual(self.hostname, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Check migrations"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_7cb176e1","line":121,"range":{"start_line":121,"start_character":64,"end_line":121,"end_character":69},"in_reply_to":"bf659307_353659e8","updated":"2018-04-16 19:52:11.000000000","message":"Mention this in the commit message.","commit_id":"e4bf5b99d3fa4ffa4ffa906cb95f35c130f747e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d1a70fe855ef2ce9a2f238da9c8366a795589305","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Force source compute down"},{"line_number":106,"context_line":"        self.api.forced_down_service(host\u003dself.hostname, binary\u003d\u0027nova-compute\u0027)"},{"line_number":107,"context_line":"        self.compute1.stop()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        fake_notifier.stub_notifier(self)"},{"line_number":110,"context_line":"        fake_notifier.reset()"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f6a8fd7_34d3003b","line":107,"updated":"2018-04-17 14:46:20.000000000","message":"The test on pike didn\u0027t stop the service explicitly. It doesn\u0027t hurt, but it\u0027s a difference.","commit_id":"590fd6d2f8497af83307025c8cb796fb433ae80b"}]}