)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f88d20ce7ed5a4a930840845ef2165ffc00199ea","unresolved":false,"context_lines":[{"line_number":21,"context_line":"the REST response [7]. This way the exception never propagates back to"},{"line_number":22,"context_line":"the FaultWrapper and therefore the api.fault notification is never emitted."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Based on the git history of the expected_errors decorator this notification"},{"line_number":25,"context_line":"was never emitted for v2.1 API and as the v2.0 API now supported with the"},{"line_number":26,"context_line":"same codebase than v2.1 it is not emitted for v2.0 calls either. As nobody"},{"line_number":27,"context_line":"reported a bug I assume that nobody tried to use this notification for a very"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_a93f8723","line":24,"updated":"2017-09-26 17:10:52.000000000","message":"It was introduced in 2012 by rackspace:\n\nhttps://review.openstack.org/#/c/13288/\n\nLong before the 2.1 restructuring of the wsgi stack.\n\nI\u0027m not even sure if rackspace ever got to the point of using the 2.1 code, so maybe they never saw this in production.","commit_id":"47f63615517ba5b401e860745d8aea4ebc37513e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f88d20ce7ed5a4a930840845ef2165ffc00199ea","unresolved":false,"context_lines":[{"line_number":36,"context_line":"[5] https://github.com/openstack/nova/blob/0aeaa2bce8ad15bc2f28e00b30d688514b992e13/nova/api/openstack/extensions.py#L325"},{"line_number":37,"context_line":"[7] https://github.com/openstack/nova/blob/0aeaa2bce8ad15bc2f28e00b30d688514b992e13/nova/api/openstack/wsgi.py#L637"},{"line_number":38,"context_line":"[8] https://github.com/openstack/nova/blob/0aeaa2bce8ad15bc2f28e00b30d688514b992e13/nova/api/openstack/wsgi.py#L418"},{"line_number":39,"context_line":"[9] http://lists.openstack.org/pipermail/openstack-dev/2017-June/118639.html"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Change-Id: I608b6ebdc69d31eb2a11ac6479fa4f2e8c20f7d1"},{"line_number":42,"context_line":"Closes-Bug: #1699115"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_69498fce","line":39,"updated":"2017-09-26 17:10:52.000000000","message":"I\u0027ll reply to this and agree we should just remove it.","commit_id":"47f63615517ba5b401e860745d8aea4ebc37513e"}],"nova/conf/notifications.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f88d20ce7ed5a4a930840845ef2165ffc00199ea","unresolved":false,"context_lines":[{"line_number":45,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.BoolOpt("},{"line_number":49,"context_line":"        \u0027notify_on_api_faults\u0027,"},{"line_number":50,"context_line":"        default\u003dFalse,"},{"line_number":51,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_e9b21fe6","side":"PARENT","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":15},"updated":"2017-09-26 17:10:52.000000000","message":"Removing this outright seems bad, but then again if it hasn\u0027t been working since Kilo (when we added 2.1 and microversions), and no one has complained, it\u0027s probably not worth deprecating.","commit_id":"224e216139f09dedcf96c5bb6f2b084ca01cc879"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f88d20ce7ed5a4a930840845ef2165ffc00199ea","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.BoolOpt("},{"line_number":49,"context_line":"        \u0027notify_on_api_faults\u0027,"},{"line_number":50,"context_line":"        default\u003dFalse,"},{"line_number":51,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":52,"context_line":"        deprecated_name\u003d\u0027notify_api_faults\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_a9a3079e","side":"PARENT","line":49,"range":{"start_line":49,"start_character":9,"end_line":49,"end_character":29},"updated":"2017-09-26 17:10:52.000000000","message":"This is also mentioned in the notifications doc, so you\u0027d have to remove it there also.","commit_id":"224e216139f09dedcf96c5bb6f2b084ca01cc879"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e7f4bcfed20b8827276a56ecd311cfeb247dcea3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\"\"\"),"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    cfg.BoolOpt("},{"line_number":49,"context_line":"        \u0027notify_on_api_faults\u0027,"},{"line_number":50,"context_line":"        default\u003dFalse,"},{"line_number":51,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":52,"context_line":"        deprecated_name\u003d\u0027notify_api_faults\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_a0754366","side":"PARENT","line":49,"range":{"start_line":49,"start_character":9,"end_line":49,"end_character":29},"in_reply_to":"7f515b1d_a9a3079e","updated":"2017-09-27 08:52:05.000000000","message":"Good catch. Done.","commit_id":"224e216139f09dedcf96c5bb6f2b084ca01cc879"}],"releasenotes/notes/api.fault-notification-removal-9f3142ba7cb13ca9.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f88d20ce7ed5a4a930840845ef2165ffc00199ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As described in `bug 1699115`_ The api.fault notification and the related"},{"line_number":5,"context_line":"    notify_on_api_faults config option have never worked for the v2.1 API."},{"line_number":6,"context_line":"    The v2.0 API is supported with the v2.1 code base since Newton so this"},{"line_number":7,"context_line":"    notification has not been emitted by the v2.0 API either since Newton."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_89cccb61","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":38},"updated":"2017-09-26 17:10:52.000000000","message":"the","commit_id":"47f63615517ba5b401e860745d8aea4ebc37513e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e7f4bcfed20b8827276a56ecd311cfeb247dcea3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As described in `bug 1699115`_ The api.fault notification and the related"},{"line_number":5,"context_line":"    notify_on_api_faults config option have never worked for the v2.1 API."},{"line_number":6,"context_line":"    The v2.0 API is supported with the v2.1 code base since Newton so this"},{"line_number":7,"context_line":"    notification has not been emitted by the v2.0 API either since Newton."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_e0257b5d","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":38},"in_reply_to":"7f515b1d_89cccb61","updated":"2017-09-27 08:52:05.000000000","message":"Done","commit_id":"47f63615517ba5b401e860745d8aea4ebc37513e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f88d20ce7ed5a4a930840845ef2165ffc00199ea","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    notify_on_api_faults config option have never worked for the v2.1 API."},{"line_number":6,"context_line":"    The v2.0 API is supported with the v2.1 code base since Newton so this"},{"line_number":7,"context_line":"    notification has not been emitted by the v2.0 API either since Newton."},{"line_number":8,"context_line":"    Therefore we are removed both the api.fault notification and"},{"line_number":9,"context_line":"    notify_on_api_faults config option from the nova code base."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    .. _`bug 1699115`: https://bugs.launchpad.net/nova/+bug/1699115"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_29071785","line":8,"range":{"start_line":8,"start_character":17,"end_line":8,"end_character":20},"updated":"2017-09-26 17:10:52.000000000","message":"have","commit_id":"47f63615517ba5b401e860745d8aea4ebc37513e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e7f4bcfed20b8827276a56ecd311cfeb247dcea3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    notify_on_api_faults config option have never worked for the v2.1 API."},{"line_number":6,"context_line":"    The v2.0 API is supported with the v2.1 code base since Newton so this"},{"line_number":7,"context_line":"    notification has not been emitted by the v2.0 API either since Newton."},{"line_number":8,"context_line":"    Therefore we are removed both the api.fault notification and"},{"line_number":9,"context_line":"    notify_on_api_faults config option from the nova code base."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    .. _`bug 1699115`: https://bugs.launchpad.net/nova/+bug/1699115"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_c02a7f2a","line":8,"range":{"start_line":8,"start_character":17,"end_line":8,"end_character":20},"in_reply_to":"7f515b1d_29071785","updated":"2017-09-27 08:52:05.000000000","message":"Done","commit_id":"47f63615517ba5b401e860745d8aea4ebc37513e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ba1a1f673cf795c1b9a679bc6e6d2accc597ea02","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As described in `bug 1699115`_ the api.fault notification and the related"},{"line_number":5,"context_line":"    notify_on_api_faults config option have never worked for the v2.1 API."},{"line_number":6,"context_line":"    The v2.0 API is supported with the v2.1 code base since Newton so this"},{"line_number":7,"context_line":"    notification has not been emitted by the v2.0 API either since Newton."},{"line_number":8,"context_line":"    Therefore we have removed both the api.fault notification and"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f515b1d_1f22d8b9","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":24},"updated":"2017-10-02 13:17:06.000000000","message":"We should probably put this in `notify_on_api_faults` or ``notify_on_api_faults`` just to emphasize.","commit_id":"37cf1be8ab18aca27cf998f927a22397445a4437"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"91cc1cd218605c79dc16fbf9ca552ee78647f107","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As described in `bug 1699115`_ the api.fault notification and the related"},{"line_number":5,"context_line":"    ``notify_on_api_faults`` config option have never worked for the v2.1 API."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f515b1d_ce01823a","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2017-10-09 10:50:05.000000000","message":"This is an upgrade note, IMO","commit_id":"b7e8407e98ed6e936b5339e2629f040efbcccefe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"95ca6b66eb4e75acc07344251ad1857a6afb78c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As described in `bug 1699115`_ the api.fault notification and the related"},{"line_number":5,"context_line":"    ``notify_on_api_faults`` config option have never worked for the v2.1 API."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f515b1d_0301a838","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"7f515b1d_ce01823a","updated":"2017-10-09 15:30:37.000000000","message":"Done","commit_id":"b7e8407e98ed6e936b5339e2629f040efbcccefe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"91cc1cd218605c79dc16fbf9ca552ee78647f107","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As described in `bug 1699115`_ the api.fault notification and the related"},{"line_number":5,"context_line":"    ``notify_on_api_faults`` config option have never worked for the v2.1 API."},{"line_number":6,"context_line":"    The v2.0 API is supported with the v2.1 code base since Newton so this"},{"line_number":7,"context_line":"    notification has not been emitted by the v2.0 API either since Newton."},{"line_number":8,"context_line":"    Therefore we have removed both the api.fault notification and"},{"line_number":9,"context_line":"    ``notify_on_api_faults`` config option from the nova code base."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    .. _`bug 1699115`: https://bugs.launchpad.net/nova/+bug/1699115"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f515b1d_ce5d0248","line":9,"range":{"start_line":4,"start_character":0,"end_line":9,"end_character":67},"updated":"2017-10-09 10:50:05.000000000","message":"I have to read all the background info on this before finding out what\u0027s changed - can you reverse the order of this, e.g.\n\n  - |\n    The ``notify_on_api_faults`` config option and the ``api.fault``\n    notification it enabled have been removed. As noted in `bug 1699115`_,\n    the ``api.fault`` notification has not worked since the v2.1 API was\n    introduced. As the v2.0 API is supported with the v2.1 codebase since\n    Newton, this notification has not been emitted since Newton. Given that\n    no one has reported an issue with this in that time, it is simply\n    removed.","commit_id":"b7e8407e98ed6e936b5339e2629f040efbcccefe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"95ca6b66eb4e75acc07344251ad1857a6afb78c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    As described in `bug 1699115`_ the api.fault notification and the related"},{"line_number":5,"context_line":"    ``notify_on_api_faults`` config option have never worked for the v2.1 API."},{"line_number":6,"context_line":"    The v2.0 API is supported with the v2.1 code base since Newton so this"},{"line_number":7,"context_line":"    notification has not been emitted by the v2.0 API either since Newton."},{"line_number":8,"context_line":"    Therefore we have removed both the api.fault notification and"},{"line_number":9,"context_line":"    ``notify_on_api_faults`` config option from the nova code base."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    .. _`bug 1699115`: https://bugs.launchpad.net/nova/+bug/1699115"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f515b1d_e3a7ac4f","line":9,"range":{"start_line":4,"start_character":0,"end_line":9,"end_character":67},"in_reply_to":"7f515b1d_ce5d0248","updated":"2017-10-09 15:30:37.000000000","message":"Done","commit_id":"b7e8407e98ed6e936b5339e2629f040efbcccefe"}]}