)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0eeacd0781975b2707a8315b1dbda8d13c76696a","unresolved":false,"context_lines":[{"line_number":2513,"context_line":""},{"line_number":2514,"context_line":"        # unshelve the server, which should fail"},{"line_number":2515,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027unshelve\u0027: None})"},{"line_number":2516,"context_line":"        self._wait_for_unshelve_fail_completion("},{"line_number":2517,"context_line":"            server, instance_actions.UNSHELVE)"},{"line_number":2518,"context_line":""},{"line_number":2519,"context_line":"        # assert allocations were removed from the host"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_3d5fb542","line":2516,"updated":"2017-09-22 09:19:03.000000000","message":"It would be nice to have consistent instance action error notifications (e.g. instance.unshelve.error) to wait for here instead of polling. But we don\u0027t have that today. :/\n\nAlternatively you can wait for \u0027compute.exception\u0027 notification with\n\nfake_notifier.wait_for_versioned_notifications(\n            \u0027compute.exception\u0027)\n\nat least that does not need an extra util to be implemented and that does not do polling in the background.","commit_id":"56232e5de9cd2b74a2879e2e9c09099c0de2609e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"53b18eb375eef986beb58b069ebb488204768560","unresolved":false,"context_lines":[{"line_number":2513,"context_line":""},{"line_number":2514,"context_line":"        # unshelve the server, which should fail"},{"line_number":2515,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027unshelve\u0027: None})"},{"line_number":2516,"context_line":"        self._wait_for_unshelve_fail_completion("},{"line_number":2517,"context_line":"            server, instance_actions.UNSHELVE)"},{"line_number":2518,"context_line":""},{"line_number":2519,"context_line":"        # assert allocations were removed from the host"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_82b85d2a","line":2516,"in_reply_to":"7f515b1d_116dfd97","updated":"2017-09-25 07:52:46.000000000","message":"wait_for_versioned_notifications() does exists in Pike so this patch is still backportable with wait_for_versioned_notifications() call. However I can accept that with the current way the test is more self contained.","commit_id":"56232e5de9cd2b74a2879e2e9c09099c0de2609e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c571314e9924d9a9441abffa2e5ec6bc745eb253","unresolved":false,"context_lines":[{"line_number":2513,"context_line":""},{"line_number":2514,"context_line":"        # unshelve the server, which should fail"},{"line_number":2515,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027unshelve\u0027: None})"},{"line_number":2516,"context_line":"        self._wait_for_unshelve_fail_completion("},{"line_number":2517,"context_line":"            server, instance_actions.UNSHELVE)"},{"line_number":2518,"context_line":""},{"line_number":2519,"context_line":"        # assert allocations were removed from the host"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_116dfd97","line":2516,"in_reply_to":"7f515b1d_1e63ccde","updated":"2017-09-22 13:43:57.000000000","message":"https://review.openstack.org/#/c/506660/","commit_id":"56232e5de9cd2b74a2879e2e9c09099c0de2609e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5e0b5d5697ad1a8e9eebd2e5ee92cce866c8860","unresolved":false,"context_lines":[{"line_number":2513,"context_line":""},{"line_number":2514,"context_line":"        # unshelve the server, which should fail"},{"line_number":2515,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027unshelve\u0027: None})"},{"line_number":2516,"context_line":"        self._wait_for_unshelve_fail_completion("},{"line_number":2517,"context_line":"            server, instance_actions.UNSHELVE)"},{"line_number":2518,"context_line":""},{"line_number":2519,"context_line":"        # assert allocations were removed from the host"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_1e63ccde","line":2516,"in_reply_to":"7f515b1d_3d5fb542","updated":"2017-09-22 13:01:43.000000000","message":"_wait_for_unshelve_fail_completion was copied from another test above. I was just going to make those generic after this change and move them into the InstanceHelperMixin so we\u0027re not left with this duplicated utility. I just didn\u0027t want to do that as part of this change since it needs to be backported.","commit_id":"56232e5de9cd2b74a2879e2e9c09099c0de2609e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"15d9f6840276afdc00b0d2147ea8a8468f9bdebb","unresolved":false,"context_lines":[{"line_number":2513,"context_line":""},{"line_number":2514,"context_line":"        # unshelve the server, which should fail"},{"line_number":2515,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027unshelve\u0027: None})"},{"line_number":2516,"context_line":"        self._wait_for_unshelve_fail_completion("},{"line_number":2517,"context_line":"            server, instance_actions.UNSHELVE)"},{"line_number":2518,"context_line":""},{"line_number":2519,"context_line":"        # assert allocations were removed from the host"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_c828ab87","line":2516,"in_reply_to":"7f515b1d_82b85d2a","updated":"2017-09-25 15:03:36.000000000","message":"Yeah, better to have a single patch to backport.","commit_id":"56232e5de9cd2b74a2879e2e9c09099c0de2609e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"15d9f6840276afdc00b0d2147ea8a8468f9bdebb","unresolved":false,"context_lines":[{"line_number":2522,"context_line":"        # remove once fixed"},{"line_number":2523,"context_line":"        self.assertFlavorMatchesAllocation(self.flavor1, usages)"},{"line_number":2524,"context_line":"        # self.assertFlavorMatchesAllocation("},{"line_number":2525,"context_line":"        #    {\u0027vcpus\u0027: 0, \u0027ram\u0027: 0, \u0027disk\u0027: 0}, usages)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_8841930e","line":2525,"updated":"2017-09-25 15:03:36.000000000","message":"++","commit_id":"56232e5de9cd2b74a2879e2e9c09099c0de2609e"}]}