)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"841b775380f4bf6993b0643c29d13aea647e98ad","unresolved":false,"context_lines":[{"line_number":3752,"context_line":"    def _get_all_instance_metadata(self, context, search_filts, metadata_type):"},{"line_number":3753,"context_line":"        \"\"\"Get all metadata.\"\"\""},{"line_number":3754,"context_line":"        instances \u003d self._get_instances_by_filters(context, filters\u003d{},"},{"line_number":3755,"context_line":"                                                   fields\u003d[\u0027metadata\u0027],"},{"line_number":3756,"context_line":"                                                   sort_keys\u003d[\u0027created_at\u0027],"},{"line_number":3757,"context_line":"                                                   sort_dirs\u003d[\u0027desc\u0027])"},{"line_number":3758,"context_line":"        return utils.filter_and_format_resource_metadata(\u0027instance\u0027, instances,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f515b1d_cc7cb573","line":3755,"updated":"2017-09-29 16:33:18.000000000","message":"I see your change and raise you https://review.openstack.org/#/c/508299/","commit_id":"42514ddd69f15b0405596bdc48315ebe635e9559"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"115bbfaa15c8955164fdae54201b39b95839709d","unresolved":false,"context_lines":[{"line_number":3752,"context_line":"    def _get_all_instance_metadata(self, context, search_filts, metadata_type):"},{"line_number":3753,"context_line":"        \"\"\"Get all metadata.\"\"\""},{"line_number":3754,"context_line":"        instances \u003d self._get_instances_by_filters(context, filters\u003d{},"},{"line_number":3755,"context_line":"                                                   fields\u003d[\u0027metadata\u0027],"},{"line_number":3756,"context_line":"                                                   sort_keys\u003d[\u0027created_at\u0027],"},{"line_number":3757,"context_line":"                                                   sort_dirs\u003d[\u0027desc\u0027])"},{"line_number":3758,"context_line":"        return utils.filter_and_format_resource_metadata(\u0027instance\u0027, instances,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f515b1d_ccf15503","line":3755,"in_reply_to":"7f515b1d_cc7cb573","updated":"2017-09-29 16:34:30.000000000","message":"This breaks get_all_system_metadata above, which is why I\u0027m just removing that stuff altogether. Note that your unit tests didn\u0027t fail because there is no unit test for get_all_system_metadata. You\u0027re welcome.","commit_id":"42514ddd69f15b0405596bdc48315ebe635e9559"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3fced1c064324184cbdabd589e049e154ec9af9","unresolved":false,"context_lines":[{"line_number":2385,"context_line":"        # Only subtract from limit if it is not None"},{"line_number":2386,"context_line":"        limit \u003d (limit - len(build_req_instances)) if limit else limit"},{"line_number":2387,"context_line":""},{"line_number":2388,"context_line":"        fields \u003d [\u0027metadata\u0027, \u0027system_metadata\u0027, \u0027info_cache\u0027,"},{"line_number":2389,"context_line":"                  \u0027security_groups\u0027]"},{"line_number":2390,"context_line":"        if expected_attrs:"},{"line_number":2391,"context_line":"            fields.extend(expected_attrs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_4637f94e","line":2388,"range":{"start_line":2388,"start_character":31,"end_line":2388,"end_character":46},"updated":"2017-10-05 23:37:19.000000000","message":"Didn\u0027t I already remove this? Maybe just not rebased.\n\nhttps://review.openstack.org/#/c/508335/\n\nI guess just not merged yet.","commit_id":"a9d67d2e188816f036592eb1356dd8c99ec99ad7"}],"nova/compute/instance_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3fced1c064324184cbdabd589e049e154ec9af9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    \"\"\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if not sort_keys:"},{"line_number":114,"context_line":"        # This is the default from the process_sort_params() method in"},{"line_number":115,"context_line":"        # the DB API. It doesn\u0027t really matter, as this only comes into"},{"line_number":116,"context_line":"        # play if the user didn\u0027t ask for a specific ordering, but we"},{"line_number":117,"context_line":"        # use the same scheme for consistency."}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_266cfd34","line":114,"range":{"start_line":114,"start_character":39,"end_line":114,"end_character":58},"updated":"2017-10-05 23:37:19.000000000","message":"It\u0027s actually not, that method defaults to asc. But instance_get_all_by_filters_sort, which calls process_sort_params, passes default_dir\u003d\u0027desc\u0027.","commit_id":"a9d67d2e188816f036592eb1356dd8c99ec99ad7"}],"nova/tests/functional/compute/test_instance_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3fced1c064324184cbdabd589e049e154ec9af9","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        This requests $pages of $pagesize, followed by a final page with"},{"line_number":152,"context_line":"        no limit, and a final-final page which should be empty. It validates"},{"line_number":153,"context_line":"        that we got a consistent set of results no patter where the page"},{"line_number":154,"context_line":"        boundary is, that we got all the results after the unlimited query,"},{"line_number":155,"context_line":"        and that the final page comes back empty when we use the last"},{"line_number":156,"context_line":"        instance as a marker."}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_0650e15d","line":153,"range":{"start_line":153,"start_character":51,"end_line":153,"end_character":57},"updated":"2017-10-05 23:37:19.000000000","message":"matter","commit_id":"a9d67d2e188816f036592eb1356dd8c99ec99ad7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3fced1c064324184cbdabd589e049e154ec9af9","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        while True:"},{"line_number":162,"context_line":"            if page \u003e\u003d pages:"},{"line_number":163,"context_line":"                # We\u0027ve requested the specified number of limited (by pagesize)"},{"line_number":164,"context_line":"                # pages, so request a penultimate page with no limit which"},{"line_number":165,"context_line":"                # should always finish out the result."},{"line_number":166,"context_line":"                limit \u003d None"},{"line_number":167,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_86c97126","line":164,"range":{"start_line":164,"start_character":38,"end_line":164,"end_character":49},"updated":"2017-10-05 23:37:19.000000000","message":"This is a new word to me.","commit_id":"a9d67d2e188816f036592eb1356dd8c99ec99ad7"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8cca9a353477184d56288d807ef8d416ce5bb904","unresolved":false,"context_lines":[{"line_number":10822,"context_line":"                [\u0027memory_mb\u0027],"},{"line_number":10823,"context_line":"                [\u0027asc\u0027],"},{"line_number":10824,"context_line":"                [marker_inst[\u0027memory_mb\u0027] + 1,"},{"line_number":10825,"context_line":"                 marker_inst[\u0027key_name\u0027] + \u0027z\u0027])"},{"line_number":10826,"context_line":"            if not marker:"},{"line_number":10827,"context_line":"                break"},{"line_number":10828,"context_line":"            values_found.append(marker)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_106ce934","line":10825,"range":{"start_line":10825,"start_character":17,"end_line":10825,"end_character":47},"updated":"2017-09-22 01:00:56.000000000","message":"Comment about why this is here? Or just remove it. I don\u0027t really get it\u0027s purpose.","commit_id":"5177973316db890e4f115cae9d031aab44685146"}]}