)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03c5532bce753a43f535d724eee8c5664db7baec","unresolved":false,"context_lines":[{"line_number":27,"context_line":"something, user must pass something to the filter, it cannot be a empty"},{"line_number":28,"context_line":"string."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[1] https://github.com/openstack/nova/blob/master/nova/api/validation/validators.py#L40"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-Bug: #1718877"},{"line_number":33,"context_line":"Change-Id: I3f6fa04dc7267279964e8e5dd2a790b997a40e4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_3100f934","line":30,"range":{"start_line":30,"start_character":43,"end_line":30,"end_character":49},"updated":"2017-09-22 14:00:49.000000000","message":"This is going to go out of date. If you\u0027re going to link to code, use a tag or commit hash like so:\n\nhttps://github.com/openstack/nova/blob/16.0.0/nova/api/validation/validators.py#L40","commit_id":"c19af01b54375945999f368489c7d20fa3638912"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bac5b9deaa707d95f04a51b4cfd7fadd7bda397","unresolved":false,"context_lines":[{"line_number":12,"context_line":"it fails at db layer and returns 500 InternalServerError."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Empty string(\u0027\u0027) is a valid regex for re.compile [1] so nova-api fails"},{"line_number":15,"context_line":"to catch it at schema layer and it is passed to databse for searching."},{"line_number":16,"context_line":"Database fails to search it with \"REGEXP %(display_name_1)s)\" and"},{"line_number":17,"context_line":"\u0027display_name_1\u0027 as u\u0027\u0027 in sql query which leads to below error:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_d4d2b334","line":15,"range":{"start_line":15,"start_character":48,"end_line":15,"end_character":55},"updated":"2017-09-22 14:19:47.000000000","message":"the database","commit_id":"0cc94bfd5934e793cb8d739e132b52fa40bcddb0"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7862ff265e465d0cd08741828a13a6772a922548","unresolved":false,"context_lines":[{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    def test_get_servers_detail_with_empty_regex_filter_param(self):"},{"line_number":713,"context_line":"        empty_string \u003d \u0027\u0027"},{"line_number":714,"context_line":"        req \u003d self.req(\u0027/fake/servers?flavor\u003d%s\u0027 % empty_string,"},{"line_number":715,"context_line":"                       use_admin_context\u003dTrue)"},{"line_number":716,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":717,"context_line":"                          self.controller.detail, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_09695724","line":714,"updated":"2017-09-22 12:21:26.000000000","message":"It apparently doesn\u0027t matter, but to be strictly correct, shouldn\u0027t this URL be /fake/servers/detail?flavor\u003d%s ?","commit_id":"6f33f3ea5dd266c9b4edb0ddc2d7891066160605"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"e465181654f25dbd4d7fda940103d27707dd3a9a","unresolved":false,"context_lines":[{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    def test_get_servers_detail_with_empty_regex_filter_param(self):"},{"line_number":713,"context_line":"        empty_string \u003d \u0027\u0027"},{"line_number":714,"context_line":"        req \u003d self.req(\u0027/fake/servers?flavor\u003d%s\u0027 % empty_string,"},{"line_number":715,"context_line":"                       use_admin_context\u003dTrue)"},{"line_number":716,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":717,"context_line":"                          self.controller.detail, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_fbbb620b","line":714,"in_reply_to":"7f515b1d_09695724","updated":"2017-09-22 12:39:38.000000000","message":"Done","commit_id":"6f33f3ea5dd266c9b4edb0ddc2d7891066160605"}]}
