)]}'
{"nova/cells/opts.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c8e8a999e8452344914f2e660d9d286ad0c338cb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    if not CONF.cells.enable:"},{"line_number":88,"context_line":"        return"},{"line_number":89,"context_line":"    cell_type \u003d CONF.cells.cell_type"},{"line_number":90,"context_line":"    if cell_type:"},{"line_number":91,"context_line":"        if cell_type \u003d\u003d \u0027api\u0027 or cell_type \u003d\u003d \u0027compute\u0027:"},{"line_number":92,"context_line":"            return cell_type"},{"line_number":93,"context_line":"        msg \u003d _(\"cell_type must be configured as \u0027api\u0027 or \u0027compute\u0027\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fmys%3D","side":"PARENT","line":90,"updated":"2013-10-13 07:37:19.000000000","message":"any reason why you dropped the check of the cell_type?","commit_id":"b0f6fdbc763854ef091136d5f75de123d1a1344f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d2d52588cf6057478b68937bb24e3b6afd783b20","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    if not CONF.cells.enable:"},{"line_number":88,"context_line":"        return"},{"line_number":89,"context_line":"    cell_type \u003d CONF.cells.cell_type"},{"line_number":90,"context_line":"    if cell_type:"},{"line_number":91,"context_line":"        if cell_type \u003d\u003d \u0027api\u0027 or cell_type \u003d\u003d \u0027compute\u0027:"},{"line_number":92,"context_line":"            return cell_type"},{"line_number":93,"context_line":"        msg \u003d _(\"cell_type must be configured as \u0027api\u0027 or \u0027compute\u0027\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FZmY%3D","side":"PARENT","line":90,"in_reply_to":"AAAATH%2F%2FjwE%3D","updated":"2013-10-16 17:13:58.000000000","message":"Yep, this all looks good to me.","commit_id":"b0f6fdbc763854ef091136d5f75de123d1a1344f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0e362b7879b0b1c63bf1b40872845f515d2034da","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    if not CONF.cells.enable:"},{"line_number":88,"context_line":"        return"},{"line_number":89,"context_line":"    cell_type \u003d CONF.cells.cell_type"},{"line_number":90,"context_line":"    if cell_type:"},{"line_number":91,"context_line":"        if cell_type \u003d\u003d \u0027api\u0027 or cell_type \u003d\u003d \u0027compute\u0027:"},{"line_number":92,"context_line":"            return cell_type"},{"line_number":93,"context_line":"        msg \u003d _(\"cell_type must be configured as \u0027api\u0027 or \u0027compute\u0027\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FjwE%3D","side":"PARENT","line":90,"in_reply_to":"AAAATH%2F%2FjxU%3D","updated":"2013-10-14 15:09:39.000000000","message":"s/patches/matches/ :)","commit_id":"b0f6fdbc763854ef091136d5f75de123d1a1344f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dc7f65e2e4c255508b15d8e65122f21ef8d57899","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    if not CONF.cells.enable:"},{"line_number":88,"context_line":"        return"},{"line_number":89,"context_line":"    cell_type \u003d CONF.cells.cell_type"},{"line_number":90,"context_line":"    if cell_type:"},{"line_number":91,"context_line":"        if cell_type \u003d\u003d \u0027api\u0027 or cell_type \u003d\u003d \u0027compute\u0027:"},{"line_number":92,"context_line":"            return cell_type"},{"line_number":93,"context_line":"        msg \u003d _(\"cell_type must be configured as \u0027api\u0027 or \u0027compute\u0027\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FjxU%3D","side":"PARENT","line":90,"in_reply_to":"AAAATH%2F%2Fmys%3D","updated":"2013-10-14 15:07:00.000000000","message":"The default changed from None to \u0027compute\u0027. Now, it either patches one of the two valid types, or raises an exception.","commit_id":"b0f6fdbc763854ef091136d5f75de123d1a1344f"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0b79a306d092c89c767921e501c5d6ab11f60a06","unresolved":false,"context_lines":[{"line_number":9527,"context_line":"        result \u003d compute._get_compute_api_class_name()"},{"line_number":9528,"context_line":"        self.assertEqual(\u0027nova.compute.api.API\u0027, result)"},{"line_number":9529,"context_line":""},{"line_number":9530,"context_line":"    def test_illegal_cell_compute_api_class_name(self):"},{"line_number":9531,"context_line":"        self.flags(enable\u003dTrue, group\u003d\u0027cells\u0027)"},{"line_number":9532,"context_line":"        self.flags(cell_type\u003d\u0027fake_cell_type\u0027, group\u003d\u0027cells\u0027)"},{"line_number":9533,"context_line":"        self.assertRaises(exception.InvalidInput,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FmyY%3D","side":"PARENT","line":9530,"updated":"2013-10-13 07:39:15.000000000","message":"this test is related to the previous comment - the test name was a little confusing","commit_id":"b0f6fdbc763854ef091136d5f75de123d1a1344f"}]}