)]}'
{"nova/virt/libvirt/volume/net.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01e2474b9b982dcd335f85a3c07324107bff79ee","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":75,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"},{"line_number":76,"context_line":"            conf.auth_secret_type \u003d netdisk_properties[\u0027secret_type\u0027]"},{"line_number":77,"context_line":"        elif CONF.libvirt.rbd_secret_uuid:"},{"line_number":78,"context_line":"            # Anyone relying on falling back to nova config is probably having"},{"line_number":79,"context_line":"            # this work accidentally and we\u0027ll remove that support in the"},{"line_number":80,"context_line":"            # 17.0.0 Queens release."},{"line_number":81,"context_line":"            # NOTE(mriedem): We\u0027ll have to be extra careful about this in case"},{"line_number":82,"context_line":"            # the reason we got here is due to an old volume connection created"},{"line_number":83,"context_line":"            # before we started preferring the Cinder settings in Ocata."},{"line_number":84,"context_line":"            LOG.warning(\u0027Falling back to Nova configuration values for \u0027"},{"line_number":85,"context_line":"                        \u0027RBD authentication. Cinder should be configured \u0027"},{"line_number":86,"context_line":"                        \u0027for auth with Ceph volumes. This fallback will \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_2c4abb26","side":"PARENT","line":83,"range":{"start_line":77,"start_character":0,"end_line":83,"end_character":72},"updated":"2017-10-31 04:41:56.000000000","message":"this fallback removal can break user who still replying on nova conf for connecting the vol via libvirt.\n\nI know it has been since long and  it says use and configure cinder auth for this. But we have to discuss this removal at broad level. let\u0027s have more opinion on this on nova irc or in meeting. \n\nI am on side of removal this fallback but without breaking any user.","commit_id":"0e5b8a74c05a20e8eb3a66f5644a4353bd0d8666"}]}