)]}'
{"nova/objects/resource_provider.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"53dc212b6f080c58a8ed91310a98b68a0b1ec3cb","unresolved":false,"context_lines":[{"line_number":1837,"context_line":"            # First delete any existing allocations for any consumers. This"},{"line_number":1838,"context_line":"            # provides a clean slate for the consumers mentioned in the list of"},{"line_number":1839,"context_line":"            # allocations being manipulated."},{"line_number":1840,"context_line":"            consumer_ids \u003d set([alloc.consumer_id for alloc in allocs])"},{"line_number":1841,"context_line":"            for consumer_id in consumer_ids:"},{"line_number":1842,"context_line":"                _delete_current_allocs(conn, consumer_id)"},{"line_number":1843,"context_line":"            # Don\u0027t check capacity when alloc.used is zero. Zero is not a"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_79b78188","line":1840,"range":{"start_line":1840,"start_character":31,"end_line":1840,"end_character":32},"updated":"2017-10-10 13:07:10.000000000","message":"don\u0027t need this","commit_id":"0acff2709d71df3dcc96f713dd310802391aef1f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"53dc212b6f080c58a8ed91310a98b68a0b1ec3cb","unresolved":false,"context_lines":[{"line_number":1837,"context_line":"            # First delete any existing allocations for any consumers. This"},{"line_number":1838,"context_line":"            # provides a clean slate for the consumers mentioned in the list of"},{"line_number":1839,"context_line":"            # allocations being manipulated."},{"line_number":1840,"context_line":"            consumer_ids \u003d set([alloc.consumer_id for alloc in allocs])"},{"line_number":1841,"context_line":"            for consumer_id in consumer_ids:"},{"line_number":1842,"context_line":"                _delete_current_allocs(conn, consumer_id)"},{"line_number":1843,"context_line":"            # Don\u0027t check capacity when alloc.used is zero. Zero is not a"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_d9a7954f","line":1840,"range":{"start_line":1840,"start_character":69,"end_line":1840,"end_character":70},"updated":"2017-10-10 13:07:10.000000000","message":"this too","commit_id":"0acff2709d71df3dcc96f713dd310802391aef1f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"83f92012baabc0c34bf0112e528d091698065546","unresolved":false,"context_lines":[{"line_number":1837,"context_line":"            # First delete any existing allocations for any consumers. This"},{"line_number":1838,"context_line":"            # provides a clean slate for the consumers mentioned in the list of"},{"line_number":1839,"context_line":"            # allocations being manipulated."},{"line_number":1840,"context_line":"            consumer_ids \u003d set([alloc.consumer_id for alloc in allocs])"},{"line_number":1841,"context_line":"            for consumer_id in consumer_ids:"},{"line_number":1842,"context_line":"                _delete_current_allocs(conn, consumer_id)"},{"line_number":1843,"context_line":"            # Don\u0027t check capacity when alloc.used is zero. Zero is not a"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_3ca2179c","line":1840,"range":{"start_line":1840,"start_character":31,"end_line":1840,"end_character":32},"in_reply_to":"5f4e5783_79b78188","updated":"2017-10-10 13:22:31.000000000","message":"ah, thanks, yeah","commit_id":"0acff2709d71df3dcc96f713dd310802391aef1f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6af1584ae0fb8b7b43e30c0e4d42668a7e4bca18","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"            # must be done before checking capacity."},{"line_number":1791,"context_line":"            for alloc in allocs:"},{"line_number":1792,"context_line":"                consumer_id \u003d alloc.consumer_id"},{"line_number":1793,"context_line":"                _delete_allocations_for_consumer(context, consumer_id)"},{"line_number":1794,"context_line":"            # Don\u0027t check capacity when alloc.used is zero. Zero is not a"},{"line_number":1795,"context_line":"            # valid amount when making an allocation (the minimum consumption"},{"line_number":1796,"context_line":"            # of a resource is one) but is used in this method to indicate a"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_e2659146","side":"PARENT","line":1793,"range":{"start_line":1793,"start_character":16,"end_line":1793,"end_character":70},"updated":"2017-10-23 16:00:05.000000000","message":"So we may call this function multiple times with the same consumer_id. I would have expected this to get resolved into a noop but it would appear not to be the case","commit_id":"985931c3b0c7bd673c5ab7fddea2c0b483fe4c67"}]}