)]}'
{"nova/api/openstack/compute/schemas/hypervisors.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"80220d3afe774ab8a143093ba94ab25ba1b604c5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"list_query_schema_v233 \u003d {"},{"line_number":18,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":19,"context_line":"    \u0027properties\u0027: {"},{"line_number":20,"context_line":"        \u0027limit\u0027: parameter_types.single_param("},{"line_number":21,"context_line":"            parameter_types.non_negative_integer),"},{"line_number":22,"context_line":"        \u0027marker\u0027: parameter_types.single_param({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"    },"},{"line_number":24,"context_line":"    \u0027additionalProperties\u0027: False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_72e06fcd","line":21,"range":{"start_line":20,"start_character":8,"end_line":21,"end_character":50},"updated":"2017-09-26 05:05:00.000000000","message":"we should keep backward-compatible for 2.33, it should accept multi params and accept addtional properties","commit_id":"719fdcb5b66b7731683152b690a045e4ebf41801"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c4543e2ac3d8bb7e94191882433548cff80050b7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"list_query_schema_v233 \u003d {"},{"line_number":18,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":19,"context_line":"    \u0027properties\u0027: {"},{"line_number":20,"context_line":"        \u0027limit\u0027: parameter_types.single_param("},{"line_number":21,"context_line":"            parameter_types.non_negative_integer),"},{"line_number":22,"context_line":"        \u0027marker\u0027: parameter_types.single_param({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"    },"},{"line_number":24,"context_line":"    \u0027additionalProperties\u0027: False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_b24a67a9","line":21,"range":{"start_line":20,"start_character":8,"end_line":21,"end_character":50},"in_reply_to":"7f515b1d_72e06fcd","updated":"2017-09-26 05:20:36.000000000","message":"humm, yea that was my first thought but as these query param were introduced in 2.33, i thought of making them strict is ok. But i agree with you that we did not do that while doing 2.33 so it can break people using it with multi value and additional param.\n\nand anyways 2.53 make them strict and better.","commit_id":"719fdcb5b66b7731683152b690a045e4ebf41801"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e90217e95fa9651b4d6e1eb28e0c7aeec222f940","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \u0027properties\u0027: parameter_types.pagination_parameters,"},{"line_number":20,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":21,"context_line":"    # As of now Schema validation stripped out the additional parameters and"},{"line_number":22,"context_line":"    # does not raise 400. In microversion 2.53, the additional parameters"},{"line_number":23,"context_line":"    # are not allowed."},{"line_number":24,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_65028b71","line":23,"range":{"start_line":22,"start_character":26,"end_line":23,"end_character":22},"updated":"2017-09-28 18:14:50.000000000","message":"Good NOTE I wanted to see.","commit_id":"291f407a490f88b67ff935d5762c6ae18594975d"}]}
