)]}'
{"nova/tests/unit/virt/libvirt/test_guest.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"285b9a18b281cbe60da746f8fb579fe0febef0ad","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        self.domain.migrateToURI2.assert_called_once_with("},{"line_number":642,"context_line":"            \u0027an-uri\u0027, miguri\u003dNone, dxml\u003d\u0027\u003c/xml\u003e\u0027, flags\u003d1, bandwidth\u003d2)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def test_migrate_v3(self):"},{"line_number":645,"context_line":"        self.guest.migrate(\u0027an-uri\u0027, domain_xml\u003d\u0027\u003c/xml\u003e\u0027,"},{"line_number":646,"context_line":"                           params\u003d{\u0027p1\u0027: \u0027v1\u0027}, flags\u003d1, bandwidth\u003d2)"},{"line_number":647,"context_line":"        self.domain.migrateToURI3.assert_called_once_with("},{"line_number":648,"context_line":"            \u0027an-uri\u0027, flags\u003d1, params\u003d{\u0027p1\u0027: \u0027v1\u0027})"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    @testtools.skipIf(not six.PY2, \u0027libvirt python3 bindings accept unicode\u0027)"},{"line_number":651,"context_line":"    def test_migrate_v3_unicode(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_e3b23ee6","line":648,"range":{"start_line":644,"start_character":0,"end_line":648,"end_character":51},"updated":"2017-09-26 16:06:34.000000000","message":"Could you mark this as skipif not six.PY3 and check if things are called with byte string. Might as well have a positive test in addition to the negative test below","commit_id":"a458a21637d879c484ead1bd64ed943f766c817b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"23116618060cd93dd220cd18cf1df7e9ac16a036","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        self.domain.migrateToURI2.assert_called_once_with("},{"line_number":642,"context_line":"            \u0027an-uri\u0027, miguri\u003dNone, dxml\u003d\u0027\u003c/xml\u003e\u0027, flags\u003d1, bandwidth\u003d2)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def test_migrate_v3(self):"},{"line_number":645,"context_line":"        self.guest.migrate(\u0027an-uri\u0027, domain_xml\u003d\u0027\u003c/xml\u003e\u0027,"},{"line_number":646,"context_line":"                           params\u003d{\u0027p1\u0027: \u0027v1\u0027}, flags\u003d1, bandwidth\u003d2)"},{"line_number":647,"context_line":"        self.domain.migrateToURI3.assert_called_once_with("},{"line_number":648,"context_line":"            \u0027an-uri\u0027, flags\u003d1, params\u003d{\u0027p1\u0027: \u0027v1\u0027})"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    @testtools.skipIf(not six.PY2, \u0027libvirt python3 bindings accept unicode\u0027)"},{"line_number":651,"context_line":"    def test_migrate_v3_unicode(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_f11be87d","line":648,"range":{"start_line":644,"start_character":0,"end_line":648,"end_character":51},"in_reply_to":"7f515b1d_4bd9ebf0","updated":"2017-09-28 13:46:31.000000000","message":"I misread \u0027not six.PY2\u0027 below as \u0027not six.PY3\u0027. The test below is doing exactly what I asked for. nvm me","commit_id":"a458a21637d879c484ead1bd64ed943f766c817b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff320fdcdfcd7854dc265abb1e7a24c1beab60e9","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        self.domain.migrateToURI2.assert_called_once_with("},{"line_number":642,"context_line":"            \u0027an-uri\u0027, miguri\u003dNone, dxml\u003d\u0027\u003c/xml\u003e\u0027, flags\u003d1, bandwidth\u003d2)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def test_migrate_v3(self):"},{"line_number":645,"context_line":"        self.guest.migrate(\u0027an-uri\u0027, domain_xml\u003d\u0027\u003c/xml\u003e\u0027,"},{"line_number":646,"context_line":"                           params\u003d{\u0027p1\u0027: \u0027v1\u0027}, flags\u003d1, bandwidth\u003d2)"},{"line_number":647,"context_line":"        self.domain.migrateToURI3.assert_called_once_with("},{"line_number":648,"context_line":"            \u0027an-uri\u0027, flags\u003d1, params\u003d{\u0027p1\u0027: \u0027v1\u0027})"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    @testtools.skipIf(not six.PY2, \u0027libvirt python3 bindings accept unicode\u0027)"},{"line_number":651,"context_line":"    def test_migrate_v3_unicode(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_4bd9ebf0","line":648,"range":{"start_line":644,"start_character":0,"end_line":648,"end_character":51},"in_reply_to":"7f515b1d_70e379da","updated":"2017-09-28 12:38:45.000000000","message":"I think you misunderstood me or I wasn\u0027t clear. I\u0027m not asking to check if byte strings are passed through - rather, I\u0027m asking to ensure that a call to the \u0027migrate\u0027 function with some unicode params will result in them being converted to byte strings before being passed through. You have the \u0027if six.PY2\u0027 block and I\u0027d like to see that tested","commit_id":"a458a21637d879c484ead1bd64ed943f766c817b"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"eeaaa4ee4ad07009a6d07adc930443e9bb3decd9","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        self.domain.migrateToURI2.assert_called_once_with("},{"line_number":642,"context_line":"            \u0027an-uri\u0027, miguri\u003dNone, dxml\u003d\u0027\u003c/xml\u003e\u0027, flags\u003d1, bandwidth\u003d2)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def test_migrate_v3(self):"},{"line_number":645,"context_line":"        self.guest.migrate(\u0027an-uri\u0027, domain_xml\u003d\u0027\u003c/xml\u003e\u0027,"},{"line_number":646,"context_line":"                           params\u003d{\u0027p1\u0027: \u0027v1\u0027}, flags\u003d1, bandwidth\u003d2)"},{"line_number":647,"context_line":"        self.domain.migrateToURI3.assert_called_once_with("},{"line_number":648,"context_line":"            \u0027an-uri\u0027, flags\u003d1, params\u003d{\u0027p1\u0027: \u0027v1\u0027})"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    @testtools.skipIf(not six.PY2, \u0027libvirt python3 bindings accept unicode\u0027)"},{"line_number":651,"context_line":"    def test_migrate_v3_unicode(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_70e379da","line":648,"range":{"start_line":644,"start_character":0,"end_line":648,"end_character":51},"in_reply_to":"7f515b1d_e3b23ee6","updated":"2017-09-28 09:14:43.000000000","message":"We\u0027re not actually interested in asserting that byte strings are passed through. They would be, but that\u0027s undefined behaviour, and we have no reason to define it as we aren\u0027t interested in it. The interesting behaviour that we want to test here is that unicode strings are passed through unmodified.\n\nNow that you mentioned it, though, I agree that we want to test the positive case, so I actually wrote it. Only having written it did I twig that u\u0027foo\u0027 \u003d\u003d \u0027foo\u0027 in python3, so in fact this test is already correctly asserting the intended behaviour for both python2 and python3. I\u0027m going to leave it alone unless I misunderstood :)","commit_id":"a458a21637d879c484ead1bd64ed943f766c817b"}]}