)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dcb85d2e643ccfa02d63a89917a11c66f66797d1","unresolved":false,"context_lines":[{"line_number":5870,"context_line":"            Contains the status we want to set for the migration object"},{"line_number":5871,"context_line":""},{"line_number":5872,"context_line":"        \"\"\""},{"line_number":5873,"context_line":"        # Remove allocations created in Placement for the dest node."},{"line_number":5874,"context_line":"        # NOTE(mriedem): The migrate_data.migration object does not have the"},{"line_number":5875,"context_line":"        # dest_node (or dest UUID) set, so we have to lookup the destination"},{"line_number":5876,"context_line":"        # ComputeNode with only the hostname."},{"line_number":5877,"context_line":"        dest_node \u003d objects.ComputeNode.get_first_node_by_host_for_old_compat("},{"line_number":5878,"context_line":"            context, dest, use_slave\u003dTrue)"},{"line_number":5879,"context_line":"        reportclient \u003d self.scheduler_client.reportclient"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_493168ec","line":5876,"range":{"start_line":5873,"start_character":0,"end_line":5876,"end_character":42},"updated":"2017-10-05 09:09:14.000000000","message":"Would it be better to make a change that sets the dest_node on the migration object? I guess in the long run we want to remove the old compat call so we should try not to spread it further.","commit_id":"f90c61cd88edce74e3dbfd069beb2c33793d3371"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3c8017345abe73956ba5e4958f4b834b5f4ec30","unresolved":false,"context_lines":[{"line_number":5870,"context_line":"            Contains the status we want to set for the migration object"},{"line_number":5871,"context_line":""},{"line_number":5872,"context_line":"        \"\"\""},{"line_number":5873,"context_line":"        # Remove allocations created in Placement for the dest node."},{"line_number":5874,"context_line":"        # NOTE(mriedem): The migrate_data.migration object does not have the"},{"line_number":5875,"context_line":"        # dest_node (or dest UUID) set, so we have to lookup the destination"},{"line_number":5876,"context_line":"        # ComputeNode with only the hostname."},{"line_number":5877,"context_line":"        dest_node \u003d objects.ComputeNode.get_first_node_by_host_for_old_compat("},{"line_number":5878,"context_line":"            context, dest, use_slave\u003dTrue)"},{"line_number":5879,"context_line":"        reportclient \u003d self.scheduler_client.reportclient"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_22363ee9","line":5876,"range":{"start_line":5873,"start_character":0,"end_line":5876,"end_character":42},"in_reply_to":"7f515b1d_493168ec","updated":"2017-10-05 12:55:31.000000000","message":"I have a change to do this:\n\nhttps://review.openstack.org/#/c/508699/\n\nBut even then we have to lookup the compute node by host/node since the migration object doesn\u0027t have the dest node uuid on it.","commit_id":"f90c61cd88edce74e3dbfd069beb2c33793d3371"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e0a3abb36c68872506bfbe30b0bb1599307eb8d3","unresolved":false,"context_lines":[{"line_number":2455,"context_line":"        allocations \u003d self._get_allocations_by_server_uuid(server[\u0027id\u0027])"},{"line_number":2456,"context_line":"        # Note(lajos katona): After solving bug #1714237 there should be"},{"line_number":2457,"context_line":"        # only 1 allocation:"},{"line_number":2458,"context_line":"        # self.assertEqual(1, len(allocations))"},{"line_number":2459,"context_line":"        self.assertEqual(2, len(allocations))"},{"line_number":2460,"context_line":""},{"line_number":2461,"context_line":"        # Note(lajos katona): After solving bug #1714237 the destination"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_198009c0","line":2458,"updated":"2017-09-27 16:17:56.000000000","message":"I think your fix fixes this fault as well. As aborting a live migration will lead to _rollback_live_migration in the compute manager too.","commit_id":"fbd4b127b7f4116bfb3e32b6c9507aa91b7b4218"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11e0137ecfdc085905a435a4a14ba4c3217b8ae9","unresolved":false,"context_lines":[{"line_number":2464,"context_line":""},{"line_number":2465,"context_line":"        dest_usages \u003d self._get_provider_usages(dest_rp_uuid)"},{"line_number":2466,"context_line":"        self.assertFlavorMatchesAllocation("},{"line_number":2467,"context_line":"           {\u0027ram\u0027: 0, \u0027disk\u0027: 0, \u0027vcpus\u0027: 0}, dest_usages)"},{"line_number":2468,"context_line":""},{"line_number":2469,"context_line":"        self._delete_and_check_allocations("},{"line_number":2470,"context_line":"            server, source_rp_uuid, dest_rp_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_e655ba51","line":2467,"updated":"2017-10-06 09:51:34.000000000","message":"I think you missed to add asserting that the dest_allocation is all zero as well.","commit_id":"f90c61cd88edce74e3dbfd069beb2c33793d3371"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6aa7e5b8e16059f8e005eca221cf641f0f7f271c","unresolved":false,"context_lines":[{"line_number":2464,"context_line":""},{"line_number":2465,"context_line":"        dest_usages \u003d self._get_provider_usages(dest_rp_uuid)"},{"line_number":2466,"context_line":"        self.assertFlavorMatchesAllocation("},{"line_number":2467,"context_line":"           {\u0027ram\u0027: 0, \u0027disk\u0027: 0, \u0027vcpus\u0027: 0}, dest_usages)"},{"line_number":2468,"context_line":""},{"line_number":2469,"context_line":"        self._delete_and_check_allocations("},{"line_number":2470,"context_line":"            server, source_rp_uuid, dest_rp_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_0670d6db","line":2467,"in_reply_to":"7f515b1d_e655ba51","updated":"2017-10-06 09:59:04.000000000","message":"Never mind. My bad. You did checked that at L2457","commit_id":"f90c61cd88edce74e3dbfd069beb2c33793d3371"}]}