)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"803c23ac5222bbda294606b0c4e0b35689ed2550","unresolved":false,"context_lines":[{"line_number":10,"context_line":"get_ksa_adapter utility to create an Adapter from common keystoneauth1"},{"line_number":11,"context_line":"configuration options.  This is effectively identical to the prior"},{"line_number":12,"context_line":"functionality, with the addition of support for Adapter conf options"},{"line_number":13,"context_line":"such as `region_name` and `interface` which should almost never need to"},{"line_number":14,"context_line":"be overridden."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As part of blueprint use-ksa-adapter-for-endpoints, this provides a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff82abbf_23781bc2","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":36},"updated":"2017-11-28 02:14:24.000000000","message":"valid_interfaces?\n\nTo be clear, these are the new options in the [keystone] conf group now:\n\n# The default service_type for endpoint URL discovery. (string value)\n#service_type \u003d identity\n\n# The default service_name for endpoint URL discovery. (string value)\n#service_name \u003d \u003cNone\u003e\n\n# List of interfaces, in order of preference, for endpoint URL. (list value)\n#valid_interfaces \u003d internal,public\n\n# The default region_name for endpoint URL discovery. (string value)\n#region_name \u003d \u003cNone\u003e\n\n# Always use this endpoint URL for requests for this client. (string value)\n#endpoint_override \u003d \u003cNone\u003e","commit_id":"5e6fffe37c72f2acff4a5d9a8599593a64a5f8f8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f217feef3acb2a650dabd7328810ede855d535f6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"get_ksa_adapter utility to create an Adapter from common keystoneauth1"},{"line_number":11,"context_line":"configuration options.  This is effectively identical to the prior"},{"line_number":12,"context_line":"functionality, with the addition of support for Adapter conf options"},{"line_number":13,"context_line":"such as `region_name` and `interface` which should almost never need to"},{"line_number":14,"context_line":"be overridden."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As part of blueprint use-ksa-adapter-for-endpoints, this provides a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff82abbf_e4b0eedf","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":36},"in_reply_to":"ff82abbf_23781bc2","updated":"2017-11-28 13:58:10.000000000","message":"Done","commit_id":"5e6fffe37c72f2acff4a5d9a8599593a64a5f8f8"}],"nova/api/openstack/identity.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"803c23ac5222bbda294606b0c4e0b35689ed2550","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    try:"},{"line_number":41,"context_line":"        resp \u003d adap.get(\u0027/projects/%s\u0027 % project_id, raise_exc\u003dFalse)"},{"line_number":42,"context_line":"    except kse.EndpointNotFound:"},{"line_number":43,"context_line":"        LOG.error("},{"line_number":44,"context_line":"            \"Keystone identity service version 3.0 was not found. This might \""},{"line_number":45,"context_line":"            \"be because your endpoint points to the v2.0 versioned endpoint \""},{"line_number":46,"context_line":"            \"which is not supported. Please fix this.\")"},{"line_number":47,"context_line":"        raise failure"},{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_034ab7aa","line":46,"range":{"start_line":43,"start_character":7,"end_line":46,"end_character":55},"updated":"2017-11-28 02:14:24.000000000","message":"If we\u0027re specifying a min_version of 3.0, could we actually get here and log this? And if we can get EndpointNotFound for some other reason, should we change this error message? Like, could this mean there is no \u0027identity\u0027 entry in the service catalog? Although we were using this before so maybe it\u0027s fine:\n\n                        endpoint_filter\u003d{\n                            \u0027service_type\u0027: \u0027identity\u0027,\n                            \u0027version\u0027: (3, 0)\n                        }","commit_id":"5e6fffe37c72f2acff4a5d9a8599593a64a5f8f8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f217feef3acb2a650dabd7328810ede855d535f6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    try:"},{"line_number":41,"context_line":"        resp \u003d adap.get(\u0027/projects/%s\u0027 % project_id, raise_exc\u003dFalse)"},{"line_number":42,"context_line":"    except kse.EndpointNotFound:"},{"line_number":43,"context_line":"        LOG.error("},{"line_number":44,"context_line":"            \"Keystone identity service version 3.0 was not found. This might \""},{"line_number":45,"context_line":"            \"be because your endpoint points to the v2.0 versioned endpoint \""},{"line_number":46,"context_line":"            \"which is not supported. Please fix this.\")"},{"line_number":47,"context_line":"        raise failure"},{"line_number":48,"context_line":"    except kse.ClientException:"},{"line_number":49,"context_line":"        # something is wrong, like there isn\u0027t a keystone v3 endpoint,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_a4974648","line":46,"range":{"start_line":43,"start_character":7,"end_line":46,"end_character":55},"in_reply_to":"ff82abbf_034ab7aa","updated":"2017-11-28 13:58:10.000000000","message":"The previous endpoint_filter stuff is now subsumed by the get_ksa_adapter args on L34-5.  Yes, there are other reasons we could get EndpointNotFound, including the endpoint being entirely absent as you say.  I figure that\u0027s covered by \"might\" in the message.  Overall, I opted for leaving this message alone because we\u0027re actually not changing anything here - just refactoring which bits are validated where.","commit_id":"5e6fffe37c72f2acff4a5d9a8599593a64a5f8f8"}],"releasenotes/notes/add_keystone_option-138dff5efb9a53aa.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"803c23ac5222bbda294606b0c4e0b35689ed2550","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``keystone`` config section is added so that you can"},{"line_number":5,"context_line":"    set adapter and session link attributes for communicating with keystone."},{"line_number":6,"context_line":"    This allows the use of custom certificates to secure the link between"},{"line_number":7,"context_line":"    Nova and Keystone."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_031cf7be","line":5,"updated":"2017-11-28 02:14:24.000000000","message":"We shouldn\u0027t update this release note. It was backported to Pike too via Ice4b226fdabdfb66e60b61de05ac8f3b37610661. Given what\u0027s in here it doesn\u0027t seem worthwhile to change it anyway. If you wanted to call out the new options, mention those in a new release note.","commit_id":"5e6fffe37c72f2acff4a5d9a8599593a64a5f8f8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f217feef3acb2a650dabd7328810ede855d535f6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new ``keystone`` config section is added so that you can"},{"line_number":5,"context_line":"    set adapter and session link attributes for communicating with keystone."},{"line_number":6,"context_line":"    This allows the use of custom certificates to secure the link between"},{"line_number":7,"context_line":"    Nova and Keystone."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_c4c92a59","line":5,"in_reply_to":"ff82abbf_031cf7be","updated":"2017-11-28 13:58:10.000000000","message":"I reverted it.","commit_id":"5e6fffe37c72f2acff4a5d9a8599593a64a5f8f8"}]}