)]}'
{"tools/pretty_tox3.sh":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cb1cc680569f1c21167c4b8c2a91e932159f690d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ -z \"$TESTRARGS\" ]; then"},{"line_number":12,"context_line":"    stestr run --blacklist_file $blacklist_file"},{"line_number":13,"context_line":"else"},{"line_number":14,"context_line":"    stestr run \"$TESTRARGS\""},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f515b1d_3182fcc9","line":12,"updated":"2017-10-05 21:48:48.000000000","message":"Well this is something I didn\u0027t catch in the differences between ostestr and stestr. In stestr the flag is \u0027--blacklist-file\u0027 not \u0027--blacklist_file\u0027 because it doesn\u0027t match a known argument stestr is interpreting this as a regex and that\u0027s what\u0027s not matching anything.","commit_id":"4ed082f682fd2c24b15c5ea87a2a642317a36236"}],"tox.ini":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"609714edb41d7ebd55d3e88208defca2a065db6f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[testenv:py27]"},{"line_number":30,"context_line":"commands \u003d"},{"line_number":31,"context_line":"    {[testenv]commands}"},{"line_number":32,"context_line":"    stestr run \u0027{posargs}\u0027"},{"line_number":33,"context_line":"    env TEST_OSPROFILER\u003d1 stestr run --combine --no-discover \u0027nova.tests.unit.test_profiler\u0027"},{"line_number":34,"context_line":"    stestr slowest"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7f515b1d_727b5a27","line":31,"updated":"2017-09-29 18:19:15.000000000","message":"See how this uses a template from the base testenv and then overrides some stuff? Can we do that below?\n\nLike {[testenv]setenv} ?","commit_id":"9716c29d035981ee386fdb2f38f11214c01d3d9e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"47f997cd0b9ed42602390929031a65359d894bec","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[testenv:py27]"},{"line_number":30,"context_line":"commands \u003d"},{"line_number":31,"context_line":"    {[testenv]commands}"},{"line_number":32,"context_line":"    stestr run \u0027{posargs}\u0027"},{"line_number":33,"context_line":"    env TEST_OSPROFILER\u003d1 stestr run --combine --no-discover \u0027nova.tests.unit.test_profiler\u0027"},{"line_number":34,"context_line":"    stestr slowest"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7f515b1d_12e0a6cc","line":31,"in_reply_to":"7f515b1d_727b5a27","updated":"2017-09-29 18:23:11.000000000","message":"Thanks, I\u0027ll try it.","commit_id":"9716c29d035981ee386fdb2f38f11214c01d3d9e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a0cc684fd189732f29fdc4e8ccec89598751e89c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"[testenv:functional-py35]"},{"line_number":80,"context_line":"basepython \u003d python3.5"},{"line_number":81,"context_line":"usedevelop \u003d True"},{"line_number":82,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":83,"context_line":"       OS_TEST_PATH\u003d./nova/tests/functional"},{"line_number":84,"context_line":"       LANGUAGE\u003den_US"},{"line_number":85,"context_line":"commands \u003d"},{"line_number":86,"context_line":"    {[testenv]commands}"},{"line_number":87,"context_line":"    bash tools/pretty_tox3.sh \u0027{posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7f515b1d_a987bcb6","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":21},"updated":"2017-10-05 09:30:48.000000000","message":"I think this can be simplified as well in the same way as [testenv:functional] was simplified in this patch.","commit_id":"bca6694c18e577459de0bca371ee84fa00d7b94c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"014d0d54b6a188f4f6c85ed33bef217606ca30ee","unresolved":false,"context_lines":[{"line_number":79,"context_line":"[testenv:functional-py35]"},{"line_number":80,"context_line":"basepython \u003d python3.5"},{"line_number":81,"context_line":"usedevelop \u003d True"},{"line_number":82,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":83,"context_line":"       OS_TEST_PATH\u003d./nova/tests/functional"},{"line_number":84,"context_line":"       LANGUAGE\u003den_US"},{"line_number":85,"context_line":"commands \u003d"},{"line_number":86,"context_line":"    {[testenv]commands}"},{"line_number":87,"context_line":"    bash tools/pretty_tox3.sh \u0027{posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7f515b1d_90440e49","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":21},"in_reply_to":"7f515b1d_25d3dad7","updated":"2017-10-05 19:30:45.000000000","message":"Oh, whoops. Thanks for that.","commit_id":"bca6694c18e577459de0bca371ee84fa00d7b94c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"533049d36a7625bc027cc04fc2669794165f9a58","unresolved":false,"context_lines":[{"line_number":79,"context_line":"[testenv:functional-py35]"},{"line_number":80,"context_line":"basepython \u003d python3.5"},{"line_number":81,"context_line":"usedevelop \u003d True"},{"line_number":82,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":83,"context_line":"       OS_TEST_PATH\u003d./nova/tests/functional"},{"line_number":84,"context_line":"       LANGUAGE\u003den_US"},{"line_number":85,"context_line":"commands \u003d"},{"line_number":86,"context_line":"    {[testenv]commands}"},{"line_number":87,"context_line":"    bash tools/pretty_tox3.sh \u0027{posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7f515b1d_c5abe672","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":21},"in_reply_to":"7f515b1d_a987bcb6","updated":"2017-10-05 19:14:43.000000000","message":"The py35 envs are still using ostestr and thus are getting OS_STDOUT_CAPTURE, OS_STDERR_CAPTURE, and OS_TEST_TIMEOUT from .testr.conf so it looks like I mistakenly changed the py35 unit test one. But, I think it doesn\u0027t hurt to set the env vars twice so maybe it\u0027s best to just change them all now. The py35 envs still need to be changed over to stestr I think.","commit_id":"bca6694c18e577459de0bca371ee84fa00d7b94c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1083f2248fd85d49b45febe830cde28b178b4331","unresolved":false,"context_lines":[{"line_number":79,"context_line":"[testenv:functional-py35]"},{"line_number":80,"context_line":"basepython \u003d python3.5"},{"line_number":81,"context_line":"usedevelop \u003d True"},{"line_number":82,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":83,"context_line":"       OS_TEST_PATH\u003d./nova/tests/functional"},{"line_number":84,"context_line":"       LANGUAGE\u003den_US"},{"line_number":85,"context_line":"commands \u003d"},{"line_number":86,"context_line":"    {[testenv]commands}"},{"line_number":87,"context_line":"    bash tools/pretty_tox3.sh \u0027{posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7f515b1d_25d3dad7","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":21},"in_reply_to":"7f515b1d_c5abe672","updated":"2017-10-05 19:19:53.000000000","message":"Actually ostestr is using stestr internally since the 1.0.0.0 release and doesn\u0027t use the .testr.conf. It won\u0027t be getting these env variables from there.\n\nThe testr.conf only comes into play if your using ostestr \u003c 1.0.0, using testr directly, or via the pbr hook which is the python setup.py testr stuff)","commit_id":"bca6694c18e577459de0bca371ee84fa00d7b94c"}]}