)]}'
{"nova/objects/pci_device.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9aa05310e7e7e61a2fba59845f6da8ef6ba30511","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # Version 1.4: Added parent_addr field"},{"line_number":96,"context_line":"    # Version 1.5: Added 2 new device statuses: UNCLAIMABLE and UNAVAILABLE"},{"line_number":97,"context_line":"    # Version 1.6: Added uuid field"},{"line_number":98,"context_line":"    # Version 1.7: Update address to accept NULL value"},{"line_number":99,"context_line":"    VERSION \u003d \u00271.7\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_dd07dd81","line":98,"updated":"2017-09-28 15:48:19.000000000","message":"You can\u0027t do this. This will break every consumer you send this object to with a None value for this field. You need to have a backport rule for it and then handle what happens in the caller if you can\u0027t send a thing because of a version requirement. That gets very messy since the backport happens in conductor after the thing has already been received by the compute (or whatever is old).","commit_id":"73aaf604644782a28018c941b778587a82617e7f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ea0e4153bcdb54be9ff99c5dd433b069b68934f2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # Version 1.4: Added parent_addr field"},{"line_number":96,"context_line":"    # Version 1.5: Added 2 new device statuses: UNCLAIMABLE and UNAVAILABLE"},{"line_number":97,"context_line":"    # Version 1.6: Added uuid field"},{"line_number":98,"context_line":"    # Version 1.7: Update address to accept NULL value"},{"line_number":99,"context_line":"    VERSION \u003d \u00271.7\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_d467a1e8","line":98,"in_reply_to":"7f515b1d_be85345c","updated":"2017-09-29 14:18:19.000000000","message":"Anything that receives an object 1.7 when 1.6 is all that is supported. You know, the same as any other object versioning scenario.","commit_id":"73aaf604644782a28018c941b778587a82617e7f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3fa4688146580f4866d56b871bcbdf55433e817e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # Version 1.4: Added parent_addr field"},{"line_number":96,"context_line":"    # Version 1.5: Added 2 new device statuses: UNCLAIMABLE and UNAVAILABLE"},{"line_number":97,"context_line":"    # Version 1.6: Added uuid field"},{"line_number":98,"context_line":"    # Version 1.7: Update address to accept NULL value"},{"line_number":99,"context_line":"    VERSION \u003d \u00271.7\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_4fa79abe","line":98,"in_reply_to":"7f515b1d_d467a1e8","updated":"2017-09-29 15:12:58.000000000","message":"Can you elaborate your review, what is this \"anything\", and I\u0027m also interested of the scenario where it could happen?","commit_id":"73aaf604644782a28018c941b778587a82617e7f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b7368554583907da5bab98e3db1581420fda0c29","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # Version 1.4: Added parent_addr field"},{"line_number":96,"context_line":"    # Version 1.5: Added 2 new device statuses: UNCLAIMABLE and UNAVAILABLE"},{"line_number":97,"context_line":"    # Version 1.6: Added uuid field"},{"line_number":98,"context_line":"    # Version 1.7: Update address to accept NULL value"},{"line_number":99,"context_line":"    VERSION \u003d \u00271.7\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_be85345c","line":98,"in_reply_to":"7f515b1d_dd07dd81","updated":"2017-09-29 08:54:24.000000000","message":"What is the consumer you are mentioning?","commit_id":"73aaf604644782a28018c941b778587a82617e7f"}]}