)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"78e16790a2ce2c72c695785f5d27dcc978917236","unresolved":false,"context_lines":[{"line_number":2660,"context_line":"                              injected_files, admin_password, bdms,"},{"line_number":2661,"context_line":"                              detach_block_devices, attach_block_devices,"},{"line_number":2662,"context_line":"                              network_info\u003dNone,"},{"line_number":2663,"context_line":"                              recreate\u003dFalse, block_device_info\u003dNone,"},{"line_number":2664,"context_line":"                              preserve_ephemeral\u003dFalse):"},{"line_number":2665,"context_line":"        if preserve_ephemeral:"},{"line_number":2666,"context_line":"            # The default code path does not support preserving ephemeral"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_d17d0a1d","line":2663,"range":{"start_line":2663,"start_character":30,"end_line":2663,"end_character":38},"updated":"2017-10-11 09:56:16.000000000","message":"this one need change as well","commit_id":"de0157b643eea2fc394aae15662319ae6485ba65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c6dd54bed5b4c043d3b45a9cd6a66c86e463d71","unresolved":false,"context_lines":[{"line_number":2660,"context_line":"                              injected_files, admin_password, bdms,"},{"line_number":2661,"context_line":"                              detach_block_devices, attach_block_devices,"},{"line_number":2662,"context_line":"                              network_info\u003dNone,"},{"line_number":2663,"context_line":"                              recreate\u003dFalse, block_device_info\u003dNone,"},{"line_number":2664,"context_line":"                              preserve_ephemeral\u003dFalse):"},{"line_number":2665,"context_line":"        if preserve_ephemeral:"},{"line_number":2666,"context_line":"            # The default code path does not support preserving ephemeral"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_61b6d6df","line":2663,"range":{"start_line":2663,"start_character":30,"end_line":2663,"end_character":38},"in_reply_to":"5f4e5783_11b282e7","updated":"2017-12-12 20:35:48.000000000","message":"Correct, I can\u0027t change this since it\u0027s kwargs passed to a virt driver. We could break the virt driver interface for anything that\u0027s not in-tree, but I figured I\u0027d deal with that some other time. That\u0027s why I added the TODO.","commit_id":"de0157b643eea2fc394aae15662319ae6485ba65"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4bef4a639b1f1ce5b569b5053033cf9fa6e4611c","unresolved":false,"context_lines":[{"line_number":2660,"context_line":"                              injected_files, admin_password, bdms,"},{"line_number":2661,"context_line":"                              detach_block_devices, attach_block_devices,"},{"line_number":2662,"context_line":"                              network_info\u003dNone,"},{"line_number":2663,"context_line":"                              recreate\u003dFalse, block_device_info\u003dNone,"},{"line_number":2664,"context_line":"                              preserve_ephemeral\u003dFalse):"},{"line_number":2665,"context_line":"        if preserve_ephemeral:"},{"line_number":2666,"context_line":"            # The default code path does not support preserving ephemeral"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_11b282e7","line":2663,"range":{"start_line":2663,"start_character":30,"end_line":2663,"end_character":38},"in_reply_to":"5f4e5783_d17d0a1d","updated":"2017-10-11 09:59:28.000000000","message":"wrong thought, it should be kept and may consider change later....","commit_id":"de0157b643eea2fc394aae15662319ae6485ba65"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3bd6f54f55ab4a5573b440eb63e2f7689453d0f2","unresolved":false,"context_lines":[{"line_number":2885,"context_line":"                            \" storage\"))"},{"line_number":2886,"context_line":""},{"line_number":2887,"context_line":"            if on_shared_storage:"},{"line_number":2888,"context_line":"                LOG.info(\u0027disk on shared storage, recreating using\u0027"},{"line_number":2889,"context_line":"                         \u0027 existing disk\u0027)"},{"line_number":2890,"context_line":"            else:"},{"line_number":2891,"context_line":"                image_ref \u003d orig_image_ref \u003d instance.image_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_f9ae4d7f","line":2888,"range":{"start_line":2888,"start_character":50,"end_line":2888,"end_character":60},"updated":"2017-10-09 09:33:01.000000000","message":"evacuating?","commit_id":"de0157b643eea2fc394aae15662319ae6485ba65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c6dd54bed5b4c043d3b45a9cd6a66c86e463d71","unresolved":false,"context_lines":[{"line_number":2885,"context_line":"                            \" storage\"))"},{"line_number":2886,"context_line":""},{"line_number":2887,"context_line":"            if on_shared_storage:"},{"line_number":2888,"context_line":"                LOG.info(\u0027disk on shared storage, recreating using\u0027"},{"line_number":2889,"context_line":"                         \u0027 existing disk\u0027)"},{"line_number":2890,"context_line":"            else:"},{"line_number":2891,"context_line":"                image_ref \u003d orig_image_ref \u003d instance.image_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_41b5d2cc","line":2888,"range":{"start_line":2888,"start_character":50,"end_line":2888,"end_character":60},"in_reply_to":"5f4e5783_71d776ef","updated":"2017-12-12 20:35:48.000000000","message":"Will change.","commit_id":"de0157b643eea2fc394aae15662319ae6485ba65"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4bef4a639b1f1ce5b569b5053033cf9fa6e4611c","unresolved":false,"context_lines":[{"line_number":2885,"context_line":"                            \" storage\"))"},{"line_number":2886,"context_line":""},{"line_number":2887,"context_line":"            if on_shared_storage:"},{"line_number":2888,"context_line":"                LOG.info(\u0027disk on shared storage, recreating using\u0027"},{"line_number":2889,"context_line":"                         \u0027 existing disk\u0027)"},{"line_number":2890,"context_line":"            else:"},{"line_number":2891,"context_line":"                image_ref \u003d orig_image_ref \u003d instance.image_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_71d776ef","line":2888,"range":{"start_line":2888,"start_character":50,"end_line":2888,"end_character":60},"in_reply_to":"7f515b1d_f9ae4d7f","updated":"2017-10-11 09:59:28.000000000","message":"+1","commit_id":"de0157b643eea2fc394aae15662319ae6485ba65"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4bef4a639b1f1ce5b569b5053033cf9fa6e4611c","unresolved":false,"context_lines":[{"line_number":2889,"context_line":"                         \u0027 existing disk\u0027)"},{"line_number":2890,"context_line":"            else:"},{"line_number":2891,"context_line":"                image_ref \u003d orig_image_ref \u003d instance.image_ref"},{"line_number":2892,"context_line":"                LOG.info(\"disk not on shared storage, rebuilding from:\""},{"line_number":2893,"context_line":"                         \" \u0027%s\u0027\", str(image_ref))"},{"line_number":2894,"context_line":""},{"line_number":2895,"context_line":"        if image_ref:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_d1f98a80","line":2892,"range":{"start_line":2892,"start_character":54,"end_line":2892,"end_character":64},"updated":"2017-10-11 09:59:28.000000000","message":"evacuate flag \u003d true, why rebuilding?","commit_id":"de0157b643eea2fc394aae15662319ae6485ba65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c6dd54bed5b4c043d3b45a9cd6a66c86e463d71","unresolved":false,"context_lines":[{"line_number":2889,"context_line":"                         \u0027 existing disk\u0027)"},{"line_number":2890,"context_line":"            else:"},{"line_number":2891,"context_line":"                image_ref \u003d orig_image_ref \u003d instance.image_ref"},{"line_number":2892,"context_line":"                LOG.info(\"disk not on shared storage, rebuilding from:\""},{"line_number":2893,"context_line":"                         \" \u0027%s\u0027\", str(image_ref))"},{"line_number":2894,"context_line":""},{"line_number":2895,"context_line":"        if image_ref:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_e1c9865a","line":2892,"range":{"start_line":2892,"start_character":54,"end_line":2892,"end_character":64},"in_reply_to":"5f4e5783_d1f98a80","updated":"2017-12-12 20:35:48.000000000","message":"I\u0027ll update this as well.","commit_id":"de0157b643eea2fc394aae15662319ae6485ba65"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"437c533dc9bee5a834ffaec8a80595c2f889c0b7","unresolved":false,"context_lines":[{"line_number":2756,"context_line":"                              injected_files, admin_password, allocations,"},{"line_number":2757,"context_line":"                              bdms, detach_block_devices, attach_block_devices,"},{"line_number":2758,"context_line":"                              network_info\u003dNone,"},{"line_number":2759,"context_line":"                              recreate\u003dFalse, block_device_info\u003dNone,"},{"line_number":2760,"context_line":"                              preserve_ephemeral\u003dFalse):"},{"line_number":2761,"context_line":"        if preserve_ephemeral:"},{"line_number":2762,"context_line":"            # The default code path does not support preserving ephemeral"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_a3192a89","line":2759,"range":{"start_line":2759,"start_character":30,"end_line":2759,"end_character":38},"updated":"2018-02-05 16:45:39.000000000","message":"Should we also rename this?","commit_id":"6efcb0545ffb0204f4fc7ef56e2761e57225b536"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e40fab5ecc880cc9639b98a2ea760584c00737ab","unresolved":false,"context_lines":[{"line_number":2756,"context_line":"                              injected_files, admin_password, allocations,"},{"line_number":2757,"context_line":"                              bdms, detach_block_devices, attach_block_devices,"},{"line_number":2758,"context_line":"                              network_info\u003dNone,"},{"line_number":2759,"context_line":"                              recreate\u003dFalse, block_device_info\u003dNone,"},{"line_number":2760,"context_line":"                              preserve_ephemeral\u003dFalse):"},{"line_number":2761,"context_line":"        if preserve_ephemeral:"},{"line_number":2762,"context_line":"            # The default code path does not support preserving ephemeral"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_d53669b5","line":2759,"range":{"start_line":2759,"start_character":30,"end_line":2759,"end_character":38},"in_reply_to":"3fa0c359_55c5798d","updated":"2018-02-05 16:53:05.000000000","message":"https://review.openstack.org/#/c/508190/2/nova/compute/manager.py@2663","commit_id":"6efcb0545ffb0204f4fc7ef56e2761e57225b536"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ef135fc837cb1fe5fcc80ff51f8109023d5969c","unresolved":false,"context_lines":[{"line_number":2756,"context_line":"                              injected_files, admin_password, allocations,"},{"line_number":2757,"context_line":"                              bdms, detach_block_devices, attach_block_devices,"},{"line_number":2758,"context_line":"                              network_info\u003dNone,"},{"line_number":2759,"context_line":"                              recreate\u003dFalse, block_device_info\u003dNone,"},{"line_number":2760,"context_line":"                              preserve_ephemeral\u003dFalse):"},{"line_number":2761,"context_line":"        if preserve_ephemeral:"},{"line_number":2762,"context_line":"            # The default code path does not support preserving ephemeral"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_55c5798d","line":2759,"range":{"start_line":2759,"start_character":30,"end_line":2759,"end_character":38},"in_reply_to":"3fa0c359_a3192a89","updated":"2018-02-05 16:52:21.000000000","message":"I\u0027m pretty sure I answered this in an earlier review comment.","commit_id":"6efcb0545ffb0204f4fc7ef56e2761e57225b536"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e469640ea2b4980e9b90a4bc740b2f823d6ddf6d","unresolved":false,"context_lines":[{"line_number":2756,"context_line":"                              injected_files, admin_password, allocations,"},{"line_number":2757,"context_line":"                              bdms, detach_block_devices, attach_block_devices,"},{"line_number":2758,"context_line":"                              network_info\u003dNone,"},{"line_number":2759,"context_line":"                              recreate\u003dFalse, block_device_info\u003dNone,"},{"line_number":2760,"context_line":"                              preserve_ephemeral\u003dFalse):"},{"line_number":2761,"context_line":"        if preserve_ephemeral:"},{"line_number":2762,"context_line":"            # The default code path does not support preserving ephemeral"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_9559c1ff","line":2759,"range":{"start_line":2759,"start_character":30,"end_line":2759,"end_character":38},"in_reply_to":"3fa0c359_d53669b5","updated":"2018-02-05 16:53:56.000000000","message":"Indeed you did, apologies.","commit_id":"6efcb0545ffb0204f4fc7ef56e2761e57225b536"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"437c533dc9bee5a834ffaec8a80595c2f889c0b7","unresolved":false,"context_lines":[{"line_number":2763,"context_line":"            # partitions."},{"line_number":2764,"context_line":"            raise exception.PreserveEphemeralNotSupported()"},{"line_number":2765,"context_line":""},{"line_number":2766,"context_line":"        if recreate:"},{"line_number":2767,"context_line":"            detach_block_devices(context, bdms)"},{"line_number":2768,"context_line":"        else:"},{"line_number":2769,"context_line":"            self._power_off_instance(context, instance, clean_shutdown\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_c31eb66f","line":2766,"range":{"start_line":2766,"start_character":11,"end_line":2766,"end_character":19},"updated":"2018-02-05 16:45:39.000000000","message":"Ditto","commit_id":"6efcb0545ffb0204f4fc7ef56e2761e57225b536"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"6f2e914f4db58252bf3d813742a42b7d2305bb60","unresolved":false,"context_lines":[{"line_number":2763,"context_line":"            # partitions."},{"line_number":2764,"context_line":"            raise exception.PreserveEphemeralNotSupported()"},{"line_number":2765,"context_line":""},{"line_number":2766,"context_line":"        if recreate:"},{"line_number":2767,"context_line":"            detach_block_devices(context, bdms)"},{"line_number":2768,"context_line":"        else:"},{"line_number":2769,"context_line":"            self._power_off_instance(context, instance, clean_shutdown\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_d5a0a9a8","line":2766,"range":{"start_line":2766,"start_character":11,"end_line":2766,"end_character":19},"in_reply_to":"3fa0c359_b52cfd47","updated":"2018-02-05 16:58:54.000000000","message":"Had my first point been right it would have changed this variable as well. As it stands... I guess a comment? But just leaving as it is perfectly fine too :)","commit_id":"6efcb0545ffb0204f4fc7ef56e2761e57225b536"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"49b0eeec92e32a5e9bba6f49a1d3276b98f4342d","unresolved":false,"context_lines":[{"line_number":2763,"context_line":"            # partitions."},{"line_number":2764,"context_line":"            raise exception.PreserveEphemeralNotSupported()"},{"line_number":2765,"context_line":""},{"line_number":2766,"context_line":"        if recreate:"},{"line_number":2767,"context_line":"            detach_block_devices(context, bdms)"},{"line_number":2768,"context_line":"        else:"},{"line_number":2769,"context_line":"            self._power_off_instance(context, instance, clean_shutdown\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_b52cfd47","line":2766,"range":{"start_line":2766,"start_character":11,"end_line":2766,"end_character":19},"in_reply_to":"3fa0c359_c31eb66f","updated":"2018-02-05 16:55:37.000000000","message":"So you want me to create a local \u0027evacuate\u0027 variable here and use that instead? Because that\u0027s the only thing it would be used for.","commit_id":"6efcb0545ffb0204f4fc7ef56e2761e57225b536"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"812d09dd77b731384deebabc88296055c2e174dc","unresolved":false,"context_lines":[{"line_number":2848,"context_line":"        # recreate\u003dTrue means the instance is being evacuated from a failed"},{"line_number":2849,"context_line":"        # host to a new destination host (this host). The \u0027recreate\u0027 variable"},{"line_number":2850,"context_line":"        # name is confusing, so rename it to evacuate here at the top, which"},{"line_number":2851,"context_line":"        # is simpler than renaming a parameter in an RPC versioned method."},{"line_number":2852,"context_line":"        evacuate \u003d recreate"},{"line_number":2853,"context_line":"        context \u003d context.elevated()"},{"line_number":2854,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_8f65f71f","line":2851,"updated":"2018-02-18 17:08:35.000000000","message":"Ugh, we should have done that in 5.0 :/","commit_id":"2047932796ee4bda4e5d932e8df54dadcf05ee7d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"63c674339d41956a4775141fad3758c6ee27da21","unresolved":false,"context_lines":[{"line_number":2848,"context_line":"        # recreate\u003dTrue means the instance is being evacuated from a failed"},{"line_number":2849,"context_line":"        # host to a new destination host (this host). The \u0027recreate\u0027 variable"},{"line_number":2850,"context_line":"        # name is confusing, so rename it to evacuate here at the top, which"},{"line_number":2851,"context_line":"        # is simpler than renaming a parameter in an RPC versioned method."},{"line_number":2852,"context_line":"        evacuate \u003d recreate"},{"line_number":2853,"context_line":"        context \u003d context.elevated()"},{"line_number":2854,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_202129fc","line":2851,"in_reply_to":"3fa0c359_8f65f71f","updated":"2018-02-20 15:19:13.000000000","message":"Yeah, didn\u0027t think about this patch. I\u0027ve been rebasing it for a few months.","commit_id":"2047932796ee4bda4e5d932e8df54dadcf05ee7d"}]}