)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21d1ab7c9ae7e4b1e0fa7f58eea5a18b398d32c8","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"                # UUID and not the instance UUID. The scheduler will"},{"line_number":1076,"context_line":"                # allocate the resources for the destination host to the"},{"line_number":1077,"context_line":"                # instance UUID."},{"line_number":1078,"context_line":"                LOG.debug(\"We\u0027re on a compute host in a deployment that only \""},{"line_number":1079,"context_line":"                          \"has compute hosts from a release later than Pike. \""},{"line_number":1080,"context_line":"                          \"Skipping auto-correction of allocations.\")"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"            # new instance, update compute node resource usage:"},{"line_number":1083,"context_line":"            self._update_usage(self._get_usage_dict(instance), nodename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_57ea89d7","side":"PARENT","line":1080,"range":{"start_line":1078,"start_character":16,"end_line":1080,"end_character":69},"updated":"2017-10-17 17:17:42.000000000","message":"The _update_usage_from_instance method is called from other places in the ResourceTracker, but reading the comment above it says, \"**during the periodic update_available_resource() call**\", so I guess the implication here is that we should only log this during the update_available_resource periodic task, and moving this message to _update_usage_from_instances is OK.\n\nThis was also called from instance_claim and abort_instance_claim, which didn\u0027t pass in a value for has_ocata_computes so that would default to False and we\u0027d be logging this message for all instance claim/abort instance claim calls, which was probably unnecessary. The \"auto-correction\" bit was really about the periodic task \"healing\" allocations and overwriting what the scheduler did.","commit_id":"a5e918d1d9efac1ab72754523cf9dedb840e6ebb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a2f8bd458851233a55f7d62976ad956c90c4f11c","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        compute_version \u003d objects.Service.get_minimum_version("},{"line_number":1130,"context_line":"            context, \u0027nova-compute\u0027)"},{"line_number":1131,"context_line":"        has_ocata_computes \u003d compute_version \u003c 22"},{"line_number":1132,"context_line":"        first \u003d True"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"        for instance in instances:"},{"line_number":1135,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_e8162ba8","line":1132,"updated":"2017-10-01 19:54:51.000000000","message":"Can you use a more explicit name here? First what?","commit_id":"2bf3969f76906cb32fd9422afadc838ba9bd7657"},{"author":{"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},"change_message_id":"3343f28baf9cd4285258dabc770fa4fa8a1535f8","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        compute_version \u003d objects.Service.get_minimum_version("},{"line_number":1130,"context_line":"            context, \u0027nova-compute\u0027)"},{"line_number":1131,"context_line":"        has_ocata_computes \u003d compute_version \u003c 22"},{"line_number":1132,"context_line":"        first \u003d True"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"        for instance in instances:"},{"line_number":1135,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_c158c557","line":1132,"in_reply_to":"5f4e5783_57bf29a9","updated":"2017-10-18 12:53:15.000000000","message":"Done","commit_id":"2bf3969f76906cb32fd9422afadc838ba9bd7657"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21d1ab7c9ae7e4b1e0fa7f58eea5a18b398d32c8","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        compute_version \u003d objects.Service.get_minimum_version("},{"line_number":1130,"context_line":"            context, \u0027nova-compute\u0027)"},{"line_number":1131,"context_line":"        has_ocata_computes \u003d compute_version \u003c 22"},{"line_number":1132,"context_line":"        first \u003d True"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"        for instance in instances:"},{"line_number":1135,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_57bf29a9","line":1132,"in_reply_to":"7f515b1d_e8162ba8","updated":"2017-10-17 17:17:42.000000000","message":"Maybe call it \"auto_heal_msg_logged\" or \"skip_auto_heal_msg\"?","commit_id":"2bf3969f76906cb32fd9422afadc838ba9bd7657"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"637cccb78a9f32bed809243e243afb7c2743b18d","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"                                          \"compute host version \u003c16 (Ocata \""},{"line_number":1140,"context_line":"                                          \"or earlier). \""},{"line_number":1141,"context_line":"            msg_allocation_refresh +\u003d \"Will auto-correct allocations to \""},{"line_number":1142,"context_line":"                                      \"handle Ocata-style assumptions.\")"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        for instance in instances:"},{"line_number":1145,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_1c77f7a2","line":1142,"range":{"start_line":1142,"start_character":71,"end_line":1142,"end_character":72},"updated":"2017-10-23 13:13:31.000000000","message":"There is no opening parenthesis for this.","commit_id":"890d66c688b14f0c56bb295e4708a23068104028"},{"author":{"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},"change_message_id":"aa32c82903b92971ace91b00438b1707d0911ab8","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"                                          \"compute host version \u003c16 (Ocata \""},{"line_number":1140,"context_line":"                                          \"or earlier). \""},{"line_number":1141,"context_line":"            msg_allocation_refresh +\u003d \"Will auto-correct allocations to \""},{"line_number":1142,"context_line":"                                      \"handle Ocata-style assumptions.\")"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        for instance in instances:"},{"line_number":1145,"context_line":"            if instance.vm_state not in vm_states.ALLOW_RESOURCE_REMOVAL:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_dcb6fffa","line":1142,"range":{"start_line":1142,"start_character":71,"end_line":1142,"end_character":72},"in_reply_to":"3f4b6375_1c77f7a2","updated":"2017-10-23 13:22:23.000000000","message":"Done","commit_id":"890d66c688b14f0c56bb295e4708a23068104028"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"6d88aceac69499888d916a390848ef2a370fd8f5","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"                # UUID and not the instance UUID. The scheduler will"},{"line_number":1063,"context_line":"                # allocate the resources for the destination host to the"},{"line_number":1064,"context_line":"                # instance UUID."},{"line_number":1065,"context_line":"                LOG.debug(\"We\u0027re on a Pike compute host in a deployment \""},{"line_number":1066,"context_line":"                          \"with all Pike compute hosts. Skipping \""},{"line_number":1067,"context_line":"                          \"auto-correction of allocations.\")"},{"line_number":1068,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_3949d531","side":"PARENT","line":1065,"range":{"start_line":1065,"start_character":15,"end_line":1065,"end_character":29},"updated":"2017-11-30 21:06:04.000000000","message":"Instead of deleting this, it would be better to log it once, using a flag at init.","commit_id":"8d21d711000fff80eb367692b157d09b6532923f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f87557547e1d834328784133f93e6ca364ac9f73","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"                # UUID and not the instance UUID. The scheduler will"},{"line_number":1063,"context_line":"                # allocate the resources for the destination host to the"},{"line_number":1064,"context_line":"                # instance UUID."},{"line_number":1065,"context_line":"                LOG.debug(\"We\u0027re on a Pike compute host in a deployment \""},{"line_number":1066,"context_line":"                          \"with all Pike compute hosts. Skipping \""},{"line_number":1067,"context_line":"                          \"auto-correction of allocations.\")"},{"line_number":1068,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_2fdc2773","side":"PARENT","line":1065,"range":{"start_line":1065,"start_character":15,"end_line":1065,"end_character":29},"in_reply_to":"ff82abbf_3949d531","updated":"2017-12-02 02:15:36.000000000","message":"I\u0027d be fine with doing that in a follow up change. As it stands, we get this logged 396 times in a CI run today:\n\nhttp://logs.openstack.org/48/524748/1/check/legacy-tempest-dsvm-neutron-full/4c06af6/logs/screen-n-cpu.txt.gz\n\nWith this change, we only log the new thing 35 times:\n\nhttp://logs.openstack.org/62/508262/6/check/legacy-tempest-dsvm-neutron-full/63706e6/logs/screen-n-cpu.txt.gz\n\nWhich is a big improvement since it only gets logged during the periodic task that runs every minute, instead of all the time everytime we do anything with allocations.\n\nSo I\u0027m good with cleaning this up and getting the simple thing in and merged/backported, then optimize later.","commit_id":"8d21d711000fff80eb367692b157d09b6532923f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d1227f3d6e0ef518cc053f6ce5a5fe0116d1fa22","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"            self.driver.requires_allocation_refresh)"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        msg_allocation_refresh \u003d ("},{"line_number":1126,"context_line":"            \"Compute driver doesn\u0027t require allcation refresh and we\u0027re on a \""},{"line_number":1127,"context_line":"            \"compute host in a deployment that only has compute hosts with \""},{"line_number":1128,"context_line":"            \"Nova versions \u003e\u003d16 (Pike). Skipping auto-correction of \""},{"line_number":1129,"context_line":"            \"allocations. \")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_6e1a98cc","line":1126,"range":{"start_line":1126,"start_character":44,"end_line":1126,"end_character":53},"updated":"2017-11-27 16:33:02.000000000","message":"allocation","commit_id":"c6a008cbc523e83c374034623aa67a5955acc8cc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f87557547e1d834328784133f93e6ca364ac9f73","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"            msg_allocation_refresh \u003d \"\""},{"line_number":1132,"context_line":"            if self.driver.requires_allocation_refresh:"},{"line_number":1133,"context_line":"                msg_allocation_refresh +\u003d ("},{"line_number":1134,"context_line":"                    \"Compute driver requires allocation refresh. \")"},{"line_number":1135,"context_line":"            if has_ocata_computes:"},{"line_number":1136,"context_line":"                msg_allocation_refresh +\u003d ("},{"line_number":1137,"context_line":"                    \"We\u0027re on a compute host from Nova version \u003e\u003d16 (Pike or \""}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_ef62bfd8","line":1134,"updated":"2017-12-02 02:15:36.000000000","message":"This is what this looks like in the ironic job:\n\nhttp://logs.openstack.org/62/508262/6/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/a11f286/logs/screen-n-cpu.txt.gz#_Oct_23_15_33_43_104049\n\n\"Compute driver requires allocation refresh. Will auto-correct allocations to handle Ocata-style assumptions.\"","commit_id":"c6a008cbc523e83c374034623aa67a5955acc8cc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46f742c0ccd198f5c4498ad62f6e9b8c33c86f53","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"            if self.driver.requires_allocation_refresh:"},{"line_number":1133,"context_line":"                msg_allocation_refresh +\u003d ("},{"line_number":1134,"context_line":"                    \"Compute driver requires allocation refresh. \")"},{"line_number":1135,"context_line":"            if has_ocata_computes:"},{"line_number":1136,"context_line":"                msg_allocation_refresh +\u003d ("},{"line_number":1137,"context_line":"                    \"We\u0027re on a compute host from Nova version \u003e\u003d16 (Pike or \""},{"line_number":1138,"context_line":"                    \"later) in a deployment with at least one compute host \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_a1f82949","line":1135,"updated":"2017-10-27 22:59:28.000000000","message":"I just thought about this, but if msg_allocation_refresh is set because self.driver.requires_allocation_refresh, then do we really need to log both messages? We wouldn\u0027t today, but this would make us log both. Seems we only need one or the other.","commit_id":"c6a008cbc523e83c374034623aa67a5955acc8cc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f87557547e1d834328784133f93e6ca364ac9f73","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"                    \"Compute driver requires allocation refresh. \")"},{"line_number":1135,"context_line":"            if has_ocata_computes:"},{"line_number":1136,"context_line":"                msg_allocation_refresh +\u003d ("},{"line_number":1137,"context_line":"                    \"We\u0027re on a compute host from Nova version \u003e\u003d16 (Pike or \""},{"line_number":1138,"context_line":"                    \"later) in a deployment with at least one compute host \""},{"line_number":1139,"context_line":"                    \"version \u003c16 (Ocata or earlier). \")"},{"line_number":1140,"context_line":"            msg_allocation_refresh +\u003d ("},{"line_number":1141,"context_line":"                \"Will auto-correct allocations to handle \""},{"line_number":1142,"context_line":"                \"Ocata-style assumptions.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_af835756","line":1139,"range":{"start_line":1137,"start_character":20,"end_line":1139,"end_character":54},"updated":"2017-12-02 02:15:36.000000000","message":"This will make sense in our upstream CI if/when we backport this patch to stable/pike. Right now we don\u0027t see this in our grenade multi-node job because the old compute is Pike, so we don\u0027t get this part.","commit_id":"c6a008cbc523e83c374034623aa67a5955acc8cc"}]}