)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a8f8eeaf4a3a5b85a9cd002d306c472527dfcb1c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"OPTION 1 (this change set) does version discovery and validation via"},{"line_number":18,"context_line":"ksa."},{"line_number":19,"context_line":"OPTION 2 (link forthcoming) uses the adapter to populate the service"},{"line_number":20,"context_line":"parameters and does version discovery the old way."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: If5b53fe1bf99d9983baddc0db266754e2e044519"},{"line_number":23,"context_line":"Partial-Implements: bp use-ksa-adapter-for-endpoints"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_0f72c2ad","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":50},"updated":"2017-09-29 14:57:25.000000000","message":"Nah, as I continued working on this, it became clear that this way was better.","commit_id":"feb1013f8e9d133f264367c2eea2041b7d31af92"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"901e738c5c8a77e2a97388416ae791eca65bebb8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"consistent mechanism for endpoint communication from Nova."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If5b53fe1bf99d9983baddc0db266754e2e044519"},{"line_number":19,"context_line":"Partial-Implements: bp use-ksa-adapter-for-endpoints"},{"line_number":20,"context_line":"Add version discovery support to BaseAuthPlugin:"},{"line_number":21,"context_line":"Depends-On: Id9bd19cca68206fc64d23b0eaa95aa3e5b01b676"},{"line_number":22,"context_line":"Add block-storage endpoint (devstack)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"df7087c5_d742210f","line":19,"updated":"2018-03-15 16:47:50.000000000","message":"This is closed since queens so we should probably remove this now and just consider it cleanup work without another blueprint for rocky.","commit_id":"692cbfb54930e49274c76af9b01e494b1ddae93d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"901e738c5c8a77e2a97388416ae791eca65bebb8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If5b53fe1bf99d9983baddc0db266754e2e044519"},{"line_number":19,"context_line":"Partial-Implements: bp use-ksa-adapter-for-endpoints"},{"line_number":20,"context_line":"Add version discovery support to BaseAuthPlugin:"},{"line_number":21,"context_line":"Depends-On: Id9bd19cca68206fc64d23b0eaa95aa3e5b01b676"},{"line_number":22,"context_line":"Add block-storage endpoint (devstack)"},{"line_number":23,"context_line":"Depends-On: I75cf7212678f7f270c3c32f0bce227dbbf6b466d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"df7087c5_77c8f5a4","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":53},"updated":"2018-03-15 16:47:50.000000000","message":"These can be removed now since they are both merged and the ksa change went into 3.3.0 and g-r requires \u003e\u003d3.4.0 now.","commit_id":"692cbfb54930e49274c76af9b01e494b1ddae93d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eb429d4daafd3205030cf7eb26f1de13ba28e557","unresolved":false,"context_lines":[{"line_number":16,"context_line":"completed in Queens except for this change, this provides a"},{"line_number":17,"context_line":"consistent mechanism for endpoint communication from Nova."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1752152"},{"line_number":20,"context_line":"Change-Id: If5b53fe1bf99d9983baddc0db266754e2e044519"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"bf659307_5a6d3430","line":19,"updated":"2018-03-28 17:52:59.000000000","message":"This isn\u0027t going to be backportable for this bug, so we need a workaround, maybe that\u0027s just using KSA directly to get the version document (as mentioned in the bug), backport that, and then replace all of that code with this patch in master.","commit_id":"8e96e9e9fd869948b2aa378c7e54a2e6825fd295"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"09975b7833f9f71fd1302f23822a86b7c7b43fb4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"completed in Queens except for this change, this provides a"},{"line_number":17,"context_line":"consistent mechanism for endpoint communication from Nova."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1752152"},{"line_number":20,"context_line":"Change-Id: If5b53fe1bf99d9983baddc0db266754e2e044519"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3f79a3b5_c0da2be6","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":20},"updated":"2018-11-29 16:23:15.000000000","message":"This is closed already so we should probably replace this with bug 1803627.","commit_id":"70259436ad22c238513e182af26157594147acc1"}],"nova/conf/cinder.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"252791472ed8a5669d7cdaa3784fafbb6383ef31","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027catalog_info\u0027,"},{"line_number":32,"context_line":"            sample_default\u003d\u0027volumev3:cinderv3:publicURL\u0027,"},{"line_number":33,"context_line":"            regex\u003d\u0027(\\w+):(\\w+):(.*?)\u0027,"},{"line_number":34,"context_line":"            deprecated_for_removal\u003dTrue,"},{"line_number":35,"context_line":"            deprecated_reason\u003d\u0027Endpoint lookup uses the service catalog via \u0027"},{"line_number":36,"context_line":"                              \u0027common keystoneauth1 Adapter configuration \u0027"},{"line_number":37,"context_line":"                              \u0027options. In the current release, catalog_info \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_6ed22337","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":39},"updated":"2017-10-10 03:19:48.000000000","message":"can we add deprecated_since to indicate the deprecate time?","commit_id":"8f2b805c621772b7d95389a7999b94bd89b986ae"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a32a3defc2f7e412e3b70ebcab622dfd7d35282f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    cfg.StrOpt(\u0027catalog_info\u0027,"},{"line_number":32,"context_line":"            sample_default\u003d\u0027volumev3:cinderv3:publicURL\u0027,"},{"line_number":33,"context_line":"            regex\u003d\u0027(\\w+):(\\w+):(.*?)\u0027,"},{"line_number":34,"context_line":"            deprecated_for_removal\u003dTrue,"},{"line_number":35,"context_line":"            deprecated_reason\u003d\u0027Endpoint lookup uses the service catalog via \u0027"},{"line_number":36,"context_line":"                              \u0027common keystoneauth1 Adapter configuration \u0027"},{"line_number":37,"context_line":"                              \u0027options. In the current release, catalog_info \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_1c9f5b51","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":39},"in_reply_to":"5f4e5783_6ed22337","updated":"2017-10-10 13:22:44.000000000","message":"Done","commit_id":"8f2b805c621772b7d95389a7999b94bd89b986ae"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"252791472ed8a5669d7cdaa3784fafbb6383ef31","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* endpoint_template - Setting this option will override catalog_info."},{"line_number":58,"context_line":"* service_type - The preferred mechanism for overriding the default service"},{"line_number":59,"context_line":"  type."},{"line_number":60,"context_line":"* service_name - The preferred mechanism for overriding the default service"},{"line_number":61,"context_line":"  name."},{"line_number":62,"context_line":"* valid_interfaces - The preferred mechanism for overriding the"},{"line_number":63,"context_line":"  default list of endpoint types to try."},{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027endpoint_template\u0027,"},{"line_number":66,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_4ed76725","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":40},"updated":"2017-10-10 03:19:48.000000000","message":"I don\u0027t see options here ....where do we add them ?","commit_id":"8f2b805c621772b7d95389a7999b94bd89b986ae"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a32a3defc2f7e412e3b70ebcab622dfd7d35282f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* endpoint_template - Setting this option will override catalog_info."},{"line_number":58,"context_line":"* service_type - The preferred mechanism for overriding the default service"},{"line_number":59,"context_line":"  type."},{"line_number":60,"context_line":"* service_name - The preferred mechanism for overriding the default service"},{"line_number":61,"context_line":"  name."},{"line_number":62,"context_line":"* valid_interfaces - The preferred mechanism for overriding the"},{"line_number":63,"context_line":"  default list of endpoint types to try."},{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027endpoint_template\u0027,"},{"line_number":66,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_7ca40f09","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":40},"in_reply_to":"5f4e5783_4ed76725","updated":"2017-10-10 13:22:44.000000000","message":"They\u0027re come in via keystoneauth1.loading.get_adapter_conf_options, which happens in nova.conf.utils.register_ksa_opts.  It\u0027s confusing, I know.","commit_id":"8f2b805c621772b7d95389a7999b94bd89b986ae"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"656213d95e2ae0bd3517585a5a0f528f7e3bad5d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* endpoint_template - Setting this option will override catalog_info."},{"line_number":58,"context_line":"* service_type - The preferred mechanism for overriding the default service"},{"line_number":59,"context_line":"  type."},{"line_number":60,"context_line":"* service_name - The preferred mechanism for overriding the default service"},{"line_number":61,"context_line":"  name."},{"line_number":62,"context_line":"* valid_interfaces - The preferred mechanism for overriding the"},{"line_number":63,"context_line":"  default list of endpoint types to try."},{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027endpoint_template\u0027,"},{"line_number":66,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_86fd163c","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":40},"in_reply_to":"5f4e5783_7ca40f09","updated":"2017-10-11 09:37:22.000000000","message":"ok, I saw it ,thanks for the link","commit_id":"8f2b805c621772b7d95389a7999b94bd89b986ae"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"252c1745294276abd5da35b08c2e7e83b8a141e1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  endpoint."},{"line_number":92,"context_line":"\"\"\"),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"},{"line_number":94,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":95,"context_line":"               deprecated_reason\u003d\u0027Endpoint lookup uses the service catalog \u0027"},{"line_number":96,"context_line":"                                 \u0027via common keystoneauth1 Adapter \u0027"},{"line_number":97,"context_line":"                                 \u0027configuration options. In the current \u0027"},{"line_number":98,"context_line":"                                 \u0027release, os_region_name will override this \u0027"},{"line_number":99,"context_line":"                                 \u0027behavior, but will be ignored and/or \u0027"},{"line_number":100,"context_line":"                                 \u0027removed in a future release. To achieve the \u0027"},{"line_number":101,"context_line":"                                 \u0027same result, use the region_name option \u0027"},{"line_number":102,"context_line":"                                 \u0027instead.\u0027,"},{"line_number":103,"context_line":"               help\u003d\"\"\""},{"line_number":104,"context_line":"Region name of this node. This is used when picking the URL in the service"},{"line_number":105,"context_line":"catalog."}],"source_content_type":"text/x-python","patch_set":6,"id":"5f4e5783_9c2fcbf5","line":102,"range":{"start_line":94,"start_character":0,"end_line":102,"end_character":44},"updated":"2017-10-10 13:25:55.000000000","message":"This is done via deprecated_opts below.","commit_id":"dfed86d461e0444f3fa51efeefae696d5dcf600c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"eca229ca8ec3bf5e3231138e28805cddce41cfef","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    conf.register_group(cinder_group)"},{"line_number":144,"context_line":"    conf.register_opts(cinder_opts, group\u003dcinder_group)"},{"line_number":145,"context_line":"    confutils.register_ksa_opts(conf, cinder_group, DEFAULT_SERVICE_TYPE,"},{"line_number":146,"context_line":"                                include_auth\u003dFalse,"},{"line_number":147,"context_line":"                                deprecated_opts\u003ddeprecated_opts)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_b4ca484b","line":146,"range":{"start_line":146,"start_character":32,"end_line":146,"end_character":50},"updated":"2017-12-07 18:15:33.000000000","message":"If https://review.openstack.org/#/c/522112 flies, remove this.","commit_id":"692cbfb54930e49274c76af9b01e494b1ddae93d"}],"nova/tests/unit/volume/test_cinder.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dd8d21b4ff492e9d2e879871ad34a905b487fd16","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"        \"\"\"Tests that creating a v3 client, which is the default, and without"},{"line_number":1106,"context_line":"        specifying a microversion will default to 3.0 as the version to use."},{"line_number":1107,"context_line":"        \"\"\""},{"line_number":1108,"context_line":"        self.skipTest(\u0027Figure out why this fails\u0027)"},{"line_number":1109,"context_line":"        client \u003d cinder.cinderclient(self.ctxt)"},{"line_number":1110,"context_line":"        self.assertEqual(cinder_api_versions.APIVersion(\u00273.0\u0027),"},{"line_number":1111,"context_line":"                         client.api_version)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df7087c5_4dde7eda","line":1108,"range":{"start_line":1108,"start_character":8,"end_line":1108,"end_character":50},"updated":"2018-03-15 18:26:41.000000000","message":"help","commit_id":"6a89450400fa83dd364eab129bac70e136e07f05"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0d58f232323c3becfaa3888d31891daa0abc9ca3","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"        \"\"\"Tests that creating a v3 client, which is the default, and without"},{"line_number":1106,"context_line":"        specifying a microversion will default to 3.0 as the version to use."},{"line_number":1107,"context_line":"        \"\"\""},{"line_number":1108,"context_line":"        self.skipTest(\u0027Figure out why this fails\u0027)"},{"line_number":1109,"context_line":"        client \u003d cinder.cinderclient(self.ctxt)"},{"line_number":1110,"context_line":"        self.assertEqual(cinder_api_versions.APIVersion(\u00273.0\u0027),"},{"line_number":1111,"context_line":"                         client.api_version)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf659307_7f5b4a53","line":1108,"range":{"start_line":1108,"start_character":8,"end_line":1108,"end_character":50},"in_reply_to":"df7087c5_4dde7eda","updated":"2018-03-28 17:42:38.000000000","message":"We don\u0027t need the failing assertion (L1113-4).","commit_id":"6a89450400fa83dd364eab129bac70e136e07f05"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f5506ccec124cfbdb5012a8a083b426a4e13e213","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"            min_version\u003d\u00273.0\u0027, max_version\u003dmax_version)"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"    def test_create_v3_client_no_microversion(self):"},{"line_number":1137,"context_line":"        \"\"\"Tests that creating a v3 client, which is the default, and without"},{"line_number":1138,"context_line":"        specifying a microversion will default to 3.0 as the version to use."},{"line_number":1139,"context_line":"        \"\"\""},{"line_number":1140,"context_line":"        client \u003d cinder.cinderclient(self.ctxt)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_20ce7f2a","line":1137,"updated":"2018-11-29 16:25:08.000000000","message":"Pedantic nit: https://www.python.org/dev/peps/pep-0257/#id16","commit_id":"70259436ad22c238513e182af26157594147acc1"}],"nova/volume/cinder.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"d08e74b3213854794a43253e0c33284031621157","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    #               to populate the kwargs to cinder_client.Client"},{"line_number":115,"context_line":"    #               which ultimately uses them to construct..."},{"line_number":116,"context_line":"    #               ...an Adapter."},{"line_number":117,"context_line":"    # This should eventually be unwound, such that we can just hand off the"},{"line_number":118,"context_line":"    # already-built Adapter to the cinder client."},{"line_number":119,"context_line":"    adap \u003d utils.get_ksa_adapter(\u0027block-storage\u0027, ksa_auth\u003dauth,"},{"line_number":120,"context_line":"                                 ksa_session\u003d_SESSION, min_version\u003d\u00273.0\u0027,"},{"line_number":121,"context_line":"                                 max_version\u003dmicroversion or \u00273.latest\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df7087c5_d2b30fe8","line":118,"range":{"start_line":117,"start_character":6,"end_line":118,"end_character":49},"updated":"2018-03-15 17:45:23.000000000","message":"Indeed, I stumbled on this when adding ksa Adapters etc loading to Ironic.\n\nThe thing is, most of clients use their subclasses of ksa Adapter to add custom logic to various methods. Cinder for example adds OverLimit exception handling in the request method and parsing HTTP errors to Python exceptions [0].\n\nSo I see several ways of fixing this:\n- ksa adapter loading may accept an actual class to load instead of built-in default Adapter class\n- Adapter object may accept another adapter instance in __init__ and populate own attributes from this supplied adapter instance - which would require adding a new argument to all client instantiation calls and some rewrite of all clients\u0027 code\n- every client with a subclassed Adapter should provide a loader for this adapter too - again a change in every client project\n\nGiven that we still can not instantiate the custom SessionClient (as it is usually a part of bigger Client object) options 2 and 3 look more doable, with 3 being the easiest (only client code change needed). \n\n[0] http://git.openstack.org/cgit/openstack/python-cinderclient/tree/cinderclient/client.py?id\u003ddf68d53fc59273ea89f33ed191a3cc1a311231e5#n184","commit_id":"692cbfb54930e49274c76af9b01e494b1ddae93d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f5506ccec124cfbdb5012a8a083b426a4e13e213","unresolved":false,"context_lines":[{"line_number":247,"context_line":"def is_microversion_supported(context, microversion):"},{"line_number":248,"context_line":"    # TODO(mriedem): We can remove/replace this with adap.get_endpoint_data()"},{"line_number":249,"context_line":"    # when we remove the legacy code."},{"line_number":250,"context_line":"    _, _, url \u003d _get_cinderclient_parameters(context)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    _check_microversion(context, url, microversion)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_60e557a3","line":250,"range":{"start_line":250,"start_character":3,"end_line":250,"end_character":8},"updated":"2018-11-29 16:25:08.000000000","message":"Probably want to use double underscores so as not to hide the i18n _ import.","commit_id":"70259436ad22c238513e182af26157594147acc1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cdddd1cfcb06c5d5be0c2955ec82da96d02d798e","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    version \u003d microversion or \u00273.0\u0027"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    if not skip_version_check:"},{"line_number":288,"context_line":"        epd \u003d adap.get_endpoint_data()"},{"line_number":289,"context_line":"        # We asked for the (micro)version via the Adapter; if not supported,"},{"line_number":290,"context_line":"        # get_endpoint_data will return None."},{"line_number":291,"context_line":"        if not epd:"},{"line_number":292,"context_line":"            raise exception.CinderAPIVersionNotAvailable(version\u003dversion)"},{"line_number":293,"context_line":"        # Setting endpoint_override at this stage will cut out some repeated"},{"line_number":294,"context_line":"        # discovery the cinder client would otherwise perform when it uses the"},{"line_number":295,"context_line":"        # service parameters to set up its own Adapter."}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_f5cb0419","line":292,"range":{"start_line":287,"start_character":4,"end_line":292,"end_character":73},"updated":"2018-12-04 21:29:54.000000000","message":"I think this is busted:\n\nhttp://logs.openstack.org/45/508345/17/check/tempest-full/32f50a8/controller/logs/screen-n-cpu.txt.gz?level\u003dTRACE#_Nov_29_20_59_44_174438\n\nThe get() method below is passing microversion\u003dNone in this case, and skip_version_check is False (default kwarg value).\n\nThe way skip_version_check used to work, was it would only be used if microversion was not None, but that\u0027s no longer the case here. So I think the logic is supposed to be:\n\nif microversion is not None and not skip_version_check:","commit_id":"e90277b714597fd82ad0be9b43a159159011b259"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a6a3466927917adead749dba2935d1dbcc59f805","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        epd \u003d adap.get_endpoint_data()"},{"line_number":289,"context_line":"        # We asked for the (micro)version via the Adapter; if not supported,"},{"line_number":290,"context_line":"        # get_endpoint_data will return None."},{"line_number":291,"context_line":"        if not epd:"},{"line_number":292,"context_line":"            raise exception.CinderAPIVersionNotAvailable(version\u003dversion)"},{"line_number":293,"context_line":"        # Setting endpoint_override at this stage will cut out some repeated"},{"line_number":294,"context_line":"        # discovery the cinder client would otherwise perform when it uses the"},{"line_number":295,"context_line":"        # service parameters to set up its own Adapter."}],"source_content_type":"text/x-python","patch_set":18,"id":"3f79a3b5_42e77146","line":292,"range":{"start_line":291,"start_character":8,"end_line":292,"end_character":73},"updated":"2018-12-06 14:22:28.000000000","message":"This is failing during a resize test for some reason:\n\nhttp://logs.openstack.org/45/508345/18/check/tempest-full/dc8d23e/controller/logs/screen-n-cpu.txt.gz#_Dec_05_06_05_01_073424\n\nI\u0027m not sure what\u0027s going on...","commit_id":"adac6803600305b125db07b5231efeb8bf84a08f"}]}