)]}'
{"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"865ebd3428cade32da6b60ee941b4db9d08ee1ed","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    def test_list_instance_uuids(self):"},{"line_number":263,"context_line":"        self._create_vm()"},{"line_number":264,"context_line":"        uuids \u003d self.conn.list_instance_uuids()"},{"line_number":265,"context_line":"        self.assertEquals(len(uuids), 1)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_list_instance_uuids_invalid(self):"},{"line_number":268,"context_line":"        self._create_vm(uuid\u003d\u0027fake_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fwtw%3D","line":265,"updated":"2013-10-10 07:36:56.000000000","message":"why still using assertEquals? besides \nassertEqual(self, expected, observed, message\u003d\u0027\u0027):","commit_id":"69a9993bc8deaf026c3ca337500b245f74a42a70"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"975c65ac8d12339fea6290242a0035912daabe55","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    def test_list_instance_uuids(self):"},{"line_number":263,"context_line":"        self._create_vm()"},{"line_number":264,"context_line":"        uuids \u003d self.conn.list_instance_uuids()"},{"line_number":265,"context_line":"        self.assertEquals(len(uuids), 1)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_list_instance_uuids_invalid(self):"},{"line_number":268,"context_line":"        self._create_vm(uuid\u003d\u0027fake_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fwo4%3D","line":265,"in_reply_to":"AAAATH%2F%2Fwtw%3D","updated":"2013-10-10 08:08:16.000000000","message":"my bad. good catch - copy pasted","commit_id":"69a9993bc8deaf026c3ca337500b245f74a42a70"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"865ebd3428cade32da6b60ee941b4db9d08ee1ed","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    def test_list_instance_uuids_invalid(self):"},{"line_number":268,"context_line":"        self._create_vm(uuid\u003d\u0027fake_id\u0027)"},{"line_number":269,"context_line":"        uuids \u003d self.conn.list_instance_uuids()"},{"line_number":270,"context_line":"        self.assertEquals(len(uuids), 0)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_instance_dir_disk_created(self):"},{"line_number":273,"context_line":"        \"\"\"Test image file is cached when even when use_linked_clone"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fwts%3D","line":270,"updated":"2013-10-10 07:36:56.000000000","message":"ditto","commit_id":"69a9993bc8deaf026c3ca337500b245f74a42a70"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"95014c453be15acbcc34e7eb14b2d73b5e43134a","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    def list_instance_uuids(self):"},{"line_number":384,"context_line":"        \"\"\"List VM instance UUIDs.\"\"\""},{"line_number":385,"context_line":"        uuids \u003d self._vmops.list_instances()"},{"line_number":386,"context_line":"        return [uuid for uuid in uuids if uuidutils.is_uuid_like(uuid)]"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"class VMwareVCDriver(VMwareESXDriver):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fndw%3D","line":386,"updated":"2013-10-12 15:29:57.000000000","message":"is that possible that the invalid uuid could be returned? one case which I can imagine are those vm which wasn\u0027t created by openstack, if so is that approprate to swallow it rather than log or something for debugging?","commit_id":"b95d04da7fece3fab684ff70b74c32d0c3ee1de3"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"ad1647d609e67f6eef984fd1693015565a3642e0","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    def list_instance_uuids(self):"},{"line_number":384,"context_line":"        \"\"\"List VM instance UUIDs.\"\"\""},{"line_number":385,"context_line":"        uuids \u003d self._vmops.list_instances()"},{"line_number":386,"context_line":"        return [uuid for uuid in uuids if uuidutils.is_uuid_like(uuid)]"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"class VMwareVCDriver(VMwareESXDriver):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FgXg%3D","line":386,"in_reply_to":"AAAATH%2F%2FnX0%3D","updated":"2013-10-15 09:43:36.000000000","message":"thanks for your explanation, sorry for the late response.","commit_id":"b95d04da7fece3fab684ff70b74c32d0c3ee1de3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"70e586d92567ceeee24230fde1b82de29eaf742f","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    def list_instance_uuids(self):"},{"line_number":384,"context_line":"        \"\"\"List VM instance UUIDs.\"\"\""},{"line_number":385,"context_line":"        uuids \u003d self._vmops.list_instances()"},{"line_number":386,"context_line":"        return [uuid for uuid in uuids if uuidutils.is_uuid_like(uuid)]"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"class VMwareVCDriver(VMwareESXDriver):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FnX0%3D","line":386,"in_reply_to":"AAAATH%2F%2Fndw%3D","updated":"2013-10-12 17:36:34.000000000","message":"vm\u0027s that are created by openstack have a uuid as the name. there may be vm\u0027s that rea no created by openstack. these vms are sorted.\nif there is a vm that is not matched by openstack then i think that this is logged in the application.\ncan you please clarify why this is a problem.","commit_id":"b95d04da7fece3fab684ff70b74c32d0c3ee1de3"}]}
