)]}'
{"nova/compute/api.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"c132f1c5a1b4e1cec496cd87a8fbc69b1ea84792","unresolved":false,"context_lines":[{"line_number":2420,"context_line":""},{"line_number":2421,"context_line":"        return instances"},{"line_number":2422,"context_line":""},{"line_number":2423,"context_line":"    def _do_old_style_instance_list_for_poor_cellsv1_users(self,"},{"line_number":2424,"context_line":"                                                           context, filters,"},{"line_number":2425,"context_line":"                                                           limit, marker,"},{"line_number":2426,"context_line":"                                                           fields,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_2aa17caa","line":2423,"updated":"2017-10-11 14:47:01.000000000","message":"aw","commit_id":"e56fb62d1a7ada1cd6de5f0429f32803d80651d2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"48587488a34740c21abae2648756c909c5d6faf9","unresolved":false,"context_lines":[{"line_number":2377,"context_line":"        # Only subtract from limit if it is not None"},{"line_number":2378,"context_line":"        limit \u003d (limit - len(build_req_instances)) if limit else limit"},{"line_number":2379,"context_line":""},{"line_number":2380,"context_line":"        # We could arguably avoid joining on security_groups if we\u0027re using"},{"line_number":2381,"context_line":"        # neutron (which is the default) but if you\u0027re using neutron then the"},{"line_number":2382,"context_line":"        # security_group_instance_association table should be empty anyway"},{"line_number":2383,"context_line":"        # and the DB should optimize out that join, making it insignificant."},{"line_number":2384,"context_line":"        fields \u003d [\u0027metadata\u0027, \u0027info_cache\u0027, \u0027security_groups\u0027]"},{"line_number":2385,"context_line":"        if expected_attrs:"},{"line_number":2386,"context_line":"            fields.extend(expected_attrs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_e08c29d8","side":"PARENT","line":2383,"range":{"start_line":2380,"start_character":8,"end_line":2383,"end_character":76},"updated":"2017-10-25 14:46:04.000000000","message":"I\u0027m not sure why this comment was removed. It\u0027s not related to the build request stuff.","commit_id":"c3ca8a6256f9b5f3235b65d483099047d50adc6f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8902a3a1033f983c9319d042378703ee02eb1bf6","unresolved":false,"context_lines":[{"line_number":2383,"context_line":"        filter_method \u003d _get_unique_filter_method()"},{"line_number":2384,"context_line":""},{"line_number":2385,"context_line":"        if CONF.cells.enable:"},{"line_number":2386,"context_line":"            # The ordering of instances for people running deprecated"},{"line_number":2387,"context_line":"            # and never-was-supported setups will be [sorted instances"},{"line_number":2388,"context_line":"            # with no host] + [sorted instances with host].  This"},{"line_number":2389,"context_line":"            # means BuildRequest first, then cell instances"},{"line_number":2390,"context_line":"            build_requests \u003d objects.BuildRequestList.get_by_filters("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_642fdff6","line":2387,"range":{"start_line":2386,"start_character":59,"end_line":2387,"end_character":37},"updated":"2017-10-18 14:21:43.000000000","message":"Could you explain this a little more? Without the context I\u0027m not sure what you mean by this. What about the merging of booted instances with unbooted instances (build requests) was not supported by cells v1?","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c8294a794667074fd235467a0ce63e04a89f879c","unresolved":false,"context_lines":[{"line_number":2383,"context_line":"        filter_method \u003d _get_unique_filter_method()"},{"line_number":2384,"context_line":""},{"line_number":2385,"context_line":"        if CONF.cells.enable:"},{"line_number":2386,"context_line":"            # The ordering of instances for people running deprecated"},{"line_number":2387,"context_line":"            # and never-was-supported setups will be [sorted instances"},{"line_number":2388,"context_line":"            # with no host] + [sorted instances with host].  This"},{"line_number":2389,"context_line":"            # means BuildRequest first, then cell instances"},{"line_number":2390,"context_line":"            build_requests \u003d objects.BuildRequestList.get_by_filters("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_909a11c3","line":2387,"range":{"start_line":2386,"start_character":59,"end_line":2387,"end_character":37},"in_reply_to":"3f4b6375_642fdff6","updated":"2017-10-18 14:50:21.000000000","message":"No, I\u0027m referring to cellsv1 in its entirety. It\u0027s always been experimental. This is a passive aggressive jab :)","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8902a3a1033f983c9319d042378703ee02eb1bf6","unresolved":false,"context_lines":[{"line_number":2394,"context_line":"                objects\u003d[build_req.instance for build_req in build_requests])"},{"line_number":2395,"context_line":"            # Only subtract from limit if it is not None"},{"line_number":2396,"context_line":"            limit \u003d (limit - len(build_req_instances)) if limit else limit"},{"line_number":2397,"context_line":"            insts \u003d self._do_old_style_instance_list_for_poor_cellsv1_users("},{"line_number":2398,"context_line":"                context, filters, limit, marker, fields, sort_keys,"},{"line_number":2399,"context_line":"                sort_dirs)"},{"line_number":2400,"context_line":"            instances \u003d objects.InstanceList(objects\u003dlist("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_a444b7b8","line":2397,"range":{"start_line":2397,"start_character":25,"end_line":2397,"end_character":75},"updated":"2017-10-18 14:21:43.000000000","message":"heh","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c8294a794667074fd235467a0ce63e04a89f879c","unresolved":false,"context_lines":[{"line_number":2394,"context_line":"                objects\u003d[build_req.instance for build_req in build_requests])"},{"line_number":2395,"context_line":"            # Only subtract from limit if it is not None"},{"line_number":2396,"context_line":"            limit \u003d (limit - len(build_req_instances)) if limit else limit"},{"line_number":2397,"context_line":"            insts \u003d self._do_old_style_instance_list_for_poor_cellsv1_users("},{"line_number":2398,"context_line":"                context, filters, limit, marker, fields, sort_keys,"},{"line_number":2399,"context_line":"                sort_dirs)"},{"line_number":2400,"context_line":"            instances \u003d objects.InstanceList(objects\u003dlist("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_d0b7693a","line":2397,"range":{"start_line":2397,"start_character":25,"end_line":2397,"end_character":75},"in_reply_to":"3f4b6375_a444b7b8","updated":"2017-10-18 14:50:21.000000000","message":"Not so passive jab here :)","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8902a3a1033f983c9319d042378703ee02eb1bf6","unresolved":false,"context_lines":[{"line_number":2397,"context_line":"            insts \u003d self._do_old_style_instance_list_for_poor_cellsv1_users("},{"line_number":2398,"context_line":"                context, filters, limit, marker, fields, sort_keys,"},{"line_number":2399,"context_line":"                sort_dirs)"},{"line_number":2400,"context_line":"            instances \u003d objects.InstanceList(objects\u003dlist("},{"line_number":2401,"context_line":"                filter(filter_method,"},{"line_number":2402,"context_line":"                       build_req_instances.objects + insts.objects)))"},{"line_number":2403,"context_line":"        else:"},{"line_number":2404,"context_line":"            instances \u003d instance_list.get_instance_objects_sorted("},{"line_number":2405,"context_line":"                context, filters, limit, marker, fields, sort_keys, sort_dirs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_c47573fc","line":2402,"range":{"start_line":2400,"start_character":53,"end_line":2402,"end_character":67},"updated":"2017-10-18 14:21:43.000000000","message":"I know this was copied verbatim from below, but this would be easier to read as a list comprehension. I bet you ndipanov had something to do with this :D","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c8294a794667074fd235467a0ce63e04a89f879c","unresolved":false,"context_lines":[{"line_number":2397,"context_line":"            insts \u003d self._do_old_style_instance_list_for_poor_cellsv1_users("},{"line_number":2398,"context_line":"                context, filters, limit, marker, fields, sort_keys,"},{"line_number":2399,"context_line":"                sort_dirs)"},{"line_number":2400,"context_line":"            instances \u003d objects.InstanceList(objects\u003dlist("},{"line_number":2401,"context_line":"                filter(filter_method,"},{"line_number":2402,"context_line":"                       build_req_instances.objects + insts.objects)))"},{"line_number":2403,"context_line":"        else:"},{"line_number":2404,"context_line":"            instances \u003d instance_list.get_instance_objects_sorted("},{"line_number":2405,"context_line":"                context, filters, limit, marker, fields, sort_keys, sort_dirs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_d0908998","line":2402,"range":{"start_line":2400,"start_character":53,"end_line":2402,"end_character":67},"in_reply_to":"3f4b6375_c47573fc","updated":"2017-10-18 14:50:21.000000000","message":"Well, trying to avoid changing more than necessary here so it\u0027s clear that I\u0027m just adding the build requests in. It\u0027d be a fine topic for follow-up refactor though.","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"}],"nova/compute/instance_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"48587488a34740c21abae2648756c909c5d6faf9","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class InstanceWrapper(object):"},{"line_number":59,"context_line":"    \"\"\"Wrap an instance object from the database so it is sortable."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    We use heapq.merge() below to do the merge sort of things from the"},{"line_number":62,"context_line":"    cell databases. That routine assumes it can use regular python"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_3b14b243","line":59,"range":{"start_line":59,"start_character":31,"end_line":59,"end_character":48},"updated":"2017-10-25 14:46:04.000000000","message":"nit: not necessarily now","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"20ddb5856bf4f9ef78cd1ed53d7d9ec217c9997a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class InstanceWrapper(object):"},{"line_number":59,"context_line":"    \"\"\"Wrap an instance object from the database so it is sortable."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    We use heapq.merge() below to do the merge sort of things from the"},{"line_number":62,"context_line":"    cell databases. That routine assumes it can use regular python"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_1b49f62f","line":59,"range":{"start_line":59,"start_character":31,"end_line":59,"end_character":48},"in_reply_to":"3f4b6375_3b14b243","updated":"2017-10-25 14:54:07.000000000","message":"It\u0027s important that this wraps a db-like instance, not an objects.Instance","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"48587488a34740c21abae2648756c909c5d6faf9","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    sort_ctx \u003d InstanceSortContext(sort_keys, sort_dirs)"},{"line_number":271,"context_line":"    build_requests \u003d objects.BuildRequestList.get_by_filters("},{"line_number":272,"context_line":"        ctx, filters, limit\u003dlimit, marker\u003dmarker, sort_keys\u003dsort_keys,"},{"line_number":273,"context_line":"        sort_dirs\u003dsort_dirs)"},{"line_number":274,"context_line":"    br_inst_generator \u003d (InstanceWrapper(sort_ctx, br.instance)"},{"line_number":275,"context_line":"                         for br in build_requests)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_3b6b92b7","line":272,"range":{"start_line":272,"start_character":22,"end_line":272,"end_character":33},"updated":"2017-10-25 14:46:04.000000000","message":"Should we be modifying the limit based on what we got back from get_instances_sorted before getting build requests? Or we get $limit sorted instances from the cells, and $limit sorted build requests, and then merge them, re-sort and apply the limit?","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"20ddb5856bf4f9ef78cd1ed53d7d9ec217c9997a","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    sort_ctx \u003d InstanceSortContext(sort_keys, sort_dirs)"},{"line_number":271,"context_line":"    build_requests \u003d objects.BuildRequestList.get_by_filters("},{"line_number":272,"context_line":"        ctx, filters, limit\u003dlimit, marker\u003dmarker, sort_keys\u003dsort_keys,"},{"line_number":273,"context_line":"        sort_dirs\u003dsort_dirs)"},{"line_number":274,"context_line":"    br_inst_generator \u003d (InstanceWrapper(sort_ctx, br.instance)"},{"line_number":275,"context_line":"                         for br in build_requests)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_7b0c6aeb","line":272,"range":{"start_line":272,"start_character":22,"end_line":272,"end_character":33},"in_reply_to":"3f4b6375_3b6b92b7","updated":"2017-10-25 14:54:07.000000000","message":"I\u0027m not sure what you mean here, unless you mean count the build requests and pass the decremented limit to listing the instances? This code tries to treat the build requests as just another \"cell\" with an instance-producing generator. The build requests code isn\u0027t very efficient, but it could be, so I don\u0027t want to assume I can iterate that list here so that the rest of the merge sorting happens as normal.","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ac8b58fe5b51d9590d77ec3e51b9c672a6ceb67e","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    sort_ctx \u003d InstanceSortContext(sort_keys, sort_dirs)"},{"line_number":271,"context_line":"    build_requests \u003d objects.BuildRequestList.get_by_filters("},{"line_number":272,"context_line":"        ctx, filters, limit\u003dlimit, marker\u003dmarker, sort_keys\u003dsort_keys,"},{"line_number":273,"context_line":"        sort_dirs\u003dsort_dirs)"},{"line_number":274,"context_line":"    br_inst_generator \u003d (InstanceWrapper(sort_ctx, br.instance)"},{"line_number":275,"context_line":"                         for br in build_requests)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_f632aff1","line":272,"range":{"start_line":272,"start_character":22,"end_line":272,"end_character":33},"in_reply_to":"3f4b6375_7b0c6aeb","updated":"2017-10-25 15:13:57.000000000","message":"I was more or less thinking about how the compute API code would first query build requests, decrement the running limit, then query cell0, decrement the limit again, and then page the cells decrementing until we\u0027ve reached the limit or have nothing else to pull out of the DB.\n\nI know we\u0027re doing the cells (including cell0) concurrently now, it just kind of looked like the build request stuff here was separate, but I guess not based on how merge_with_limit_nodupes is used with br_inst_generator.\n\nAnyway, this gets hairy which is why I was pushing for tests on the limits + build requests stuff.","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b18fcd838ba6bb2d98159769089c9da13dd77372","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    sort_ctx \u003d InstanceSortContext(sort_keys, sort_dirs)"},{"line_number":271,"context_line":"    build_requests \u003d objects.BuildRequestList.get_by_filters("},{"line_number":272,"context_line":"        ctx, filters, limit\u003dlimit, marker\u003dmarker, sort_keys\u003dsort_keys,"},{"line_number":273,"context_line":"        sort_dirs\u003dsort_dirs)"},{"line_number":274,"context_line":"    br_inst_generator \u003d (InstanceWrapper(sort_ctx, br.instance)"},{"line_number":275,"context_line":"                         for br in build_requests)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_7c4ea1c1","line":272,"range":{"start_line":272,"start_character":22,"end_line":272,"end_character":33},"in_reply_to":"3f4b6375_f632aff1","updated":"2017-10-25 16:12:09.000000000","message":"Yeah, the only way we can decrement the limit is if we iterate build_requests first to find out how many we have, which is what I was trying to avoid here to be more efficient.\n\nThe query for more tests was clearly important, so no argument there.","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8902a3a1033f983c9319d042378703ee02eb1bf6","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                yield thing._db_instance"},{"line_number":290,"context_line":"                seen_uuids.add(uuid)"},{"line_number":291,"context_line":"                limit -\u003d 1"},{"line_number":292,"context_line":"                if limit \u003d\u003d 0:"},{"line_number":293,"context_line":"                    return"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    return instance_obj._make_instance_list(ctx, objects.InstanceList(),"},{"line_number":296,"context_line":"                                            merge_with_limit_nodupes("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_9f27c4b7","line":293,"range":{"start_line":292,"start_character":0,"end_line":293,"end_character":26},"updated":"2017-10-18 14:21:43.000000000","message":"This will never trigger if limit is None (or somehow negative). That\u0027s expected behavior, right?","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c8294a794667074fd235467a0ce63e04a89f879c","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                yield thing._db_instance"},{"line_number":290,"context_line":"                seen_uuids.add(uuid)"},{"line_number":291,"context_line":"                limit -\u003d 1"},{"line_number":292,"context_line":"                if limit \u003d\u003d 0:"},{"line_number":293,"context_line":"                    return"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    return instance_obj._make_instance_list(ctx, objects.InstanceList(),"},{"line_number":296,"context_line":"                                            merge_with_limit_nodupes("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_10dce172","line":293,"range":{"start_line":292,"start_character":0,"end_line":293,"end_character":26},"in_reply_to":"3f4b6375_9f27c4b7","updated":"2017-10-18 14:50:21.000000000","message":"Yep, same logic as L252","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"}],"nova/tests/functional/compute/test_instance_list.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"48587488a34740c21abae2648756c909c5d6faf9","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        self._make_some_buildrequests()"},{"line_number":554,"context_line":"        insts \u003d instance_list.get_instance_objects_sorted("},{"line_number":555,"context_line":"            self.context,"},{"line_number":556,"context_line":"            {\u0027instance_type_id\u0027: 2}, None, None, [],"},{"line_number":557,"context_line":"            [key], [\u0027asc\u0027])"},{"line_number":558,"context_line":"        self.assertEqual(2, len(insts))"},{"line_number":559,"context_line":"        vals_found \u003d [getattr(i, key) for i in insts]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_3bb03243","line":556,"range":{"start_line":556,"start_character":37,"end_line":556,"end_character":47},"updated":"2017-10-25 14:46:04.000000000","message":"I don\u0027t see us testing with limits + build requests anywhere in here - do we test that elsewhere, like maybe in functional tests?","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"20ddb5856bf4f9ef78cd1ed53d7d9ec217c9997a","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        self._make_some_buildrequests()"},{"line_number":554,"context_line":"        insts \u003d instance_list.get_instance_objects_sorted("},{"line_number":555,"context_line":"            self.context,"},{"line_number":556,"context_line":"            {\u0027instance_type_id\u0027: 2}, None, None, [],"},{"line_number":557,"context_line":"            [key], [\u0027asc\u0027])"},{"line_number":558,"context_line":"        self.assertEqual(2, len(insts))"},{"line_number":559,"context_line":"        vals_found \u003d [getattr(i, key) for i in insts]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_5bdf6e39","line":556,"range":{"start_line":556,"start_character":37,"end_line":556,"end_character":47},"in_reply_to":"3f4b6375_3bb03243","updated":"2017-10-25 14:54:07.000000000","message":"We might in test_servers or something, but it\u0027s probably hard to know for sure. I can add more here easily.","commit_id":"2901b70ccf37278aa1daca44668cba0e2e54c425"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"48587488a34740c21abae2648756c909c5d6faf9","unresolved":false,"context_lines":[{"line_number":4673,"context_line":"    @mock.patch.object(objects.BuildRequestList, \u0027get_by_filters\u0027)"},{"line_number":4674,"context_line":"    @mock.patch.object(objects.CellMapping, \u0027get_by_uuid\u0027,"},{"line_number":4675,"context_line":"                       side_effect\u003dexception.CellMappingNotFound(uuid\u003d\u0027fake\u0027))"},{"line_number":4676,"context_line":"    def test_get_all_build_requests_decrement_limit(self,"},{"line_number":4677,"context_line":"                                                    mock_cell_mapping_get,"},{"line_number":4678,"context_line":"                                                    mock_buildreq_get):"},{"line_number":4679,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_db8b5e65","side":"PARENT","line":4676,"range":{"start_line":4676,"start_character":8,"end_line":4676,"end_character":51},"updated":"2017-10-25 14:46:04.000000000","message":"So this was testing with build requests and a limit, should this have not been removed? Or at least replayed somehow in the new tests?","commit_id":"c3ca8a6256f9b5f3235b65d483099047d50adc6f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"20ddb5856bf4f9ef78cd1ed53d7d9ec217c9997a","unresolved":false,"context_lines":[{"line_number":4673,"context_line":"    @mock.patch.object(objects.BuildRequestList, \u0027get_by_filters\u0027)"},{"line_number":4674,"context_line":"    @mock.patch.object(objects.CellMapping, \u0027get_by_uuid\u0027,"},{"line_number":4675,"context_line":"                       side_effect\u003dexception.CellMappingNotFound(uuid\u003d\u0027fake\u0027))"},{"line_number":4676,"context_line":"    def test_get_all_build_requests_decrement_limit(self,"},{"line_number":4677,"context_line":"                                                    mock_cell_mapping_get,"},{"line_number":4678,"context_line":"                                                    mock_buildreq_get):"},{"line_number":4679,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_1be57609","side":"PARENT","line":4676,"range":{"start_line":4676,"start_character":8,"end_line":4676,"end_character":51},"in_reply_to":"3f4b6375_db8b5e65","updated":"2017-10-25 14:54:07.000000000","message":"This was testing it all the way through the compute api, which isn\u0027t where it happens anymore. Yeah, I\u0027ll just add some coverage of using a limit to the instance_list tests where it can be done cleanly.","commit_id":"c3ca8a6256f9b5f3235b65d483099047d50adc6f"}]}