)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b397131d8fb3622a1e8ce9534f633667f483b685","unresolved":false,"context_lines":[{"line_number":17,"context_line":"name \u003d \"  extra large  \"  #allowed, but leading and trailing whitespaces"},{"line_number":18,"context_line":"                          #will be trimmed (same as instance name)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Fixes bug #1237611"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ie68be299030a878a752dbfdcdfe5094f8427598a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATH%2F%2FKfI%3D","line":20,"updated":"2013-10-22 07:58:08.000000000","message":"nit, follow this guide: https://wiki.openstack.org/wiki/GitCommitMessages\n\nwe should use Closes-bug: #1237611","commit_id":"7349441415eb274acf4733408cda2528dbab4b22"}],"nova/compute/flavors.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"5fecbb3c1b328251cb1f8a1600d590e187161fef","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        \u0027rxtx_factor\u0027: rxtx_factor,"},{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    if isinstance(name, basestring):"},{"line_number":90,"context_line":"        name \u003d name.strip()"},{"line_number":91,"context_line":"    # ensure name do not exceed 255 characters"},{"line_number":92,"context_line":"    utils.check_string_length(name, \u0027name\u0027, min_length\u003d1, max_length\u003d255)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FKWw%3D","line":89,"updated":"2013-10-22 08:51:39.000000000","message":"we\u0027d better to use six.string_types","commit_id":"7349441415eb274acf4733408cda2528dbab4b22"}],"nova/tests/api/openstack/compute/contrib/test_flavor_manage.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffb13197dc9c15745f8b030c3abd4a69aabffc06","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":176,"context_line":"        req.body \u003d jsonutils.dumps(expected)"},{"line_number":177,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":178,"context_line":"        self.assertEquals(res.status_code, 400)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test_create_public_default(self):"},{"line_number":181,"context_line":"        flavor \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FOBM%3D","line":178,"updated":"2013-10-21 07:35:46.000000000","message":"Please use self.assertEqual instead of self.assertEquals","commit_id":"c35a49c99fbc022f0e52cdb7c3094f3e7c263fc9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"01ccfe5e81714d1b5ec3753b60a059eaf799cbf6","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":155,"context_line":"        self.assertEquals(res.status_code, 400)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_create_flavor_name_is_whitespace(self):"},{"line_number":158,"context_line":"        expected \u003d {"},{"line_number":159,"context_line":"            \"flavor\": {"},{"line_number":160,"context_line":"                \"name\": \" \","}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FKf0%3D","line":157,"updated":"2013-10-22 07:46:49.000000000","message":"Abhijeet, could you add same tests for v3 api tests?","commit_id":"7349441415eb274acf4733408cda2528dbab4b22"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self.assertEquals(res.status_code, 400)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_create_flavor_name_is_whitespace(self):"},{"line_number":158,"context_line":"        expected \u003d {"},{"line_number":159,"context_line":"            \"flavor\": {"},{"line_number":160,"context_line":"                \"name\": \" \","},{"line_number":161,"context_line":"                \u0027id\u0027: \"12345\","}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLw%3D","line":158,"updated":"2013-10-31 23:36:14.000000000","message":"expected is really misleading here. It\u0027s not the expected value - the response - it\u0027s the request. So please call it e.g. request_dict or something.","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.assertEqual(res.status_code, 400)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test_create_flavor_name_with_leading_trailing_whitespace(self):"},{"line_number":181,"context_line":"        expected \u003d {"},{"line_number":182,"context_line":"            \"flavor\": {"},{"line_number":183,"context_line":"                \"name\": \" test \","},{"line_number":184,"context_line":"                \u0027id\u0027: \"12345\","}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLs%3D","line":181,"updated":"2013-10-31 23:36:14.000000000","message":"Ditto on the variable name.","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self.assertEqual(res.status_code, 200)"},{"line_number":202,"context_line":"        body \u003d jsonutils.loads(res.body)"},{"line_number":203,"context_line":"        self.assertEqual(expected[\"flavor\"][\"name\"].strip(),"},{"line_number":204,"context_line":"                         body[\"flavor\"][\"name\"])"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_create_public_default(self):"},{"line_number":207,"context_line":"        flavor \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLo%3D","line":204,"updated":"2013-10-31 23:36:14.000000000","message":"I think this would be clearer:\n\n self.assertEqual(\"test\", body[\"flavor\"][\"name\"])","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"}],"nova/tests/api/openstack/compute/plugins/v3/test_flavor_manage.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                          \"test_memory_mb\", 2, None, 1, 1234, 512, 1, True)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def test_create_flavor_name_is_whitespace(self):"},{"line_number":216,"context_line":"        \"\"\"Check flavor name can\u0027t be only white spaces.\"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        expected \u003d {"},{"line_number":219,"context_line":"            \"flavor\": {"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLc%3D","line":216,"updated":"2013-10-31 23:36:14.000000000","message":"Personal preference: I would drop the docstring and make the test name better:\n\n def test_all_whitespace_flavor_names_are_rejected(self):","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def test_create_flavor_name_is_whitespace(self):"},{"line_number":216,"context_line":"        \"\"\"Check flavor name can\u0027t be only white spaces.\"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        expected \u003d {"},{"line_number":219,"context_line":"            \"flavor\": {"},{"line_number":220,"context_line":"                \"name\": \" \","}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLg%3D","line":217,"updated":"2013-10-31 23:36:14.000000000","message":"Whats the blank line for?","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    def test_create_flavor_name_is_whitespace(self):"},{"line_number":216,"context_line":"        \"\"\"Check flavor name can\u0027t be only white spaces.\"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        expected \u003d {"},{"line_number":219,"context_line":"            \"flavor\": {"},{"line_number":220,"context_line":"                \"name\": \" \","},{"line_number":221,"context_line":"                \u0027id\u0027: \"1234\","}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLk%3D","line":218,"updated":"2013-10-31 23:36:14.000000000","message":"And the name here too.","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.assertEqual(res.status_code, 400)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_create_flavor_name_with_leading_trailing_whitespaces(self):"},{"line_number":241,"context_line":"        expected \u003d {"},{"line_number":242,"context_line":"            \"flavor\": {"},{"line_number":243,"context_line":"                \"name\": \" test \","},{"line_number":244,"context_line":"                \u0027id\u0027: \"1234\","}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLY%3D","line":241,"updated":"2013-10-31 23:36:14.000000000","message":"Variable name.","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        self.assertEqual(res.status_code, 200)"},{"line_number":262,"context_line":"        body \u003d jsonutils.loads(res.body)"},{"line_number":263,"context_line":"        self.assertEqual(expected[\"flavor\"][\"name\"].strip(),"},{"line_number":264,"context_line":"                          body[\"flavor\"][\"name\"])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"class FakeRequest(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLU%3D","line":264,"updated":"2013-10-31 23:36:14.000000000","message":"And again, I think this would be clearer as a specific test against \"test\"","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"}],"nova/tests/test_flavors.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"81204f3ec15dcf2f75a798836a873de37dd84161","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        self.assertInvalidInput(\u0027\u0027, 64, 1, 120)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def test_flavor_name_with_whitespace(self):"},{"line_number":418,"context_line":"        # Flavor name which is whitespace should cause error"},{"line_number":419,"context_line":"        self.assertInvalidInput(\u0027 \u0027, 64, 1, 120)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_flavorid_with_invalid_characters(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FlLQ%3D","line":418,"updated":"2013-10-31 23:36:14.000000000","message":"You won\u0027t need the comment if the test name is more informative:\n\n def test_all_whitespace_flavor_names_rejected(self):","commit_id":"5287ffd7153170b66c4bec47283329354609fff4"}]}