)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"89ad8793267ab6b3e9b943915123195f2505693d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"being module-level functions to be consistent with the similar"},{"line_number":12,"context_line":"functions for inventory and allocation information."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"blueprint: de-orm-resource-providers"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I52db9b4ca89aeb2a4ce9d10820bdac6fabf43ea4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_b4ec7e8f","line":14,"updated":"2017-10-06 19:44:51.000000000","message":"Is this supposed to be spelled\n\n Partial-Implements: de-orm-resource-providers\n\n?","commit_id":"930f2e525e9c4ddcb99d7fcfab4a2e1c8355ae18"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b31b4b66de8084ec269c187519feeab9fe5df6bf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"being module-level functions to be consistent with the similar"},{"line_number":12,"context_line":"functions for inventory and allocation information."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"blueprint: de-orm-resource-providers"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I52db9b4ca89aeb2a4ce9d10820bdac6fabf43ea4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_c3f6f05d","line":14,"in_reply_to":"7f515b1d_b4ec7e8f","updated":"2017-10-09 15:28:57.000000000","message":"It\u0027s :\n\n Partially-Implements: blueprint de-orm-resource-providers \n\nbut looks a nit to me.","commit_id":"930f2e525e9c4ddcb99d7fcfab4a2e1c8355ae18"}],"nova/objects/resource_provider.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"710d63a56cb5954a5f57301220dd410d2f007cea","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                context.session.flush()"},{"line_number":464,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":465,"context_line":"                # Something else has already added this agg_uuid"},{"line_number":466,"context_line":"                pass"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    # Remove all aggregate associations so we can refresh them"},{"line_number":469,"context_line":"    # below. This means that all associations are added, but the"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_036344de","line":466,"updated":"2017-10-05 14:10:10.000000000","message":"Maybe you do this later, but this block seems like an ideal place to extract a method since it is fairly isolated and has a concept (add the stuff in to_add).\n\nAlso maybe later, this could be de-ormed.","commit_id":"9d2af127588384727e6d0dd4538a0ace250d4f6e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8062884504f8a455c4a00821a246c72f76b0f2b7","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                context.session.flush()"},{"line_number":464,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":465,"context_line":"                # Something else has already added this agg_uuid"},{"line_number":466,"context_line":"                pass"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    # Remove all aggregate associations so we can refresh them"},{"line_number":469,"context_line":"    # below. This means that all associations are added, but the"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_a3f2306e","line":466,"in_reply_to":"7f515b1d_036344de","updated":"2017-10-05 14:24:34.000000000","message":"I can do a separate patch later for that, sure.","commit_id":"9d2af127588384727e6d0dd4538a0ace250d4f6e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"710d63a56cb5954a5f57301220dd410d2f007cea","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            insert().from_select([\u0027resource_provider_id\u0027, \u0027aggregate_id\u0027],"},{"line_number":481,"context_line":"                                 select_agg_id)"},{"line_number":482,"context_line":"        conn \u003d context.session.connection()"},{"line_number":483,"context_line":"        conn.execute(insert_aggregates)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"@base.NovaObjectRegistry.register_if(False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_23a9a0dc","line":483,"updated":"2017-10-05 14:10:10.000000000","message":"same comment for this chunk too","commit_id":"9d2af127588384727e6d0dd4538a0ace250d4f6e"}]}