)]}'
{"nova/api/openstack/placement/handlers/allocation.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8cec198f84f9887aacb28b37ad4c81115e04954d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    # confirm existence of resource provider so we get a reasonable"},{"line_number":193,"context_line":"    # 404 instead of empty list"},{"line_number":194,"context_line":"    try:"},{"line_number":195,"context_line":"        rp \u003d rp_obj.ResourceProvider.get_by_uuid(context, uuid)"},{"line_number":196,"context_line":"    except exception.NotFound as exc:"},{"line_number":197,"context_line":"        raise webob.exc.HTTPNotFound("},{"line_number":198,"context_line":"            _(\"Resource provider \u0027%(rp_uuid)s\u0027 not found: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_36fc593d","line":195,"updated":"2017-10-04 22:52:45.000000000","message":"Just symbol changes in this file, for LOC reduction?","commit_id":"011939d3a7ff78d9c0463c847b720ae0a9e7b227"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"dfab53f405169953babdfce14a8e51f6e2ef93b5","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    # confirm existence of resource provider so we get a reasonable"},{"line_number":193,"context_line":"    # 404 instead of empty list"},{"line_number":194,"context_line":"    try:"},{"line_number":195,"context_line":"        rp \u003d rp_obj.ResourceProvider.get_by_uuid(context, uuid)"},{"line_number":196,"context_line":"    except exception.NotFound as exc:"},{"line_number":197,"context_line":"        raise webob.exc.HTTPNotFound("},{"line_number":198,"context_line":"            _(\"Resource provider \u0027%(rp_uuid)s\u0027 not found: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_f8169649","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":10},"updated":"2017-10-05 14:54:10.000000000","message":"resource_provider","commit_id":"011939d3a7ff78d9c0463c847b720ae0a9e7b227"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8a1a3f95a7a65ce33d1f685652e500bf7c046c51","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    # confirm existence of resource provider so we get a reasonable"},{"line_number":193,"context_line":"    # 404 instead of empty list"},{"line_number":194,"context_line":"    try:"},{"line_number":195,"context_line":"        rp \u003d rp_obj.ResourceProvider.get_by_uuid(context, uuid)"},{"line_number":196,"context_line":"    except exception.NotFound as exc:"},{"line_number":197,"context_line":"        raise webob.exc.HTTPNotFound("},{"line_number":198,"context_line":"            _(\"Resource provider \u0027%(rp_uuid)s\u0027 not found: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_a365901f","line":195,"in_reply_to":"7f515b1d_36fc593d","updated":"2017-10-05 14:26:26.000000000","message":"Well, and we\u0027re passing the resource provider object now, not the UUID, to a differently-named get_all_by_resource_provider() method.","commit_id":"011939d3a7ff78d9c0463c847b720ae0a9e7b227"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"dfab53f405169953babdfce14a8e51f6e2ef93b5","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            _(\"Resource provider \u0027%(rp_uuid)s\u0027 not found: %(error)s\") %"},{"line_number":199,"context_line":"            {\u0027rp_uuid\u0027: uuid, \u0027error\u0027: exc})"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    allocs \u003d rp_obj.AllocationList.get_all_by_resource_provider(context, rp)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    allocations_json \u003d jsonutils.dumps("},{"line_number":204,"context_line":"        _serialize_allocations_for_resource_provider(allocs, rp))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_b82a5e7b","line":201,"range":{"start_line":201,"start_character":3,"end_line":201,"end_character":10},"updated":"2017-10-05 14:54:10.000000000","message":"allocations","commit_id":"011939d3a7ff78d9c0463c847b720ae0a9e7b227"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"440c3b823ad984145ccb6b92b5bfea48029dfaef","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            _(\"Resource provider \u0027%(rp_uuid)s\u0027 not found: %(error)s\") %"},{"line_number":199,"context_line":"            {\u0027rp_uuid\u0027: uuid, \u0027error\u0027: exc})"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    allocs \u003d rp_obj.AllocationList.get_all_by_resource_provider(context, rp)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    allocations_json \u003d jsonutils.dumps("},{"line_number":204,"context_line":"        _serialize_allocations_for_resource_provider(allocs, rp))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_78baa66e","line":201,"range":{"start_line":201,"start_character":3,"end_line":201,"end_character":10},"in_reply_to":"7f515b1d_b82a5e7b","updated":"2017-10-05 15:08:28.000000000","message":"see comment on previous patch. I prefer a single line call, and rp is clear what it is.","commit_id":"011939d3a7ff78d9c0463c847b720ae0a9e7b227"}],"nova/objects/resource_provider.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"dfab53f405169953babdfce14a8e51f6e2ef93b5","unresolved":false,"context_lines":[{"line_number":1800,"context_line":"    def get_all_by_resource_provider(cls, context, rp):"},{"line_number":1801,"context_line":"        _ensure_rc_cache(context)"},{"line_number":1802,"context_line":"        db_allocs \u003d _get_allocations_by_provider_id(context, rp.id)"},{"line_number":1803,"context_line":"        objs \u003d ["},{"line_number":1804,"context_line":"            Allocation("},{"line_number":1805,"context_line":"                context, resource_provider\u003drp,"},{"line_number":1806,"context_line":"                resource_class\u003d_RC_CACHE.string_from_id("},{"line_number":1807,"context_line":"                    rec[\u0027resource_class_id\u0027]),"},{"line_number":1808,"context_line":"                **rec)"},{"line_number":1809,"context_line":"            for rec in db_allocs"},{"line_number":1810,"context_line":"        ]"},{"line_number":1811,"context_line":"        alloc_list \u003d cls(context, objects\u003dobjs)"},{"line_number":1812,"context_line":"        alloc_list.obj_reset_changes()"},{"line_number":1813,"context_line":"        return alloc_list"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_f8445649","line":1810,"range":{"start_line":1803,"start_character":0,"end_line":1810,"end_character":9},"updated":"2017-10-05 14:54:10.000000000","message":"as before, this is bewildering if you don\u0027t really already know waht\u0027s going on","commit_id":"011939d3a7ff78d9c0463c847b720ae0a9e7b227"}]}