)]}'
{"nova/objects/resource_provider.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"76a57c7149c0a3271d4967f05a19a75c37b9c42f","unresolved":false,"context_lines":[{"line_number":1690,"context_line":"    ]"},{"line_number":1691,"context_line":"    join \u003d sa.join(allocs, rp, allocs.c.resource_provider_id \u003d\u003d rp.c.id)"},{"line_number":1692,"context_line":"    sel \u003d sa.select(cols).select_from(join)"},{"line_number":1693,"context_line":"    sel \u003d sel.where(allocs.c.consumer_id \u003d\u003d consumer_uuid)"},{"line_number":1694,"context_line":""},{"line_number":1695,"context_line":"    return [dict(r) for r in ctx.session.execute(sel)]"},{"line_number":1696,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_7843c614","line":1693,"updated":"2017-10-05 14:56:12.000000000","message":"If we wanted make these changes more testable, we could extract the query generation part to its own method and validate that the query is what we\u0027ve expecting","commit_id":"8ffc006608f7dbef95a23c393ce14e1222a34e19"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d9bf735e80394c4ea07a19ab0b66b105b1956c3c","unresolved":false,"context_lines":[{"line_number":1690,"context_line":"    ]"},{"line_number":1691,"context_line":"    join \u003d sa.join(allocs, rp, allocs.c.resource_provider_id \u003d\u003d rp.c.id)"},{"line_number":1692,"context_line":"    sel \u003d sa.select(cols).select_from(join)"},{"line_number":1693,"context_line":"    sel \u003d sel.where(allocs.c.consumer_id \u003d\u003d consumer_uuid)"},{"line_number":1694,"context_line":""},{"line_number":1695,"context_line":"    return [dict(r) for r in ctx.session.execute(sel)]"},{"line_number":1696,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_18597259","line":1693,"in_reply_to":"7f515b1d_7843c614","updated":"2017-10-05 15:09:51.000000000","message":"more unit-testable, perhaps. But functional tests are really where the resource_provider.py module is tested, not unit tests (mostly for this reason)","commit_id":"8ffc006608f7dbef95a23c393ce14e1222a34e19"}]}