)]}'
{"nova/compute/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"628a9cf6a27347b8dcefc7931b36c8c7f9ade3ee","unresolved":false,"context_lines":[{"line_number":2338,"context_line":"                \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":2339,"context_line":"                \u0027flavor\u0027: _remap_flavor_filter,"},{"line_number":2340,"context_line":"                \u0027fixed_ip\u0027: _remap_fixed_ip_filter,"},{"line_number":2341,"context_line":"                \u0027metadata\u0027: _remap_metadata_filter,"},{"line_number":2342,"context_line":"                \u0027system_metadata\u0027: _remap_system_metadata_filter}"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        # copy from search_opts, doing various remappings as necessary"},{"line_number":2345,"context_line":"        for opt, value in search_opts.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_623c01bf","side":"PARENT","line":2342,"range":{"start_line":2341,"start_character":0,"end_line":2342,"end_character":65},"updated":"2017-10-23 15:42:18.000000000","message":"Right, these were specifically removed in [1]\n\n[1] https://review.openstack.org/#/c/408571/41/nova/api/openstack/compute/servers.py@224","commit_id":"e4f89ed5dd4259188d020749fa8fb1c77be2c03a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e32ed718046062e418759b4fcae5b6a854ab722a","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"                \u0027name\u0027: \u0027display_name\u0027,"},{"line_number":2332,"context_line":"                \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":2333,"context_line":"                \u0027flavor\u0027: _remap_flavor_filter,"},{"line_number":2334,"context_line":"                \u0027fixed_ip\u0027: _remap_fixed_ip_filter}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        # copy from search_opts, doing various remappings as necessary"},{"line_number":2337,"context_line":"        for opt, value in search_opts.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_7a6d0897","line":2334,"updated":"2017-10-19 22:54:30.000000000","message":"I think this is also likely dead code.","commit_id":"ad57e4207220ff88ddfbbb8fb3f6720459d88577"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"628a9cf6a27347b8dcefc7931b36c8c7f9ade3ee","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"                \u0027name\u0027: \u0027display_name\u0027,"},{"line_number":2332,"context_line":"                \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":2333,"context_line":"                \u0027flavor\u0027: _remap_flavor_filter,"},{"line_number":2334,"context_line":"                \u0027fixed_ip\u0027: _remap_fixed_ip_filter}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        # copy from search_opts, doing various remappings as necessary"},{"line_number":2337,"context_line":"        for opt, value in search_opts.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_029c2dbe","line":2334,"in_reply_to":"3f4b6375_1a8f342b","updated":"2017-10-23 15:42:18.000000000","message":"\u003e However, removing this could result in some weird behavior in the\n \u003e DB API filtering since there is no instances.fixed_ip column. And\n \u003e the server list schema allows additionalProperties so we won\u0027t fail\n \u003e on those.\n\nSounds like we want to keep this so, thanks to those additionalProperties","commit_id":"ad57e4207220ff88ddfbbb8fb3f6720459d88577"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"567bab100777680848b52e96eeb8a01bbb65b562","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"                \u0027name\u0027: \u0027display_name\u0027,"},{"line_number":2332,"context_line":"                \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":2333,"context_line":"                \u0027flavor\u0027: _remap_flavor_filter,"},{"line_number":2334,"context_line":"                \u0027fixed_ip\u0027: _remap_fixed_ip_filter}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        # copy from search_opts, doing various remappings as necessary"},{"line_number":2337,"context_line":"        for opt, value in search_opts.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_222f3440","line":2334,"in_reply_to":"3f4b6375_1a8f342b","updated":"2017-10-23 09:44:10.000000000","message":"This seems fine as it is remapped to \u0027ip\u0027 @L2326.","commit_id":"ad57e4207220ff88ddfbbb8fb3f6720459d88577"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9ab44b382bdf6d0be546eaa3eb46f2f452a19fec","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"                \u0027name\u0027: \u0027display_name\u0027,"},{"line_number":2332,"context_line":"                \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":2333,"context_line":"                \u0027flavor\u0027: _remap_flavor_filter,"},{"line_number":2334,"context_line":"                \u0027fixed_ip\u0027: _remap_fixed_ip_filter}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        # copy from search_opts, doing various remappings as necessary"},{"line_number":2337,"context_line":"        for opt, value in search_opts.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_eb6d7704","line":2334,"in_reply_to":"3f4b6375_222f3440","updated":"2017-10-23 11:51:21.000000000","message":"But yea it would not come to this point as schema will strip out this.","commit_id":"ad57e4207220ff88ddfbbb8fb3f6720459d88577"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ae51b3567214f7fa5767ae8eabd347d68df5f14","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"                \u0027name\u0027: \u0027display_name\u0027,"},{"line_number":2332,"context_line":"                \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":2333,"context_line":"                \u0027flavor\u0027: _remap_flavor_filter,"},{"line_number":2334,"context_line":"                \u0027fixed_ip\u0027: _remap_fixed_ip_filter}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        # copy from search_opts, doing various remappings as necessary"},{"line_number":2337,"context_line":"        for opt, value in search_opts.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_1a8f342b","line":2334,"in_reply_to":"3f4b6375_7a6d0897","updated":"2017-10-19 23:05:24.000000000","message":"However, removing this could result in some weird behavior in the DB API filtering since there is no instances.fixed_ip column. And the server list schema allows additionalProperties so we won\u0027t fail on those.","commit_id":"ad57e4207220ff88ddfbbb8fb3f6720459d88577"}]}