)]}'
{"nova/conf/neutron.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ff5ae8f3637aa784547144013b80e62e8bf06721","unresolved":false,"context_lines":[{"line_number":32,"context_line":"neutron_opts \u003d ["},{"line_number":33,"context_line":"    cfg.URIOpt(\u0027url\u0027,"},{"line_number":34,"context_line":"        sample_default\u003d\u0027http://127.0.0.1:9696\u0027,"},{"line_number":35,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":36,"context_line":"        deprecated_reason\u003d\u0027Endpoint lookup uses the service catalog via \u0027"},{"line_number":37,"context_line":"                          \u0027common keystoneauth1 Adapter configuration \u0027"},{"line_number":38,"context_line":"                          \u0027options. In the current release, \"url\" will \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_c6ae6ee6","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":30},"updated":"2017-10-11 09:15:06.000000000","message":"maybe add deprecation time as well..","commit_id":"82d1ca42bf3a73d71fc5201808362a6fffd45af1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"13b29d8979c412dab627c0829ef7be69dcbc29cc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"neutron_opts \u003d ["},{"line_number":33,"context_line":"    cfg.URIOpt(\u0027url\u0027,"},{"line_number":34,"context_line":"        sample_default\u003d\u0027http://127.0.0.1:9696\u0027,"},{"line_number":35,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":36,"context_line":"        deprecated_reason\u003d\u0027Endpoint lookup uses the service catalog via \u0027"},{"line_number":37,"context_line":"                          \u0027common keystoneauth1 Adapter configuration \u0027"},{"line_number":38,"context_line":"                          \u0027options. In the current release, \"url\" will \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_0014694d","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":30},"in_reply_to":"5f4e5783_c6ae6ee6","updated":"2017-10-11 11:45:18.000000000","message":"Done","commit_id":"82d1ca42bf3a73d71fc5201808362a6fffd45af1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"622d4794eba92a0b80c4adbf598aa84357290302","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  This typically matches the URL returned for the \u0027network\u0027 service type"},{"line_number":38,"context_line":"  from the Keystone service catalog."},{"line_number":39,"context_line":"\"\"\"),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027RegionOne\u0027,"},{"line_number":42,"context_line":"        help\u003d\"\"\""},{"line_number":43,"context_line":"Region name for connecting to Neutron in admin context."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_f4a8c78c","side":"PARENT","line":41,"range":{"start_line":40,"start_character":4,"end_line":41,"end_character":28},"updated":"2018-01-08 17:56:37.000000000","message":"This is being removed because it already comes from ksa. However, there is a slight behavior change here because nova\u0027s version of this was providing a default value, while ksa\u0027s does not. But I see you\u0027ve already covered this in the release note, so lgtm:\n\n\"When ``url`` is not used, ``region_name`` no longer defaults to ``RegionOne``.\"","commit_id":"9519601401ee116a9197fe3b5d571495a96912e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fd3a808695f7bca2fc7d2b1827f31fd04e917d34","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"neutron_opts \u003d ["},{"line_number":33,"context_line":"    cfg.URIOpt(\u0027url\u0027,"},{"line_number":34,"context_line":"        sample_default\u003d\u0027http://127.0.0.1:9696\u0027,"},{"line_number":35,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":36,"context_line":"        deprecated_since\u003d\u002717.0.0\u0027,"},{"line_number":37,"context_line":"        deprecated_reason\u003d\u0027Endpoint lookup uses the service catalog via \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_34070fcd","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":22},"updated":"2018-01-08 17:39:20.000000000","message":"Huh, first I\u0027ve ever seen this.","commit_id":"6cde77ebbab85bc8ccd2ab7ad977b1d4af4a13fa"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"622d4794eba92a0b80c4adbf598aa84357290302","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        # an admin token so log an error"},{"line_number":161,"context_line":"        raise exception.Unauthorized()"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    client_args \u003d dict(session\u003d_SESSION,"},{"line_number":164,"context_line":"                       auth\u003dauth_plugin,"},{"line_number":165,"context_line":"                       global_request_id\u003dcontext.global_request_id)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_54bf33af","line":163,"range":{"start_line":163,"start_character":11,"end_line":163,"end_character":15},"updated":"2018-01-08 17:56:37.000000000","message":"nit: kwargs","commit_id":"6cde77ebbab85bc8ccd2ab7ad977b1d4af4a13fa"},{"author":{"_account_id":27581,"name":"Zhang Shuaiyi","email":"zhang_syi@hotmail.com","username":"zhangshuaiyi"},"change_message_id":"a3127da22f6ed2ab0cb903b7b70536cfa78b223c","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    client_args \u003d dict(session\u003d_SESSION,"},{"line_number":164,"context_line":"                       auth\u003dauth_plugin,"},{"line_number":165,"context_line":"                       global_request_id\u003dcontext.global_request_id)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    if CONF.neutron.url:"},{"line_number":168,"context_line":"        # TODO(efried): Remove in Rocky"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_9b4e2fc1","line":165,"range":{"start_line":165,"start_character":49,"end_line":165,"end_character":66},"updated":"2018-12-21 06:55:55.000000000","message":"Use context.global_id","commit_id":"6cde77ebbab85bc8ccd2ab7ad977b1d4af4a13fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"622d4794eba92a0b80c4adbf598aa84357290302","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                           endpoint_override\u003dCONF.neutron.url,"},{"line_number":171,"context_line":"                           # NOTE(efried): The legacy behavior was to default"},{"line_number":172,"context_line":"                           # region_name in the conf."},{"line_number":173,"context_line":"                           region_name\u003dCONF.neutron.region_name or \u0027RegionOne\u0027)"},{"line_number":174,"context_line":"    else:"},{"line_number":175,"context_line":"        # The new way"},{"line_number":176,"context_line":"        # NOTE(efried): We build an adapter"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_b4cd5f67","line":173,"range":{"start_line":173,"start_character":63,"end_line":173,"end_character":78},"updated":"2018-01-08 17:56:37.000000000","message":"ah nice","commit_id":"6cde77ebbab85bc8ccd2ab7ad977b1d4af4a13fa"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"814f5166df18dd86dfa375ac50e4ad70c6899ecc","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return str(self.lhs)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class TestNeutronClient(test.NoDBTestCase):"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def setUp(self):"},{"line_number":122,"context_line":"        super(TestNeutronClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_cecb5770","line":119,"range":{"start_line":119,"start_character":6,"end_line":119,"end_character":23},"updated":"2017-10-10 03:29:00.000000000","message":"do we plan to create a legacy test case like cinder\u0027s patch?","commit_id":"9d2986b4a7195652c1f376a1d270c3e334068824"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1b549ab81074963ad1e3617c0c3264277ac219bf","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return str(self.lhs)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class TestNeutronClient(test.NoDBTestCase):"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def setUp(self):"},{"line_number":122,"context_line":"        super(TestNeutronClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_bcfe0703","line":119,"range":{"start_line":119,"start_character":6,"end_line":119,"end_character":23},"in_reply_to":"5f4e5783_cecb5770","updated":"2017-10-10 13:11:05.000000000","message":"Not for this one.  The existing tests will continue to work fine; I\u0027ll just remove the self.flags(url\u003d...) from them.","commit_id":"9d2986b4a7195652c1f376a1d270c3e334068824"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"622d4794eba92a0b80c4adbf598aa84357290302","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                                            auth_token\u003d\u0027token\u0027)"},{"line_number":130,"context_line":"        cl \u003d neutronapi.get_client(my_context)"},{"line_number":131,"context_line":"        self.assertEqual(\u0027network\u0027, cl.httpclient.service_type)"},{"line_number":132,"context_line":"        self.assertIsNone(cl.httpclient.service_name)"},{"line_number":133,"context_line":"        self.assertEqual([\u0027internal\u0027, \u0027public\u0027], cl.httpclient.interface)"},{"line_number":134,"context_line":"        self.assertIsNone(cl.httpclient.region_name)"},{"line_number":135,"context_line":"        self.assertIsNone(cl.httpclient.endpoint_override)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_347b8ff5","line":132,"range":{"start_line":132,"start_character":29,"end_line":132,"end_character":39},"updated":"2018-01-08 17:56:37.000000000","message":"This is pretty gross on the neutronclient side, because this is actually an instance of SessionClient if a session kwarg was passed in when creating the client (which nova does).\n\nI could see this breaking in the future if/when neutronclient ever renames this, but if they do we\u0027ll just have to fix it at that time.","commit_id":"6cde77ebbab85bc8ccd2ab7ad977b1d4af4a13fa"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ceb9375c6edf4334248d596404823a1d95c07a51","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                                            auth_token\u003d\u0027token\u0027)"},{"line_number":130,"context_line":"        cl \u003d neutronapi.get_client(my_context)"},{"line_number":131,"context_line":"        self.assertEqual(\u0027network\u0027, cl.httpclient.service_type)"},{"line_number":132,"context_line":"        self.assertIsNone(cl.httpclient.service_name)"},{"line_number":133,"context_line":"        self.assertEqual([\u0027internal\u0027, \u0027public\u0027], cl.httpclient.interface)"},{"line_number":134,"context_line":"        self.assertIsNone(cl.httpclient.region_name)"},{"line_number":135,"context_line":"        self.assertIsNone(cl.httpclient.endpoint_override)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f91af0f_1172187c","line":132,"range":{"start_line":132,"start_character":29,"end_line":132,"end_character":39},"in_reply_to":"9f91af0f_347b8ff5","updated":"2018-01-08 20:39:57.000000000","message":"Or better yet, neutronclient goes away entirely.\n\nI don\u0027t think they can rename/remove httpclient, since it\u0027s a public attribute of the client.\n\nBut yeah, not much to do about it right now.","commit_id":"6cde77ebbab85bc8ccd2ab7ad977b1d4af4a13fa"}]}