)]}'
{"nova/api/openstack/placement/microversion.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"bcead86a66161b0586ea5ceedd03f8176f9ac1e1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            # PUT /allocations"},{"line_number":49,"context_line":"    \u00271.9\u0027,  # Adds GET /usages"},{"line_number":50,"context_line":"    \u00271.10\u0027,  # Adds GET /allocation_candidates resource endpoint"},{"line_number":51,"context_line":"    \u00271.11\u0027,  # PUT to /allocations/{conumser_uuid} in the same dict form"},{"line_number":52,"context_line":"             # as GET"},{"line_number":53,"context_line":"]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_934b3f86","line":51,"updated":"2017-10-10 11:57:12.000000000","message":"typo: consumer_uuid","commit_id":"f86d3919636241a12b22b5709997e9cd7f6fad4b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e99b22d7b58bf619eb2ac909666a5842f29c37c6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            # PUT /allocations"},{"line_number":49,"context_line":"    \u00271.9\u0027,  # Adds GET /usages"},{"line_number":50,"context_line":"    \u00271.10\u0027,  # Adds GET /allocation_candidates resource endpoint"},{"line_number":51,"context_line":"    \u00271.11\u0027,  # PUT to /allocations/{conumser_uuid} in the same dict form"},{"line_number":52,"context_line":"             # as GET"},{"line_number":53,"context_line":"]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_dc5f830c","line":51,"in_reply_to":"5f4e5783_934b3f86","updated":"2017-10-10 13:19:18.000000000","message":"thanks I\u0027ll get that when there needs to be another rebase.","commit_id":"f86d3919636241a12b22b5709997e9cd7f6fad4b"}],"nova/tests/functional/api/openstack/placement/gabbits/allocations-1-11.yaml":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"bcead86a66161b0586ea5ceedd03f8176f9ac1e1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"tests:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: put an allocation listish"},{"line_number":14,"context_line":"  PUT: /allocations/a0b15655-273a-4b3d-9792-2e579b7d5ad9"},{"line_number":15,"context_line":"  data:"},{"line_number":16,"context_line":"      allocations:"},{"line_number":17,"context_line":"          - resource_provider:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f4e5783_93c0de52","line":14,"updated":"2017-10-10 11:57:12.000000000","message":"why not put consumer_uuid in $ENVIRON?","commit_id":"f86d3919636241a12b22b5709997e9cd7f6fad4b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e99b22d7b58bf619eb2ac909666a5842f29c37c6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"tests:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: put an allocation listish"},{"line_number":14,"context_line":"  PUT: /allocations/a0b15655-273a-4b3d-9792-2e579b7d5ad9"},{"line_number":15,"context_line":"  data:"},{"line_number":16,"context_line":"      allocations:"},{"line_number":17,"context_line":"          - resource_provider:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f4e5783_5cf713f7","line":14,"in_reply_to":"5f4e5783_93c0de52","updated":"2017-10-10 13:19:18.000000000","message":"Because in this case it would just be a convenience. The consumer uuid doesn\u0027t mean anything or connect to anything that exists, so while, yes, we could use $ENVIRON as a way of holding a constant string for us, I didn\u0027t because it\u0027s just as easy to copy the string around.","commit_id":"f86d3919636241a12b22b5709997e9cd7f6fad4b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"360d60efd968f9d6c2bf52117a8a28ec412ffeb2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  PUT: /allocations/a0b15655-273a-4b3d-9792-2e579b7d5ad9"},{"line_number":29,"context_line":"  data:"},{"line_number":30,"context_line":"      allocations:"},{"line_number":31,"context_line":"          nice_house_friend:"},{"line_number":32,"context_line":"              resources:"},{"line_number":33,"context_line":"                  VCPU: 1"},{"line_number":34,"context_line":"                  DISK_GB: 20"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_e9087192","line":31,"range":{"start_line":31,"start_character":10,"end_line":31,"end_character":27},"updated":"2017-10-26 16:22:28.000000000","message":"lol :)","commit_id":"bd8dbfaa33ec8d1998c292f23da26d7af8a2d788"}],"nova/tests/functional/api/openstack/placement/gabbits/allocations-bug-1714072.yaml":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"aa25a3f47fd045acbbf93df9f391b1e986e3d0dc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        x-auth-token: admin"},{"line_number":12,"context_line":"        accept: application/json"},{"line_number":13,"context_line":"        content-type: application/json"},{"line_number":14,"context_line":"        openstack-api-version: placement 1.10"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"tests:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f4e5783_e8b7153a","line":14,"updated":"2017-10-10 15:05:02.000000000","message":"I wonder if it makes more sense to default to the later version and persist checks for the older ones. One of my main complaints with using gabbits for this is that it\u0027s hard to know what a request is supposed to look like. I would think that the ones below that don\u0027t specify a version should be the first ones that someone finds and uses. With this change, the default things people would find would be the older style we don\u0027t want them to use.","commit_id":"9c88ab6eb103553adf7173d02edaaab87d583b02"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"404533d758fe1cfe5859796f03c53dfbeb4aa13d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        x-auth-token: admin"},{"line_number":12,"context_line":"        accept: application/json"},{"line_number":13,"context_line":"        content-type: application/json"},{"line_number":14,"context_line":"        openstack-api-version: placement 1.10"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"tests:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f4e5783_68832506","line":14,"in_reply_to":"5f4e5783_e8b7153a","updated":"2017-10-10 15:16:09.000000000","message":"I considered doing that but it felt like the extent of change to tests would make the \"actual\" changes less clear.\n\nI\u0027ve tried to compensate by making sure there is a specific gabbit file for the new microversion, and that files like this one which are testing a bug, test the bug in both versions.","commit_id":"9c88ab6eb103553adf7173d02edaaab87d583b02"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"aa25a3f47fd045acbbf93df9f391b1e986e3d0dc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  response_strings:"},{"line_number":63,"context_line":"      - does not have enough properties"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: put a sucessful dictish allocation"},{"line_number":66,"context_line":"  PUT: /allocations/c9f0186b-64f8-44fb-b6c9-83008d8d6940"},{"line_number":67,"context_line":"  request_headers:"},{"line_number":68,"context_line":"      openstack-api-version: placement 1.11"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f4e5783_a827ddb6","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":23},"updated":"2017-10-10 15:05:02.000000000","message":"\"successful\"","commit_id":"9c88ab6eb103553adf7173d02edaaab87d583b02"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"360d60efd968f9d6c2bf52117a8a28ec412ffeb2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  response_strings:"},{"line_number":63,"context_line":"      - does not have enough properties"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: put a successful dictish allocation"},{"line_number":66,"context_line":"  PUT: /allocations/c9f0186b-64f8-44fb-b6c9-83008d8d6940"},{"line_number":67,"context_line":"  request_headers:"},{"line_number":68,"context_line":"      openstack-api-version: placement 1.11"},{"line_number":69,"context_line":"  data:"},{"line_number":70,"context_line":"      allocations:"},{"line_number":71,"context_line":"          $HISTORY[\u0027get resource provider\u0027].$RESPONSE[\u0027$.uuid\u0027]:"},{"line_number":72,"context_line":"              resources:"},{"line_number":73,"context_line":"                VCPU: 1"},{"line_number":74,"context_line":"                MEMORY_MB: 1"},{"line_number":75,"context_line":"      project_id: 42a32c07-3eeb-4401-9373-68a8cdca6784"},{"line_number":76,"context_line":"      user_id: 66cb2f29-c86d-47c3-8af5-69ae7b778c70"},{"line_number":77,"context_line":"  status: 204"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: fail with empty resources dictish"},{"line_number":80,"context_line":"  PUT: /allocations/c9f0186b-64f8-44fb-b6c9-83008d8d6940"},{"line_number":81,"context_line":"  request_headers:"},{"line_number":82,"context_line":"      openstack-api-version: placement 1.11"},{"line_number":83,"context_line":"  data:"},{"line_number":84,"context_line":"      allocations:"},{"line_number":85,"context_line":"          $HISTORY[\u0027get resource provider\u0027].$RESPONSE[\u0027$.uuid\u0027]:"},{"line_number":86,"context_line":"              resources: {}"},{"line_number":87,"context_line":"      project_id: 42a32c07-3eeb-4401-9373-68a8cdca6784"},{"line_number":88,"context_line":"      user_id: 66cb2f29-c86d-47c3-8af5-69ae7b778c70"},{"line_number":89,"context_line":"  status: 400"},{"line_number":90,"context_line":"  response_strings:"},{"line_number":91,"context_line":"      - does not have enough properties"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_493c252e","line":91,"range":{"start_line":65,"start_character":0,"end_line":91,"end_character":39},"updated":"2017-10-26 16:22:28.000000000","message":"Why put these tests here as opposed to allocations-1.11.yaml?","commit_id":"bd8dbfaa33ec8d1998c292f23da26d7af8a2d788"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7ac4f88c19af3c3cf06c1e8f7614f4dddbcf94c8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  response_strings:"},{"line_number":63,"context_line":"      - does not have enough properties"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: put a successful dictish allocation"},{"line_number":66,"context_line":"  PUT: /allocations/c9f0186b-64f8-44fb-b6c9-83008d8d6940"},{"line_number":67,"context_line":"  request_headers:"},{"line_number":68,"context_line":"      openstack-api-version: placement 1.11"},{"line_number":69,"context_line":"  data:"},{"line_number":70,"context_line":"      allocations:"},{"line_number":71,"context_line":"          $HISTORY[\u0027get resource provider\u0027].$RESPONSE[\u0027$.uuid\u0027]:"},{"line_number":72,"context_line":"              resources:"},{"line_number":73,"context_line":"                VCPU: 1"},{"line_number":74,"context_line":"                MEMORY_MB: 1"},{"line_number":75,"context_line":"      project_id: 42a32c07-3eeb-4401-9373-68a8cdca6784"},{"line_number":76,"context_line":"      user_id: 66cb2f29-c86d-47c3-8af5-69ae7b778c70"},{"line_number":77,"context_line":"  status: 204"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: fail with empty resources dictish"},{"line_number":80,"context_line":"  PUT: /allocations/c9f0186b-64f8-44fb-b6c9-83008d8d6940"},{"line_number":81,"context_line":"  request_headers:"},{"line_number":82,"context_line":"      openstack-api-version: placement 1.11"},{"line_number":83,"context_line":"  data:"},{"line_number":84,"context_line":"      allocations:"},{"line_number":85,"context_line":"          $HISTORY[\u0027get resource provider\u0027].$RESPONSE[\u0027$.uuid\u0027]:"},{"line_number":86,"context_line":"              resources: {}"},{"line_number":87,"context_line":"      project_id: 42a32c07-3eeb-4401-9373-68a8cdca6784"},{"line_number":88,"context_line":"      user_id: 66cb2f29-c86d-47c3-8af5-69ae7b778c70"},{"line_number":89,"context_line":"  status: 400"},{"line_number":90,"context_line":"  response_strings:"},{"line_number":91,"context_line":"      - does not have enough properties"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_4f254508","line":91,"range":{"start_line":65,"start_character":0,"end_line":91,"end_character":39},"in_reply_to":"3f4b6375_493c252e","updated":"2017-10-26 17:42:44.000000000","message":"Guessing, but probably a tab completion bumble. I\u0027ll fix it when I collapse things.","commit_id":"bd8dbfaa33ec8d1998c292f23da26d7af8a2d788"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d0990fe6e9db763994e2dae0564a08e850c6e073","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  response_strings:"},{"line_number":63,"context_line":"      - does not have enough properties"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: put a successful dictish allocation"},{"line_number":66,"context_line":"  PUT: /allocations/c9f0186b-64f8-44fb-b6c9-83008d8d6940"},{"line_number":67,"context_line":"  request_headers:"},{"line_number":68,"context_line":"      openstack-api-version: placement 1.11"},{"line_number":69,"context_line":"  data:"},{"line_number":70,"context_line":"      allocations:"},{"line_number":71,"context_line":"          $HISTORY[\u0027get resource provider\u0027].$RESPONSE[\u0027$.uuid\u0027]:"},{"line_number":72,"context_line":"              resources:"},{"line_number":73,"context_line":"                VCPU: 1"},{"line_number":74,"context_line":"                MEMORY_MB: 1"},{"line_number":75,"context_line":"      project_id: 42a32c07-3eeb-4401-9373-68a8cdca6784"},{"line_number":76,"context_line":"      user_id: 66cb2f29-c86d-47c3-8af5-69ae7b778c70"},{"line_number":77,"context_line":"  status: 204"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: fail with empty resources dictish"},{"line_number":80,"context_line":"  PUT: /allocations/c9f0186b-64f8-44fb-b6c9-83008d8d6940"},{"line_number":81,"context_line":"  request_headers:"},{"line_number":82,"context_line":"      openstack-api-version: placement 1.11"},{"line_number":83,"context_line":"  data:"},{"line_number":84,"context_line":"      allocations:"},{"line_number":85,"context_line":"          $HISTORY[\u0027get resource provider\u0027].$RESPONSE[\u0027$.uuid\u0027]:"},{"line_number":86,"context_line":"              resources: {}"},{"line_number":87,"context_line":"      project_id: 42a32c07-3eeb-4401-9373-68a8cdca6784"},{"line_number":88,"context_line":"      user_id: 66cb2f29-c86d-47c3-8af5-69ae7b778c70"},{"line_number":89,"context_line":"  status: 400"},{"line_number":90,"context_line":"  response_strings:"},{"line_number":91,"context_line":"      - does not have enough properties"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_f586fe65","line":91,"range":{"start_line":65,"start_character":0,"end_line":91,"end_character":39},"in_reply_to":"3f4b6375_4f254508","updated":"2017-10-26 18:46:16.000000000","message":"Oh no, I put these here on purpose. These are exercising the bug that is in the filename, in this new version, for sake of completeness.\n\nThat is: it confirms that the bug isn\u0027t there in the new format.","commit_id":"bd8dbfaa33ec8d1998c292f23da26d7af8a2d788"}],"nova/tests/functional/api/openstack/placement/gabbits/resource-class-in-use.yaml":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"bcead86a66161b0586ea5ceedd03f8176f9ac1e1","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: delete resource class"},{"line_number":77,"context_line":"  DELETE: /resource_classes/CUSTOM_GOLD"},{"line_number":78,"context_line":"  status: 204"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f4e5783_9367be26","line":78,"updated":"2017-10-10 11:57:12.000000000","message":"nit: not needed","commit_id":"f86d3919636241a12b22b5709997e9cd7f6fad4b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e99b22d7b58bf619eb2ac909666a5842f29c37c6","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: delete resource class"},{"line_number":77,"context_line":"  DELETE: /resource_classes/CUSTOM_GOLD"},{"line_number":78,"context_line":"  status: 204"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f4e5783_1c707b72","line":78,"in_reply_to":"5f4e5783_9367be26","updated":"2017-10-10 13:19:18.000000000","message":"looks like some whitespace confusion injected by the editor","commit_id":"f86d3919636241a12b22b5709997e9cd7f6fad4b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"360d60efd968f9d6c2bf52117a8a28ec412ffeb2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        x-auth-token: admin"},{"line_number":10,"context_line":"        accept: application/json"},{"line_number":11,"context_line":"        content-type: application/json"},{"line_number":12,"context_line":"        OpenStack-API-Version: placement 1.10"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"tests:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_692a41db","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":45},"updated":"2017-10-26 16:22:28.000000000","message":"what\u0027s the reason for changing this? Does the behaviour of the tests change from 1.10 to 1.11?","commit_id":"bd8dbfaa33ec8d1998c292f23da26d7af8a2d788"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d0990fe6e9db763994e2dae0564a08e850c6e073","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        x-auth-token: admin"},{"line_number":10,"context_line":"        accept: application/json"},{"line_number":11,"context_line":"        content-type: application/json"},{"line_number":12,"context_line":"        OpenStack-API-Version: placement 1.10"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"tests:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_35e5b638","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":45},"in_reply_to":"3f4b6375_0f498db5","updated":"2017-10-26 18:46:16.000000000","message":"Turns out is because there is a PUT /allocations in this file using the old format. I\u0027ll add a comment to make that clear.","commit_id":"bd8dbfaa33ec8d1998c292f23da26d7af8a2d788"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7ac4f88c19af3c3cf06c1e8f7614f4dddbcf94c8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        x-auth-token: admin"},{"line_number":10,"context_line":"        accept: application/json"},{"line_number":11,"context_line":"        content-type: application/json"},{"line_number":12,"context_line":"        OpenStack-API-Version: placement 1.10"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"tests:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_0f498db5","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":45},"in_reply_to":"3f4b6375_692a41db","updated":"2017-10-26 17:42:44.000000000","message":"Hmmm, don\u0027t actually know, might have been an accidental commit. It shouldn\u0027t make any difference. Will change it back.","commit_id":"bd8dbfaa33ec8d1998c292f23da26d7af8a2d788"}]}