)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a95986906f7fae5d75e6b2582acc95ce5d268dee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: add a condition to check the same host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a compute host satisfy such conditions,"},{"line_number":10,"context_line":"- some well known IP address from RFC5737 is not used and"},{"line_number":11,"context_line":"- there is no default gateway and"},{"line_number":12,"context_line":"- my_ip in nova.conf is not set"},{"line_number":13,"context_line":"then host_ip is set as 127.0.0.1(localhost). Eventhough destination"},{"line_number":14,"context_line":"IP of resizing is same with current hypervisor host_ip, it is not the"},{"line_number":15,"context_line":"same host. So one condition to check a localhost IP or not is added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_d2716ae0","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":31},"updated":"2017-10-20 19:53:33.000000000","message":"Seems like you\u0027re trying to workaround a configuration management / deployment tooling bug with this, which seems like the wrong place to handle it.","commit_id":"c3e98bd9c35d7ffdf23d7c746a6362c1eabe6f9d"},{"author":{"_account_id":24713,"name":"Wonil Choi","email":"wonil0522@gmail.com","username":"wonil22"},"change_message_id":"3f61a7c8dcbddbe7f9767607f36326ad001e8fb5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: add a condition to check the same host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a compute host satisfy such conditions,"},{"line_number":10,"context_line":"- some well known IP address from RFC5737 is not used and"},{"line_number":11,"context_line":"- there is no default gateway and"},{"line_number":12,"context_line":"- my_ip in nova.conf is not set"},{"line_number":13,"context_line":"then host_ip is set as 127.0.0.1(localhost). Eventhough destination"},{"line_number":14,"context_line":"IP of resizing is same with current hypervisor host_ip, it is not the"},{"line_number":15,"context_line":"same host. So one condition to check a localhost IP or not is added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_d294518d","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"3f4b6375_d2716ae0","updated":"2017-11-06 06:03:47.000000000","message":"These are conditions to get the default ip address (127.0.0.1) in\nhttps://github.com/openstack/oslo.utils/blob/master/oslo_utils/netutils.py#L301","commit_id":"c3e98bd9c35d7ffdf23d7c746a6362c1eabe6f9d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"30922e8b80369e4b913e17ab3bfef5792e229897","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: add a condition to check the same host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a compute host satisfy such conditions,"},{"line_number":10,"context_line":"- some well known IP address from RFC5737 is not used and"},{"line_number":11,"context_line":"- there is no default gateway and"},{"line_number":12,"context_line":"- my_ip in nova.conf is not set"},{"line_number":13,"context_line":"then host_ip is set as 127.0.0.1(localhost). Eventhough destination"},{"line_number":14,"context_line":"IP of resizing is same with current hypervisor host_ip, it is not the"},{"line_number":15,"context_line":"same host. So one condition to check a localhost IP or not is added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f485f77_11f9877f","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"3f4b6375_d294518d","updated":"2017-11-09 23:31:22.000000000","message":"Right, but what he\u0027s saying is that one of these three conditions _should_ be set. If they are not, then you probably have an invalid configuration and you should fix it. You\u0027re fixing the issue here, but who knows how many other services rely on one of these being set (anything using \u0027oslo_utils.netutils.get_my_ipv4\u0027, I would imagine)","commit_id":"c3e98bd9c35d7ffdf23d7c746a6362c1eabe6f9d"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":25588,"name":"Maciej Kucia","email":"maciej@kucia.net","username":"m.kucia"},"change_message_id":"876c066665da4dbdc04ea631ebcfe7f880ea81c1","unresolved":false,"context_lines":[{"line_number":7382,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027rbd\u0027:"},{"line_number":7383,"context_line":"            return True"},{"line_number":7384,"context_line":"        shared_storage \u003d (dest \u003d\u003d self.get_host_ip_addr() and"},{"line_number":7385,"context_line":"                          dest !\u003d \u0027127.0.0.1\u0027)"},{"line_number":7386,"context_line":"        if not shared_storage:"},{"line_number":7387,"context_line":"            tmp_file \u003d uuidutils.generate_uuid(dashed\u003dFalse) + \u0027.tmp\u0027"},{"line_number":7388,"context_line":"            tmp_path \u003d os.path.join(inst_base, tmp_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_b441be0c","line":7385,"range":{"start_line":7385,"start_character":26,"end_line":7385,"end_character":45},"updated":"2017-11-06 11:02:07.000000000","message":"Would it be enough to check if `my_ip` in nova.conf is not set?\n\nIf not then maybe we should check more cases here:\ndest not in (\u0027127.0.0.1\u0027, \u0027localhost\u0027, \u0027::1\u0027)","commit_id":"c3e98bd9c35d7ffdf23d7c746a6362c1eabe6f9d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"30922e8b80369e4b913e17ab3bfef5792e229897","unresolved":false,"context_lines":[{"line_number":7382,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027rbd\u0027:"},{"line_number":7383,"context_line":"            return True"},{"line_number":7384,"context_line":"        shared_storage \u003d (dest \u003d\u003d self.get_host_ip_addr() and"},{"line_number":7385,"context_line":"                          dest !\u003d \u0027127.0.0.1\u0027)"},{"line_number":7386,"context_line":"        if not shared_storage:"},{"line_number":7387,"context_line":"            tmp_file \u003d uuidutils.generate_uuid(dashed\u003dFalse) + \u0027.tmp\u0027"},{"line_number":7388,"context_line":"            tmp_path \u003d os.path.join(inst_base, tmp_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_51e6dfea","line":7385,"range":{"start_line":7385,"start_character":26,"end_line":7385,"end_character":45},"in_reply_to":"3f4b6375_b441be0c","updated":"2017-11-09 23:31:22.000000000","message":"We can\u0027t rely on that because it will be set to a minimum at default. My preferred action would be to modify \u0027netutils.get_my_ipv4\u0027 to *not* return a default if no IP address could be found. This would surely resolve this issue.","commit_id":"c3e98bd9c35d7ffdf23d7c746a6362c1eabe6f9d"}]}