)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"cafb73deb1dcfc96bb8c08a7efd57080572ef4a4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"headers. If that returns a 401, then abandon the upload process."},{"line_number":18,"context_line":"Otherwise, continue with the upload."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Fixes bug Bug #1238393"},{"line_number":21,"context_line":"Change-Id: Ic47e94245980c6f08e56ef28f910a5cde598d2d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F9vpM%3D","line":20,"updated":"2014-04-02 12:48:19.000000000","message":"Closes-bug: 1238393","commit_id":"39715d682f549cd94569794b3e749cb668d954ff"}],"plugins/xenserver/xenapi/etc/xapi.d/plugins/glance":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"067d27a921fed309b8f1785095e26df9fc18c375","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        conn.endheaders()"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":149,"context_line":"        if resp.status is httplib.UNAUTHORIZED:"},{"line_number":150,"context_line":"            #No point uploading the chunk on unauthorized"},{"line_number":151,"context_line":"            raise PluginError(\"Got unauthorized response [%i] while uploading \""},{"line_number":152,"context_line":"                              \"image [%s] \""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATH%2F%2Fqs4%3D","line":149,"updated":"2013-10-11 14:04:33.000000000","message":"Instead of checking just for the single bad HTTP 401 header (unauthorized) why not check for a HTTP 200 response code instead?","commit_id":"c64060b92076f240a032705bc695483bf192ca3f"},{"author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"change_message_id":"70914ba294ad20b23de229f49a38bf155b82b9e7","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        conn.endheaders()"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":149,"context_line":"        if resp.status is httplib.UNAUTHORIZED:"},{"line_number":150,"context_line":"            #No point uploading the chunk on unauthorized"},{"line_number":151,"context_line":"            raise PluginError(\"Got unauthorized response [%i] while uploading \""},{"line_number":152,"context_line":"                              \"image [%s] \""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATH%2F%2Fqcw%3D","line":149,"in_reply_to":"AAAATH%2F%2Fqs4%3D","updated":"2013-10-11 15:01:00.000000000","message":"Other kind of plugin errors are anyways caught if they get thrown during upload. Some of the errors are also retryable. So we cant catch them here. We only want an outright exit if it throws an auth error. In other words a fast fail if 401 is returned.","commit_id":"c64060b92076f240a032705bc695483bf192ca3f"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"aeaf081340e6540636cc664bfd2326a9be448f66","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":149,"context_line":"        if resp.status is httplib.UNAUTHORIZED:"},{"line_number":150,"context_line":"            #No point uploading the chunk on unauthorized"},{"line_number":151,"context_line":"            raise PluginError(\"Got unauthorized response [%i] while uploading \""},{"line_number":152,"context_line":"                              \"image [%s] \""},{"line_number":153,"context_line":"                              \"to glance host [%s:%s]\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2FaYw%3D","line":150,"updated":"2013-11-06 22:10:52.000000000","message":"I feel like, we should log some auth related info here. Possibly token uuid...","commit_id":"77e26dd7606f1e06c9974c2f3f43d9e29527372e"},{"author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"change_message_id":"af315ee4df0130a2f73269217514a66bcd26d33f","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":149,"context_line":"        if resp.status is httplib.UNAUTHORIZED:"},{"line_number":150,"context_line":"            #No point uploading the chunk on unauthorized"},{"line_number":151,"context_line":"            raise PluginError(\"Got unauthorized response [%i] while uploading \""},{"line_number":152,"context_line":"                              \"image [%s] \""},{"line_number":153,"context_line":"                              \"to glance host [%s:%s]\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2FXOc%3D","line":150,"in_reply_to":"AAAATn%2F%2FXZs%3D","updated":"2013-11-08 06:24:27.000000000","message":"I kinda get your point, but not sure what the community would have to say about logging the tokens. Have ran into cases where the idea of logging the token had been unanimously shot down. The correlation_id would\u0027ve been a good thing, but its currently been scrapped and req-id wouldnt be of use as it doesnt get to glance anyways.","commit_id":"77e26dd7606f1e06c9974c2f3f43d9e29527372e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"956a54bbb7d22928f0f38a7eb44ad2d392093b9f","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":149,"context_line":"        if resp.status is httplib.UNAUTHORIZED:"},{"line_number":150,"context_line":"            #No point uploading the chunk on unauthorized"},{"line_number":151,"context_line":"            raise PluginError(\"Got unauthorized response [%i] while uploading \""},{"line_number":152,"context_line":"                              \"image [%s] \""},{"line_number":153,"context_line":"                              \"to glance host [%s:%s]\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2FXZs%3D","line":150,"in_reply_to":"AAAATn%2F%2FZJA%3D","updated":"2013-11-08 05:47:24.000000000","message":"If we do not LOG and the upload does not happen, due to the distributed nature of this xen api plugin call the problem is that there is no way to map the error in uploads from compute with execution on dom0.\n\nIt does not make sense at the first glance however, consider the following scenarios:-\n1. Logging on dom0 gives us statistics on how many failures happend here and in glance not in glance by pass. We still don\u0027t have no auth implementation for requests to glance api to help with longer uploads.\n\n2. It\u0027s okay if the community does not want to log auth tokens here however, IMHO - it\u0027s not that bad to log - considering the auth token would exposed if dom0 is, and the second one is far worse than first.\n\n3. If not auth token, we should at least log the corresponding request ID (and I\u0027m not sure about the status of correlation ID - common uuid across openstack projects)","commit_id":"77e26dd7606f1e06c9974c2f3f43d9e29527372e"},{"author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"change_message_id":"e900a9058d7039b0ec699a4beea13aca15d86fd8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":149,"context_line":"        if resp.status is httplib.UNAUTHORIZED:"},{"line_number":150,"context_line":"            #No point uploading the chunk on unauthorized"},{"line_number":151,"context_line":"            raise PluginError(\"Got unauthorized response [%i] while uploading \""},{"line_number":152,"context_line":"                              \"image [%s] \""},{"line_number":153,"context_line":"                              \"to glance host [%s:%s]\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2FZJA%3D","line":150,"in_reply_to":"AAAATn%2F%2FaYw%3D","updated":"2013-11-07 11:30:03.000000000","message":"IMO logging the auth_token is not really a good idea. Unless its absolutely necessary. Would we run into that sort of a situation here?","commit_id":"77e26dd7606f1e06c9974c2f3f43d9e29527372e"}]}