)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"224f93540a849e37c4f5faf14a6eaf6ed33940a0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-30 17:35:31 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"emove glance usage inside compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactory compute code to remove glance directly usage,"},{"line_number":10,"context_line":"1) use image_api.get instead of get glance code then show the image"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f4b6375_c8bb28c2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2017-10-30 15:09:35.000000000","message":"remove","commit_id":"9fb9b5d4c20a22e7d22f7ee6504b6912827faa9f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f661a6ee81f015257ea738503e99495159e3c55f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-30 17:35:31 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"emove glance usage inside compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactory compute code to remove glance directly usage,"},{"line_number":10,"context_line":"1) use image_api.get instead of get glance code then show the image"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f4b6375_759e3208","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"3f4b6375_c8bb28c2","updated":"2017-11-01 09:18:13.000000000","message":"Done","commit_id":"9fb9b5d4c20a22e7d22f7ee6504b6912827faa9f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"224f93540a849e37c4f5faf14a6eaf6ed33940a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"emove glance usage inside compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactory compute code to remove glance directly usage,"},{"line_number":10,"context_line":"1) use image_api.get instead of get glance code then show the image"},{"line_number":11,"context_line":"detail information"},{"line_number":12,"context_line":"2) according to TODO, create a new api in image.api and use it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f4b6375_08c1402f","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":54},"updated":"2017-10-30 15:09:35.000000000","message":"direct usage","commit_id":"9fb9b5d4c20a22e7d22f7ee6504b6912827faa9f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"224f93540a849e37c4f5faf14a6eaf6ed33940a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"emove glance usage inside compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactory compute code to remove glance directly usage,"},{"line_number":10,"context_line":"1) use image_api.get instead of get glance code then show the image"},{"line_number":11,"context_line":"detail information"},{"line_number":12,"context_line":"2) according to TODO, create a new api in image.api and use it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f4b6375_88b530d0","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":9},"updated":"2017-10-30 15:09:35.000000000","message":"refactor","commit_id":"9fb9b5d4c20a22e7d22f7ee6504b6912827faa9f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f661a6ee81f015257ea738503e99495159e3c55f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"emove glance usage inside compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"refactory compute code to remove glance directly usage,"},{"line_number":10,"context_line":"1) use image_api.get instead of get glance code then show the image"},{"line_number":11,"context_line":"detail information"},{"line_number":12,"context_line":"2) according to TODO, create a new api in image.api and use it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f4b6375_b594aae9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":9},"in_reply_to":"3f4b6375_88b530d0","updated":"2017-11-01 09:18:13.000000000","message":"Done","commit_id":"9fb9b5d4c20a22e7d22f7ee6504b6912827faa9f"}],"nova/image/api.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"80e384f98f6601f476ea5473a439dd2f176ef297","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \"\"\"Generate an image URL from an image_ref."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param image_ref: The image ref to generate URL"},{"line_number":62,"context_line":"        \"\"\" "},{"line_number":63,"context_line":"        return glance.generate_image_url(image_ref)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_all(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_6f63ef1b","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":12},"updated":"2017-10-12 07:40:13.000000000","message":"whitespace","commit_id":"151c24fc6a0724bb7e37b88116a7ec6d61085656"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d30b23f202faad3f7d116b497e5dd2b85770f4a2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \"\"\"Generate an image URL from an image_ref."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param image_ref: The image ref to generate URL"},{"line_number":62,"context_line":"        \"\"\" "},{"line_number":63,"context_line":"        return glance.generate_image_url(image_ref)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_all(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_cac6514a","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":12},"in_reply_to":"5f4e5783_6f63ef1b","updated":"2017-10-12 07:48:55.000000000","message":"Done","commit_id":"151c24fc6a0724bb7e37b88116a7ec6d61085656"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"80e384f98f6601f476ea5473a439dd2f176ef297","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param image_ref: The image ref to generate URL"},{"line_number":62,"context_line":"        \"\"\" "},{"line_number":63,"context_line":"        return glance.generate_image_url(image_ref)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_all(self, context, **kwargs):"},{"line_number":66,"context_line":"        \"\"\"Retrieves all information records about all disk images available"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_6a051dc2","line":63,"range":{"start_line":63,"start_character":15,"end_line":63,"end_character":40},"updated":"2017-10-12 07:40:13.000000000","message":"why not removing it from glance.py . keeping wrapper does not give much benefit.","commit_id":"151c24fc6a0724bb7e37b88116a7ec6d61085656"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d30b23f202faad3f7d116b497e5dd2b85770f4a2","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param image_ref: The image ref to generate URL"},{"line_number":62,"context_line":"        \"\"\" "},{"line_number":63,"context_line":"        return glance.generate_image_url(image_ref)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_all(self, context, **kwargs):"},{"line_number":66,"context_line":"        \"\"\"Retrieves all information records about all disk images available"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_0ab589cd","line":63,"range":{"start_line":63,"start_character":15,"end_line":63,"end_character":40},"in_reply_to":"5f4e5783_6a051dc2","updated":"2017-10-12 07:48:55.000000000","message":"done","commit_id":"151c24fc6a0724bb7e37b88116a7ec6d61085656"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b610b7d0e4fd8c9534b284b77c7414c6b42e7033","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        #                 the context alive..."},{"line_number":56,"context_line":"        return glance.get_default_image_service()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def generate_image_url(self, image_ref):"},{"line_number":59,"context_line":"        \"\"\"Generate an image URL from an image_ref."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param image_ref: The image ref to generate URL"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_ffa03a44","line":58,"range":{"start_line":58,"start_character":27,"end_line":58,"end_character":31},"updated":"2017-10-17 09:57:52.000000000","message":"this method does not use self so there is no point to make it instance method.","commit_id":"503eee316991b69c75b8d8e60261fc6dbd5975a3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"428e544f43d1bbc5fe24a52549911a98fa18486b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        :param image_ref: The image ref to generate URL"},{"line_number":63,"context_line":"        :param context: The `nova.context.Context` object for the request"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        return \"%s/images/%s\" % (glance.generate_glance_url(context),"},{"line_number":66,"context_line":"                                 image_ref)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def get_all(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_7fae462f","line":65,"range":{"start_line":65,"start_character":33,"end_line":65,"end_character":68},"updated":"2017-12-04 12:13:40.000000000","message":"can you use next(glance.get_api_servers(context)) because you might want to remove glance.generate_glance_url at some time.","commit_id":"8b53b604effbae393a51ee7513f842db17c02ded"}],"nova/image/glance.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b610b7d0e4fd8c9534b284b77c7414c6b42e7033","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                               global_request_id\u003dcontext.global_id)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def generate_image_url(image_ref):"},{"line_number":76,"context_line":"    \"\"\"Generate an image URL from an image_ref.\"\"\""},{"line_number":77,"context_line":"    return \"%s/images/%s\" % (generate_glance_url(), image_ref)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def generate_glance_url():"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_ffb95a78","line":77,"range":{"start_line":75,"start_character":0,"end_line":77,"end_character":62},"updated":"2017-10-17 09:57:52.000000000","message":"this needs to be removed","commit_id":"503eee316991b69c75b8d8e60261fc6dbd5975a3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3df941a72ec8a07efaf3fb631b92ae3d533fe748","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    return \"%s/images/%s\" % (generate_glance_url(), image_ref)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def generate_glance_url():"},{"line_number":81,"context_line":"    \"\"\"Return a random glance url from the api servers we know about.\"\"\""},{"line_number":82,"context_line":"    return next(get_api_servers())"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _endpoint_from_image_ref(image_href):"},{"line_number":86,"context_line":"    \"\"\"Return the image_ref and guessed endpoint from an image url."}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_1dc44bf4","line":83,"range":{"start_line":80,"start_character":0,"end_line":83,"end_character":0},"updated":"2017-10-16 23:08:19.000000000","message":"Why are you moving this method without any change..\nMaybe you just want to remove this method because a new one exist at api.py ?","commit_id":"503eee316991b69c75b8d8e60261fc6dbd5975a3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"701fbef9da7247f747091ae86754cdb0e4c0d7b8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    return \"%s/images/%s\" % (generate_glance_url(), image_ref)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def generate_glance_url():"},{"line_number":81,"context_line":"    \"\"\"Return a random glance url from the api servers we know about.\"\"\""},{"line_number":82,"context_line":"    return next(get_api_servers())"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _endpoint_from_image_ref(image_href):"},{"line_number":86,"context_line":"    \"\"\"Return the image_ref and guessed endpoint from an image url."}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_3f68121b","line":83,"range":{"start_line":80,"start_character":0,"end_line":83,"end_character":0},"in_reply_to":"5f4e5783_1dc44bf4","updated":"2017-10-17 09:52:33.000000000","message":"yea, this needs to be removed in favor of new one added in api.py(comment on PS2)","commit_id":"503eee316991b69c75b8d8e60261fc6dbd5975a3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b610b7d0e4fd8c9534b284b77c7414c6b42e7033","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    return \"%s/images/%s\" % (generate_glance_url(), image_ref)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def generate_glance_url():"},{"line_number":81,"context_line":"    \"\"\"Return a random glance url from the api servers we know about.\"\"\""},{"line_number":82,"context_line":"    return next(get_api_servers())"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _endpoint_from_image_ref(image_href):"},{"line_number":86,"context_line":"    \"\"\"Return the image_ref and guessed endpoint from an image url."}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_9f7f06aa","line":83,"range":{"start_line":80,"start_character":0,"end_line":83,"end_character":0},"in_reply_to":"5f4e5783_3f68121b","updated":"2017-10-17 09:57:52.000000000","message":"sorry,this is not the method you are moving. its the one above","commit_id":"503eee316991b69c75b8d8e60261fc6dbd5975a3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4d241901510d95416fadecc445bbe8b7e5e71a5d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    return \"%s/images/%s\" % (generate_glance_url(), image_ref)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def generate_glance_url():"},{"line_number":81,"context_line":"    \"\"\"Return a random glance url from the api servers we know about.\"\"\""},{"line_number":82,"context_line":"    return next(get_api_servers())"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _endpoint_from_image_ref(image_href):"},{"line_number":86,"context_line":"    \"\"\"Return the image_ref and guessed endpoint from an image url."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_e7b4df37","line":83,"range":{"start_line":80,"start_character":0,"end_line":83,"end_character":0},"in_reply_to":"5f4e5783_9f7f06aa","updated":"2017-10-19 02:24:40.000000000","message":"yes, I think it might be a rebase problem.... I do plan to remove generate_image_url function..","commit_id":"503eee316991b69c75b8d8e60261fc6dbd5975a3"}]}