)]}'
{"nova/api/metadata/handler.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a1c6b117cbc58f57d45ac95b0a39d0c23db2da1f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            req.response.content_type \u003d base.MIME_TYPE_TEXT_PLAIN"},{"line_number":97,"context_line":"            return req.response"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        LOG.debug(\u0027Metadata request headers: %s\u0027, req.header)"},{"line_number":100,"context_line":"        if CONF.neutron.service_metadata_proxy:"},{"line_number":101,"context_line":"            if req.headers.get(\u0027X-Metadata-Provider\u0027):"},{"line_number":102,"context_line":"                meta_data \u003d self._handle_instance_id_request_from_lb(req)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_d3cc1e63","line":99,"range":{"start_line":99,"start_character":50,"end_line":99,"end_character":60},"updated":"2017-10-18 09:14:29.000000000","message":"It should be \u0027req.headers\u0027.","commit_id":"364f3bbdde9c9d34db21d73eaa4771f2f06cbcc1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8cf4397c148e7728fb7b1e71f7955308beab5c44","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            req.response.content_type \u003d base.MIME_TYPE_TEXT_PLAIN"},{"line_number":97,"context_line":"            return req.response"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        LOG.debug(\u0027Metadata request headers: %s\u0027, req.header)"},{"line_number":100,"context_line":"        if CONF.neutron.service_metadata_proxy:"},{"line_number":101,"context_line":"            if req.headers.get(\u0027X-Metadata-Provider\u0027):"},{"line_number":102,"context_line":"                meta_data \u003d self._handle_instance_id_request_from_lb(req)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_70c5273c","line":99,"range":{"start_line":99,"start_character":50,"end_line":99,"end_character":60},"in_reply_to":"3f4b6375_d3cc1e63","updated":"2017-10-20 01:48:51.000000000","message":"Done","commit_id":"364f3bbdde9c9d34db21d73eaa4771f2f06cbcc1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2149efd79f5519cd9b7ac8ba2c46cc54c661e385","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        instance_id, tenant_id \u003d self._get_instance_id_from_lb("},{"line_number":256,"context_line":"            provider_id, instance_address)"},{"line_number":257,"context_line":"        LOG.debug(\u0027Instance %s with address %s matches provider %s\u0027,"},{"line_number":258,"context_line":"                  instance_id, remote_address, provider_id)"},{"line_number":259,"context_line":"        return self._get_meta_by_instance_id(instance_id, tenant_id,"},{"line_number":260,"context_line":"                                             instance_address)"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_aff0dd68","line":258,"range":{"start_line":258,"start_character":31,"end_line":258,"end_character":45},"updated":"2017-10-20 05:47:39.000000000","message":"you want to log instance_address as more specific instance address?","commit_id":"2e07d21066843f3df046c113d1d6f2fe6b84fd19"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"be7cdd408441bf71bb0094df2fe5207760dc2919","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        instance_id, tenant_id \u003d self._get_instance_id_from_lb("},{"line_number":256,"context_line":"            provider_id, instance_address)"},{"line_number":257,"context_line":"        LOG.debug(\u0027Instance %s with address %s matches provider %s\u0027,"},{"line_number":258,"context_line":"                  instance_id, remote_address, provider_id)"},{"line_number":259,"context_line":"        return self._get_meta_by_instance_id(instance_id, tenant_id,"},{"line_number":260,"context_line":"                                             instance_address)"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_bb6fb8fa","line":258,"range":{"start_line":258,"start_character":31,"end_line":258,"end_character":45},"in_reply_to":"3f4b6375_aff0dd68","updated":"2017-10-24 02:16:40.000000000","message":"the purpose here is to log the x-forward-for address(s). the instance address would be the first if there were more than one. what we have seen is that there are some use cases when there rae more than one and it leads to false poititives","commit_id":"2e07d21066843f3df046c113d1d6f2fe6b84fd19"}]}