)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b5456717b3df7a93e317d7fa101ea7996bab4dde","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VGPU_support: add enabled white list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":10,"context_line":"use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":11,"context_line":"provider of vGPUs only has one type of vGPUs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially Implements: blueprint add-support-for-vgpu"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f4b6375_f3addaea","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":20},"updated":"2017-10-18 09:03:29.000000000","message":"enabled_vgpu_types","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"bfefe9fd18ed2b3fbc7eafa0fba9119efc5180f6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VGPU_support: add enabled white list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":10,"context_line":"use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":11,"context_line":"provider of vGPUs only has one type of vGPUs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially Implements: blueprint add-support-for-vgpu"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f4b6375_f3027a3e","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":20},"in_reply_to":"3f4b6375_f3addaea","updated":"2017-10-18 09:21:15.000000000","message":"Will modify it","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a87981e03fa976da65b6af5b3a6d6b54d6de2412","unresolved":false,"context_lines":[{"line_number":11,"context_line":"provider of vGPUs only has one type of vGPUs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"NOTE(sbauza) :"},{"line_number":14,"context_line":"Since that configuration is shared between all virt drivers, we need to provide"},{"line_number":15,"context_line":"a single change that will just add that conf opt and then using it in separate"},{"line_number":16,"context_line":"series as a common base. That implies that configuration option is useless"},{"line_number":17,"context_line":"until we merge the code that reads it, but that\u0027s a necessary compromise for"},{"line_number":18,"context_line":"making sure we can move both Xen and libvirt efforts in parallel."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially Implements: blueprint add-support-for-vgpu"},{"line_number":21,"context_line":"Co-Authored-By: Sylvain Bauza \u003csbauza@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f4b6375_150d6ca0","line":18,"range":{"start_line":14,"start_character":0,"end_line":18,"end_character":65},"updated":"2017-10-24 11:54:05.000000000","message":"IMO we should still register the opt in this change and have the other changes based on this one.  (The other changes don\u0027t need to be stacked on each other - they can each be based separately on this one.)  Then this doesn\u0027t need to merge for work to progress.","commit_id":"808972657b81d874e2e4ee9d1d553c526c17a030"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VGPU_support: add enabled white list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":10,"context_line":"`enabled_vgpu_types` to specify the enabled vGPU types to ensure each resource"},{"line_number":11,"context_line":"provider of vGPUs only has one type of vGPUs."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3f4b6375_b46677c0","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":75},"updated":"2017-10-25 12:31:37.000000000","message":"line width (throughout)","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":10,"context_line":"`enabled_vgpu_types` to specify the enabled vGPU types to ensure each resource"},{"line_number":11,"context_line":"provider of vGPUs only has one type of vGPUs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"NOTE(sbauza) :"},{"line_number":14,"context_line":"Since that configuration is shared between all virt drivers, we need to provide"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3f4b6375_1419cb20","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":35},"updated":"2017-10-25 12:31:37.000000000","message":"If this is a restriction across the board for Queens, it should be documented as such in the option help string.  And for that matter, the option should be a single for now, not a list - we can make it a list later.","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c2f874a6e8fac3bae9c410ab8cd0bf062b6901e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     naichuans \u003cnaichuan.sun@citrix.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-26 08:48:07 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VGPU_support: add enabled white list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can"},{"line_number":10,"context_line":"use `enabled_vgpu_types` to specify the enabled vGPU types to ensure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3f4b6375_351705a7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":12},"updated":"2017-10-26 12:20:51.000000000","message":"just make this \"vgpu\".","commit_id":"8dba644a93f212edb7cf4982008d78c9962630a9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c2f874a6e8fac3bae9c410ab8cd0bf062b6901e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VGPU_support: add enabled white list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can"},{"line_number":10,"context_line":"use `enabled_vgpu_types` to specify the enabled vGPU types to ensure"},{"line_number":11,"context_line":"each resource provider of vGPUs only has one type of vGPUs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"NOTE(sbauza) :"},{"line_number":14,"context_line":"Since that configuration is shared between all virt drivers, we need to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3f4b6375_e9dbd84b","line":11,"range":{"start_line":10,"start_character":25,"end_line":11,"end_character":59},"updated":"2017-10-26 12:20:51.000000000","message":"this isn\u0027t actually the point of the enabled_vgpu_types option, though. The point of the enabled_vgpu_types is specifically to describe the types of vGPUs that a guest may consume from the host. It\u0027s the equivalent of the pci_passthrough_whitelist option but for vGPU types instead of PCI attributes.","commit_id":"8dba644a93f212edb7cf4982008d78c9962630a9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c2f874a6e8fac3bae9c410ab8cd0bf062b6901e2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"NOTE(sbauza) :"},{"line_number":14,"context_line":"Since that configuration is shared between all virt drivers, we need to"},{"line_number":15,"context_line":"provide a single change that will just add that conf opt and then using"},{"line_number":16,"context_line":"it in separate series as a common base. That implies that configuration"},{"line_number":17,"context_line":"option is useless until we merge the code that reads it, but that\u0027s a"},{"line_number":18,"context_line":"necessary compromise for making sure we can move both Xen and libvirt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3f4b6375_a9e960e6","line":15,"range":{"start_line":15,"start_character":66,"end_line":15,"end_character":71},"updated":"2017-10-26 12:20:51.000000000","message":"s/using/use/","commit_id":"8dba644a93f212edb7cf4982008d78c9962630a9"}],"nova/conf/compute.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a87981e03fa976da65b6af5b3a6d6b54d6de2412","unresolved":false,"context_lines":[{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"* not to be confused with: ``multi_instance_display_name_template``"},{"line_number":1106,"context_line":"\"\"\"),"},{"line_number":1107,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":1108,"context_line":"        default\u003d[],"},{"line_number":1109,"context_line":"        help\u003d\"\"\""},{"line_number":1110,"context_line":"A list of the vgpu types enabled in the compute node."}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_351628aa","line":1107,"updated":"2017-10-24 11:54:05.000000000","message":"I\u0027d like to see us start a new [device] conf section for things like this, with an eye on generic device management.","commit_id":"808972657b81d874e2e4ee9d1d553c526c17a030"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"60f7f5728b31a838923e146dfca48c1b1a428286","unresolved":false,"context_lines":[{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"* not to be confused with: ``multi_instance_display_name_template``"},{"line_number":1106,"context_line":"\"\"\"),"},{"line_number":1107,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":1108,"context_line":"        default\u003d[],"},{"line_number":1109,"context_line":"        help\u003d\"\"\""},{"line_number":1110,"context_line":"A list of the vgpu types enabled in the compute node."}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_f813d25a","line":1107,"in_reply_to":"3f4b6375_351628aa","updated":"2017-10-25 01:49:02.000000000","message":"@Sylvain, please consider the suggestions above, thanks.","commit_id":"808972657b81d874e2e4ee9d1d553c526c17a030"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c4ef8fcda738e1f4f6d9bbf6c5822f12f865102e","unresolved":false,"context_lines":[{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"* not to be confused with: ``multi_instance_display_name_template``"},{"line_number":1106,"context_line":"\"\"\"),"},{"line_number":1107,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":1108,"context_line":"        default\u003d[],"},{"line_number":1109,"context_line":"        help\u003d\"\"\""},{"line_number":1110,"context_line":"A list of the vgpu types enabled in the compute node."}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_3843b515","line":1107,"in_reply_to":"3f4b6375_351628aa","updated":"2017-10-24 17:28:31.000000000","message":"Makes sense.\n\nI feel like this is overly vgpu-specific for some reason, although I don\u0027t have any better ideas. At least this isn\u0027t in the PCI whitelist...","commit_id":"808972657b81d874e2e4ee9d1d553c526c17a030"}],"nova/conf/devices.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"devices_group \u003d cfg.OptGroup("},{"line_number":16,"context_line":"    name\u003d\u0027devices\u0027,"},{"line_number":17,"context_line":"    title\u003d\u0027physical devices options\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"vgpu_opts \u003d ["},{"line_number":20,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_54de236d","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":27},"updated":"2017-10-25 12:31:37.000000000","message":"device","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"devices_group \u003d cfg.OptGroup("},{"line_number":16,"context_line":"    name\u003d\u0027devices\u0027,"},{"line_number":17,"context_line":"    title\u003d\u0027physical devices options\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"vgpu_opts \u003d ["},{"line_number":20,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_d49c53c1","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":19},"updated":"2017-10-25 12:31:37.000000000","message":"physical/virtual\n\nThe V in VGPU does stand for \"virtual\" after all :)","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":21,"context_line":"        default\u003d[],"},{"line_number":22,"context_line":"        help\u003d\"\"\""},{"line_number":23,"context_line":"A list of the vgpu types enabled in the compute node."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":26,"context_line":"this option to specify a list of enabled vGPU type to ensure each compute node"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_34ade7e8","line":23,"range":{"start_line":23,"start_character":14,"end_line":23,"end_character":18},"updated":"2017-10-25 12:31:37.000000000","message":"Consistency of capitalization.","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":23,"context_line":"A list of the vgpu types enabled in the compute node."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":26,"context_line":"this option to specify a list of enabled vGPU type to ensure each compute node"},{"line_number":27,"context_line":"only provide the type of vGPUs. The whitelist is defined as the following::"},{"line_number":28,"context_line":"    [vgpu]"},{"line_number":29,"context_line":"    enabled_vgpu_types \u003d K100"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_14b66b3f","line":26,"range":{"start_line":26,"start_character":46,"end_line":26,"end_character":50},"updated":"2017-10-25 12:31:37.000000000","message":"types","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":26,"context_line":"this option to specify a list of enabled vGPU type to ensure each compute node"},{"line_number":27,"context_line":"only provide the type of vGPUs. The whitelist is defined as the following::"},{"line_number":28,"context_line":"    [vgpu]"},{"line_number":29,"context_line":"    enabled_vgpu_types \u003d K100"},{"line_number":30,"context_line":"    enabled_vgpu_types \u003d GRID M60-0Q"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_14bd4b01","line":27,"range":{"start_line":27,"start_character":73,"end_line":27,"end_character":75},"updated":"2017-10-25 12:31:37.000000000","message":"Extra colon.  (If this were RST, you would need an extra newline; but it\u0027s not, right?)","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":26,"context_line":"this option to specify a list of enabled vGPU type to ensure each compute node"},{"line_number":27,"context_line":"only provide the type of vGPUs. The whitelist is defined as the following::"},{"line_number":28,"context_line":"    [vgpu]"},{"line_number":29,"context_line":"    enabled_vgpu_types \u003d K100"},{"line_number":30,"context_line":"    enabled_vgpu_types \u003d GRID M60-0Q"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_94c93bad","line":27,"range":{"start_line":27,"start_character":5,"end_line":27,"end_character":21},"updated":"2017-10-25 12:31:37.000000000","message":"provides those types","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2b32f14bc3afc40f91be37bec2b46cc3ae2f478","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    enabled_vgpu_types \u003d K100"},{"line_number":30,"context_line":"    enabled_vgpu_types \u003d GRID M60-0Q"},{"line_number":31,"context_line":"    enabled_vgpu_types \u003d MxGPU"},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_b4ef971c","line":32,"updated":"2017-10-25 12:31:37.000000000","message":"Is the limitation to a single vGPU type just a libvirt thing, or a statement across the board for Queens?  If the latter, it should be mentioned here.  (If the former, it just needs to go in the libvirt docs.)","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"947746144fcbf02bf79aba0961c9115d93ab9c1a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    enabled_vgpu_types \u003d K100"},{"line_number":30,"context_line":"    enabled_vgpu_types \u003d GRID M60-0Q"},{"line_number":31,"context_line":"    enabled_vgpu_types \u003d MxGPU"},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_9be3a6d9","line":32,"in_reply_to":"3f4b6375_8025755e","updated":"2017-10-25 15:02:34.000000000","message":"Okay, so my beef is that nothing in the code delta reflects the \"only one\" statement in the commit message.  Not worth holding up the change, I suppose.","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a55ac438c4df1e07fa8a6f932537a4120cac47da","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    enabled_vgpu_types \u003d K100"},{"line_number":30,"context_line":"    enabled_vgpu_types \u003d GRID M60-0Q"},{"line_number":31,"context_line":"    enabled_vgpu_types \u003d MxGPU"},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_8025755e","line":32,"in_reply_to":"3f4b6375_b4ef971c","updated":"2017-10-25 14:18:52.000000000","message":"only libvirt atm and I really would like to not modify it only for Queens, or it would be an upgrade impact for Rocky when we would support more than one.","commit_id":"176b3a8ad2c46a716e3ae8066810be331a494dba"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"19ea7862a8bf152c8ffccccf89b84bf10f55533d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":26,"context_line":"this option to specify a list of enabled vGPU types to ensure each compute node"},{"line_number":27,"context_line":"only provides those types of vGPUs. The whitelist is defined as the following:"},{"line_number":28,"context_line":"    [vgpu]"},{"line_number":29,"context_line":"    enabled_vgpu_types \u003d K100"},{"line_number":30,"context_line":"    enabled_vgpu_types \u003d GRID M60-0Q"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f4b6375_ee308958","line":27,"range":{"start_line":27,"start_character":36,"end_line":27,"end_character":78},"updated":"2017-10-26 04:32:51.000000000","message":"\u003d\u003e An example is as the following:","commit_id":"d145988bde37a4003ea1746326f99e01183fb39a"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"19ea7862a8bf152c8ffccccf89b84bf10f55533d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"this option to specify a list of enabled vGPU types to ensure each compute node"},{"line_number":27,"context_line":"only provides those types of vGPUs. The whitelist is defined as the following:"},{"line_number":28,"context_line":"    [vgpu]"},{"line_number":29,"context_line":"    enabled_vgpu_types \u003d K100"},{"line_number":30,"context_line":"    enabled_vgpu_types \u003d GRID M60-0Q"},{"line_number":31,"context_line":"    enabled_vgpu_types \u003d MxGPU"},{"line_number":32,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f4b6375_ae84d1d3","line":29,"range":{"start_line":29,"start_character":25,"end_line":29,"end_character":29},"updated":"2017-10-26 04:32:51.000000000","message":"@naichuan: Although this is an example, please ensure that\u0027s exactly the same as the model name (for XenServer) or the \"type id\" (for libvirt) reported by the hypervisor.","commit_id":"d145988bde37a4003ea1746326f99e01183fb39a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c2f874a6e8fac3bae9c410ab8cd0bf062b6901e2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"A list of the vGPU types enabled in the compute node."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":26,"context_line":"this option to specify a list of enabled vGPU types to ensure each compute node"},{"line_number":27,"context_line":"only provides those types of vGPUs. An example is as the following:"},{"line_number":28,"context_line":"    [vgpu]"},{"line_number":29,"context_line":"    enabled_vgpu_types \u003d GRID K100"},{"line_number":30,"context_line":"    enabled_vgpu_types \u003d Intel GVT-g"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f4b6375_89cd8486","line":27,"range":{"start_line":26,"start_character":51,"end_line":27,"end_character":66},"updated":"2017-10-26 12:20:51.000000000","message":"See my comment from commit message. This wording is not correct. I would change this to read \"specify a list of vGPU types that may be assigned to a guest instance\".","commit_id":"8dba644a93f212edb7cf4982008d78c9962630a9"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"f124087c2a5130942d35cd75f73a7ba63e937987","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":21,"context_line":"        default\u003d[],"},{"line_number":22,"context_line":"        help\u003d\"\"\""},{"line_number":23,"context_line":"A list of the vGPU types enabled in the compute node."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":26,"context_line":"this option to specify a list of enabled vGPU types that may be assigned to a"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_4d7c1871","line":23,"range":{"start_line":23,"start_character":14,"end_line":23,"end_character":18},"updated":"2017-10-27 12:14:04.000000000","message":"nit: I\u0027d rather this was \"virtual GPU types\" for the first usage.  We all know what these mean, but as this is help text I think it\u0027d be better to be clear.","commit_id":"380da233d0be8e961759a6f3a5b857711542eb63"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"f124087c2a5130942d35cd75f73a7ba63e937987","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        help\u003d\"\"\""},{"line_number":23,"context_line":"A list of the vGPU types enabled in the compute node."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different vGPU types. User can use"},{"line_number":26,"context_line":"this option to specify a list of enabled vGPU types that may be assigned to a"},{"line_number":27,"context_line":"guest instance. An example is as the following:"},{"line_number":28,"context_line":"    [devices]"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_ed94e48c","line":25,"range":{"start_line":25,"start_character":5,"end_line":25,"end_character":10},"updated":"2017-10-27 12:14:04.000000000","message":"nit: I don\u0027t this should be pGPUs, but either physical GPUs or just GPUs","commit_id":"380da233d0be8e961759a6f3a5b857711542eb63"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"11683b5fb350fde82760e63069b79928a5dd5f6c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    title\u003d\u0027physical or virtual device options\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"vgpu_opts \u003d ["},{"line_number":20,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":21,"context_line":"        default\u003d[],"},{"line_number":22,"context_line":"        help\u003d\"\"\""},{"line_number":23,"context_line":"A list of the vGPU types enabled in the compute node."}],"source_content_type":"text/x-python","patch_set":27,"id":"ff82abbf_afe6dae7","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":19},"updated":"2017-11-21 14:26:03.000000000","message":"This type always seems a bit confusing to me, at least over just using a ListOpt.","commit_id":"aaaa2e60c0b98ce4326d15da0ce94223bb814994"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9f5c8c28e2ea9f17d4e71fc0ed901d267d29854f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    title\u003d\u0027physical or virtual device options\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"vgpu_opts \u003d ["},{"line_number":20,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":21,"context_line":"        default\u003d[],"},{"line_number":22,"context_line":"        help\u003d\"\"\""},{"line_number":23,"context_line":"A list of the vGPU types enabled in the compute node."}],"source_content_type":"text/x-python","patch_set":27,"id":"ff82abbf_efbdc268","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":19},"updated":"2017-11-21 14:36:01.000000000","message":"Yeah, I\u0027m almost sure there was talk of this being deprecated going forward. It\u0027s rather confusing and rarely used (in nova at least). Can we use a list opt instead?","commit_id":"aaaa2e60c0b98ce4326d15da0ce94223bb814994"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"b38cc17d83d97bbe698d62bcd7d55000313558dd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    title\u003d\u0027physical or virtual device options\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"vgpu_opts \u003d ["},{"line_number":20,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":21,"context_line":"        default\u003d[],"},{"line_number":22,"context_line":"        help\u003d\"\"\""},{"line_number":23,"context_line":"A list of the vGPU types enabled in the compute node."}],"source_content_type":"text/x-python","patch_set":27,"id":"ff82abbf_6ae68019","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":19},"in_reply_to":"ff82abbf_efbdc268","updated":"2017-11-21 14:51:25.000000000","message":"Matt and Stephen, thanks for pointing it out. I didn\u0027t realize MultiStrOpt being deprecated. I\u0027ve change it to ListOpt in the latest PS.","commit_id":"aaaa2e60c0b98ce4326d15da0ce94223bb814994"}],"nova/conf/vgpu.py":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"a7a434e46e7b037620b236493a1791ca17981180","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Intel, Inc."},{"line_number":2,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_dfcc5536","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":41},"updated":"2017-10-18 05:13:56.000000000","message":"It\u0027s wrong. need update it with correct company name.","commit_id":"84964430be217ce073cb394778bd8cdbe803a600"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"885fbe3c43cce39b3478b9b4ae8b58d56d118d64","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"vgpu_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    name\u003d\u0027vgpu\u0027,"},{"line_number":21,"context_line":"    title\u003d\u0027vgpu options\u0027)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_553def8c","line":19,"updated":"2017-10-17 10:49:05.000000000","message":"Need release note for new options?","commit_id":"84964430be217ce073cb394778bd8cdbe803a600"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"9ad401564737b0bd50fd716fe542c21423aaf9b6","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"vgpu_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    name\u003d\u0027vgpu\u0027,"},{"line_number":21,"context_line":"    title\u003d\u0027vgpu options\u0027)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_bb819bc5","line":19,"in_reply_to":"5f4e5783_553def8c","updated":"2017-10-18 05:15:19.000000000","message":"yes, will add it","commit_id":"84964430be217ce073cb394778bd8cdbe803a600"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"a7a434e46e7b037620b236493a1791ca17981180","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Intel, Inc."},{"line_number":2,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_04b6f6da","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":41},"updated":"2017-10-18 05:13:56.000000000","message":"This is wrong. Need use the correct time and company name.","commit_id":"047816ab236ef68eec5706276c8f629862cb0ccf"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"9ad401564737b0bd50fd716fe542c21423aaf9b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Intel, Inc."},{"line_number":2,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_e4cf5a55","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":41},"in_reply_to":"3f4b6375_04b6f6da","updated":"2017-10-18 05:15:19.000000000","message":"will modify it","commit_id":"047816ab236ef68eec5706276c8f629862cb0ccf"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b5456717b3df7a93e317d7fa101ea7996bab4dde","unresolved":false,"context_lines":[{"line_number":30,"context_line":"use this option to specify a enabled vGPU type to ensure current compute"},{"line_number":31,"context_line":"node only provide the type of vGPUs. The whitelist is defined as the"},{"line_number":32,"context_line":"following::"},{"line_number":33,"context_line":"  enabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ]"},{"line_number":34,"context_line":"\"\"\")"},{"line_number":35,"context_line":"]"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_b3908297","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":64},"updated":"2017-10-18 09:03:29.000000000","message":"ditto","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"27235d2b20efd82dbd06fe3a00720b0b16cfd9fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 Citrix Systems, Inc."},{"line_number":2,"context_line":"# Copyright 2017 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_b1cbc51c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":37},"updated":"2017-10-19 01:25:19.000000000","message":"delete this line as you are not a stuff belong to \"OpenStack Foundation\":-)","commit_id":"bfda6012912a8bd33672eb6757757c0ef22b908c"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"03d7c174d07a59f89f843e85d5c522dceca68969","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 Citrix Systems, Inc."},{"line_number":2,"context_line":"# Copyright 2017 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_4c887ac5","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":37},"in_reply_to":"3f4b6375_b1cbc51c","updated":"2017-10-19 02:08:31.000000000","message":"Will remove it","commit_id":"bfda6012912a8bd33672eb6757757c0ef22b908c"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"27235d2b20efd82dbd06fe3a00720b0b16cfd9fc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"},{"line_number":25,"context_line":"        default\u003d[],"},{"line_number":26,"context_line":"        help\u003d\"\"\""},{"line_number":27,"context_line":"A list of the vgpu types supported by the compute node."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":30,"context_line":"use this option to specify a enabled vGPU type to ensure current compute"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_315c754a","line":27,"range":{"start_line":27,"start_character":25,"end_line":27,"end_character":37},"updated":"2017-10-19 01:25:19.000000000","message":"enabled in","commit_id":"bfda6012912a8bd33672eb6757757c0ef22b908c"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"27235d2b20efd82dbd06fe3a00720b0b16cfd9fc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        help\u003d\"\"\""},{"line_number":27,"context_line":"A list of the vgpu types supported by the compute node."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":30,"context_line":"use this option to specify a enabled vGPU type to ensure current compute"},{"line_number":31,"context_line":"node only provide the type of vGPUs. The whitelist is defined as the"},{"line_number":32,"context_line":"following::"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_11597959","line":29,"range":{"start_line":29,"start_character":51,"end_line":29,"end_character":57},"updated":"2017-10-19 01:25:19.000000000","message":"delete it","commit_id":"bfda6012912a8bd33672eb6757757c0ef22b908c"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"27235d2b20efd82dbd06fe3a00720b0b16cfd9fc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"A list of the vgpu types supported by the compute node."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":30,"context_line":"use this option to specify a enabled vGPU type to ensure current compute"},{"line_number":31,"context_line":"node only provide the type of vGPUs. The whitelist is defined as the"},{"line_number":32,"context_line":"following::"},{"line_number":33,"context_line":"    [vgpu]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_f12a5d8e","line":30,"range":{"start_line":30,"start_character":27,"end_line":30,"end_character":46},"updated":"2017-10-19 01:25:19.000000000","message":"\"a\" or \"a list of\"?","commit_id":"bfda6012912a8bd33672eb6757757c0ef22b908c"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"27235d2b20efd82dbd06fe3a00720b0b16cfd9fc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"A list of the vgpu types supported by the compute node."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":30,"context_line":"use this option to specify a enabled vGPU type to ensure current compute"},{"line_number":31,"context_line":"node only provide the type of vGPUs. The whitelist is defined as the"},{"line_number":32,"context_line":"following::"},{"line_number":33,"context_line":"    [vgpu]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_0c1cc268","line":30,"range":{"start_line":30,"start_character":50,"end_line":30,"end_character":72},"updated":"2017-10-19 01:25:19.000000000","message":"When the nested-resource-provider is ready and applied for vGPU, we can support multiple types in single compute node. But for the first step where we attach the vGPU resource to compute node directly. Each compute node only provider one type of vGPUs.\n\nBut suggest change \"ensure current compute node\" \u003d\u003e \"ensure each compute node\".","commit_id":"bfda6012912a8bd33672eb6757757c0ef22b908c"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"27235d2b20efd82dbd06fe3a00720b0b16cfd9fc","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":30,"context_line":"use this option to specify a enabled vGPU type to ensure current compute"},{"line_number":31,"context_line":"node only provide the type of vGPUs. The whitelist is defined as the"},{"line_number":32,"context_line":"following::"},{"line_number":33,"context_line":"    [vgpu]"},{"line_number":34,"context_line":"    enabled_vgpu_types \u003d enabled_vgpu_type1"},{"line_number":35,"context_line":"    enabled_vgpu_types \u003d enabled_vgpu_type2"},{"line_number":36,"context_line":"    enabled_vgpu_types \u003d enabled_vgpu_type3"},{"line_number":37,"context_line":"\"\"\")"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_ecb4c637","line":36,"range":{"start_line":31,"start_character":37,"end_line":36,"end_character":43},"updated":"2017-10-19 01:25:19.000000000","message":"Suggest use a real example for the XenServer case firstly; refer to this user guide:\nhttp://images.nvidia.com/content/grid/pdf/GRID-vGPU-User-Guide.pdf\nWhen implementing the libvirt or other hyperisors, the developer will update it accordingly if they use different way to represent the vgpu types. (libvirt prefer to use the type-id instead of type name at the moment: https://libvirt.org/drvnodedev.html#MDEV)","commit_id":"bfda6012912a8bd33672eb6757757c0ef22b908c"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"03d7c174d07a59f89f843e85d5c522dceca68969","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":30,"context_line":"use this option to specify a enabled vGPU type to ensure current compute"},{"line_number":31,"context_line":"node only provide the type of vGPUs. The whitelist is defined as the"},{"line_number":32,"context_line":"following::"},{"line_number":33,"context_line":"    [vgpu]"},{"line_number":34,"context_line":"    enabled_vgpu_types \u003d enabled_vgpu_type1"},{"line_number":35,"context_line":"    enabled_vgpu_types \u003d enabled_vgpu_type2"},{"line_number":36,"context_line":"    enabled_vgpu_types \u003d enabled_vgpu_type3"},{"line_number":37,"context_line":"\"\"\")"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_acc24ee8","line":36,"range":{"start_line":31,"start_character":37,"end_line":36,"end_character":43},"in_reply_to":"3f4b6375_ecb4c637","updated":"2017-10-19 02:08:31.000000000","message":"will modify it.","commit_id":"bfda6012912a8bd33672eb6757757c0ef22b908c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4169472d9ec4abf65c2cc7900d6a6b25a44afe2d","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"vgpu_group \u003d cfg.OptGroup("},{"line_number":19,"context_line":"    name\u003d\u0027vgpu\u0027,"},{"line_number":20,"context_line":"    title\u003d\u0027vgpu options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"vgpu_opts \u003d ["},{"line_number":23,"context_line":"    cfg.MultiStrOpt(\u0027enabled_vgpu_types\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_e6dfd037","line":20,"updated":"2017-10-24 08:55:52.000000000","message":"we shouldn\u0027t use a new option group for VGPUs, but rather using the existing [compute] group IMHO.","commit_id":"2939cca97941db1f9cb04a9b090b876ef1801314"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6053356a6af250ee572d666c436f3aebb61883a1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"this option to specify a list of enabled vGPU type to ensure each compute node"},{"line_number":30,"context_line":"only provide the type of vGPUs. The whitelist is defined as the following::"},{"line_number":31,"context_line":"    [vgpu]"},{"line_number":32,"context_line":"    enabled_vgpu_types \u003d K100"},{"line_number":33,"context_line":"    enabled_vgpu_types \u003d GRID M60-0Q"},{"line_number":34,"context_line":"    enabled_vgpu_types \u003d MxGPU"},{"line_number":35,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_0b3b339c","line":32,"range":{"start_line":32,"start_character":25,"end_line":32,"end_character":29},"updated":"2017-10-23 11:32:16.000000000","message":"Where do these values come from?  How does an operator determine what are valid strings to put here?  How does the operator discover which types his hardware supports?  (Hint: I hope it\u0027s by querying the devices somehow, not a hardcoded lookup table somewhere in Nova.)  From reading the spec, I gather that this may be hypervisor-specific.  We should start a reference document (in this change set or another attached to the blueprint) that answers the above questions for the hypervisors that support vGPU - and link that document from here.\n\nAlso, how does the code validate the values, discover whether whitelisted GPUs are capable of them, and configure the vGPUs to be of those types?  I assume that\u0027s coming in a future change set.","commit_id":"2939cca97941db1f9cb04a9b090b876ef1801314"}],"releasenotes/notes/enabled_vgpu_types-f3f13ca63abc9c74.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b5456717b3df7a93e317d7fa101ea7996bab4dde","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":5,"context_line":"    use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":6,"context_line":"    provider of vGPUs only has one type of vGPUs.The whitelist is defined as the"},{"line_number":7,"context_line":"    following:"},{"line_number":8,"context_line":"    enabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_93b46637","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":25},"updated":"2017-10-18 09:03:29.000000000","message":"It should be ``enabled_vgpu_types``.","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"bfefe9fd18ed2b3fbc7eafa0fba9119efc5180f6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":5,"context_line":"    use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":6,"context_line":"    provider of vGPUs only has one type of vGPUs.The whitelist is defined as the"},{"line_number":7,"context_line":"    following:"},{"line_number":8,"context_line":"    enabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_f3871ab6","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":25},"in_reply_to":"3f4b6375_93b46637","updated":"2017-10-18 09:21:15.000000000","message":"Will modify it.","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b5456717b3df7a93e317d7fa101ea7996bab4dde","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":6,"context_line":"    provider of vGPUs only has one type of vGPUs.The whitelist is defined as the"},{"line_number":7,"context_line":"    following:"},{"line_number":8,"context_line":"    enabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_337db26e","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":66},"updated":"2017-10-18 09:03:29.000000000","message":"See the following URLs. It is an example.\n\nhttps://github.com/openstack/keystone/blob/bd452fb9d9f6b4b1aba3ba9690b0e729264bba29/keystone/conf/default.py#L203\nhttps://docs.openstack.org/keystone/latest/advanced-topics/event_notifications.html#opting-out-of-certain-notifications\n\nIt shoud be as follows:\n\n  [vgpu]\n  enabled_vgpu_types \u003d str_vgpu_type_1\n  enabled_vgpu_types \u003d str_vgpu_type_2","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"0f36422ba48fae8b980172b31da29a4926bb38f9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":6,"context_line":"    provider of vGPUs only has one type of vGPUs.The whitelist is defined as the"},{"line_number":7,"context_line":"    following:"},{"line_number":8,"context_line":"    enabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_5eedd523","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":66},"in_reply_to":"3f4b6375_337db26e","updated":"2017-10-18 09:36:48.000000000","message":"Hi, Takashi, according to the vgpu spec: http://git.openstack.org/cgit/openstack/nova-specs/tree/specs/queens/approved/virt-add-support-for-vgpu.rst#n147, the white list in nova.conf should be:\nenabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ].\nPlease check if it is OK. Thank you very much.","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"bfefe9fd18ed2b3fbc7eafa0fba9119efc5180f6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":6,"context_line":"    provider of vGPUs only has one type of vGPUs.The whitelist is defined as the"},{"line_number":7,"context_line":"    following:"},{"line_number":8,"context_line":"    enabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_93f9064f","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":66},"in_reply_to":"3f4b6375_337db26e","updated":"2017-10-18 09:21:15.000000000","message":"Will check it. Thank you very much.","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7bcab6bf9c609c0f63e9c3bcb1a045e30fd48bec","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":6,"context_line":"    provider of vGPUs only has one type of vGPUs.The whitelist is defined as the"},{"line_number":7,"context_line":"    following:"},{"line_number":8,"context_line":"    enabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_beaa8916","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":66},"in_reply_to":"3f4b6375_5eedd523","updated":"2017-10-18 10:03:10.000000000","message":"In that case, use ListOpt instead of MultiStrOpt.\n\ne.g.\nhttps://github.com/openstack/nova/blob/5e4c98a58f1afeaa903829f5e3f28cd6dc30bf4b/nova/conf/scheduler.py#L247\n\nThe example should be as follows in this case:\n\n  [vgpu]\n  enabled_vgpu_types \u003d str_vgpu_type_1,str_vgpu_type_2,...","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"b5f676ca8479329a80703487cd83b1dbb3f38049","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    use `vgpu_white_list` to specify the enabled vGPU types to ensure each resource"},{"line_number":6,"context_line":"    provider of vGPUs only has one type of vGPUs.The whitelist is defined as the"},{"line_number":7,"context_line":"    following:"},{"line_number":8,"context_line":"    enabled_vgpu_types \u003d [ str_vgpu_type_1, str_vgpu_type_2, ... ]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_ebc16282","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":66},"in_reply_to":"3f4b6375_beaa8916","updated":"2017-10-18 11:03:16.000000000","message":"Just verified it, you are right, Takashi.\nThank you very much for the guild.\nWill upload a new patch.","commit_id":"2bef5d5e40031f66c7e6c9a3a2200ae42650b1fc"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"c8084eab2a9c07c6743faf49e21d459742d4cec2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    use `enabled_vgpu_types` to specify the enabled vGPU types to ensure each"},{"line_number":6,"context_line":"    resource provider of vGPUs only has one type of vGPUs.The `enabled_vgpu_types`"},{"line_number":7,"context_line":"    option is defined as follows:"},{"line_number":8,"context_line":"    * [vgpu]"},{"line_number":9,"context_line":"    * enabled_vgpu_types \u003d enabled_vgpu_type1"},{"line_number":10,"context_line":"    * enabled_vgpu_types \u003d enabled_vgpu_type2"},{"line_number":11,"context_line":"    * enabled_vgpu_types \u003d enabled_vgpu_type3"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_2cd9be82","line":11,"range":{"start_line":8,"start_character":4,"end_line":11,"end_character":45},"updated":"2017-10-19 01:30:20.000000000","message":"make this as a block with \u0027::\u0027 instead of list?","commit_id":"7c917015d666f059f1972bf6184753d396ec011a"},{"author":{"_account_id":25638,"name":"Naichuan Sun","email":"naichuan.sun@citrix.com","username":"naichuans"},"change_message_id":"82d43a7c2ca8678b5c2de10df00a5c6c578a52d7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    use `enabled_vgpu_types` to specify the enabled vGPU types to ensure each"},{"line_number":6,"context_line":"    resource provider of vGPUs only has one type of vGPUs.The `enabled_vgpu_types`"},{"line_number":7,"context_line":"    option is defined as follows:"},{"line_number":8,"context_line":"    * [vgpu]"},{"line_number":9,"context_line":"    * enabled_vgpu_types \u003d enabled_vgpu_type1"},{"line_number":10,"context_line":"    * enabled_vgpu_types \u003d enabled_vgpu_type2"},{"line_number":11,"context_line":"    * enabled_vgpu_types \u003d enabled_vgpu_type3"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_ac67ee25","line":11,"range":{"start_line":8,"start_character":4,"end_line":11,"end_character":45},"in_reply_to":"3f4b6375_2cd9be82","updated":"2017-10-19 02:09:12.000000000","message":"will change it","commit_id":"7c917015d666f059f1972bf6184753d396ec011a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4169472d9ec4abf65c2cc7900d6a6b25a44afe2d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Some pGPUs (e.g. NVIDIA GRID K1) support different sized vGPU types. User can"},{"line_number":5,"context_line":"    use `enabled_vgpu_types` to specify the enabled vGPU types to ensure each"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_06b42cf1","line":2,"updated":"2017-10-24 08:55:52.000000000","message":"for the moment, we shouldn\u0027t provide a relnote given the conf opt is not used yet.","commit_id":"2939cca97941db1f9cb04a9b090b876ef1801314"}]}