)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a539e10d4991f8b0964baf5e45a7f896966d9a4d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"GET fping API accept query param to filter the"},{"line_number":10,"context_line":"instance to ping."},{"line_number":11,"context_line":"This commit adds json schema to validating the valid"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is no change in API behaviour and additionalProperty"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_b7028c0a","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":52},"updated":"2017-11-22 16:12:47.000000000","message":"validate the","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a539e10d4991f8b0964baf5e45a7f896966d9a4d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This commit adds json schema to validating the valid"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is no change in API behaviour and additionalProperty"},{"line_number":15,"context_line":"is kept True for backward compatibility."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements blueprint json-schema-validation-for-query-param"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_f708142e","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":58},"updated":"2017-11-22 16:12:47.000000000","message":"additionalProperties","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a84b0665b9a59944e755eb99035512ebcf7e7d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ghanshyam Mann \u003cghanshyammann@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-25 02:54:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement query param schema for fping index"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"GET fping API accept query param to filter the"},{"line_number":10,"context_line":"instance to ping."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_58775ea1","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":38},"updated":"2017-11-27 15:11:21.000000000","message":"In general, time would be better served implementing query param schema on APIs which are not deprecated.","commit_id":"848c63946f9f765959f2197fa055a02f68cfb9bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"25b407147bd5e9e3a6c8fae7aadac436e1c08929","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ghanshyam Mann \u003cghanshyammann@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-25 02:54:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement query param schema for fping index"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"GET fping API accept query param to filter the"},{"line_number":10,"context_line":"instance to ping."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_36993ec3","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":38},"in_reply_to":"ff82abbf_58775ea1","updated":"2017-11-27 23:18:21.000000000","message":"yea, i thought that but as they stay till we bump min version it will be helpful to freeze these with schema.","commit_id":"848c63946f9f765959f2197fa055a02f68cfb9bf"}],"nova/api/openstack/compute/schemas/fping.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9904c47a5e6974cec3ffb11d74bb92661951ad78","unresolved":false,"context_lines":[{"line_number":16,"context_line":"index_query \u003d {"},{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":20,"context_line":"        \u0027include\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":21,"context_line":"        \u0027exclude\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_891d5dbf","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":72},"updated":"2017-11-09 09:07:10.000000000","message":"also try common_query_param.","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9fe3ae7255164ef703d8d44175cf1aaced7a670c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"index_query \u003d {"},{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":20,"context_line":"        \u0027include\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":21,"context_line":"        \u0027exclude\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_ed5fc76f","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":72},"in_reply_to":"1f485f77_592ee543","updated":"2017-11-23 15:14:32.000000000","message":"all_tenants defined as an int in the API doc [1]. Is it defined as string here for some kind of backward compatibility reason?\n\n[1] https://developer.openstack.org/api-ref/compute/#ping-instances","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"2672495fc539f814f7407045f6438436a4f989b8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"index_query \u003d {"},{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":20,"context_line":"        \u0027include\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":21,"context_line":"        \u0027exclude\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_592ee543","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":72},"in_reply_to":"1f485f77_891d5dbf","updated":"2017-11-13 00:11:27.000000000","message":"+1","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2829f4e868938c80387c68947dbae3f22780daff","unresolved":false,"context_lines":[{"line_number":16,"context_line":"index_query \u003d {"},{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":20,"context_line":"        \u0027include\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":21,"context_line":"        \u0027exclude\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_a6dc60e4","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":72},"in_reply_to":"1f485f77_891d5dbf","updated":"2017-11-25 02:45:13.000000000","message":"i prefer more explicit notation which is much easy to read.","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e7bd112d3ba8226a3437186dca8c601a47f01723","unresolved":false,"context_lines":[{"line_number":16,"context_line":"index_query \u003d {"},{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":20,"context_line":"        \u0027include\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":21,"context_line":"        \u0027exclude\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_34915a4f","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":72},"in_reply_to":"ff82abbf_c602c43d","updated":"2017-11-25 08:42:28.000000000","message":"fixed type of \u0027all_tenants\u0027 in api-ref  https://review.openstack.org/#/c/522918/1","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2829f4e868938c80387c68947dbae3f22780daff","unresolved":false,"context_lines":[{"line_number":16,"context_line":"index_query \u003d {"},{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":20,"context_line":"        \u0027include\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":21,"context_line":"        \u0027exclude\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_c602c43d","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":72},"in_reply_to":"ff82abbf_ed5fc76f","updated":"2017-11-25 02:45:13.000000000","message":"we mention string as all param value in QUERY_STRING in req is all string type. \n\nBut i agree with doc things, in code[1] we only check the presence of \u0027all_tenants\u0027 i req not any specific value so having integer type there is not right.\nI will clarify it on api-ref. \n\n\n..1 https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/api/openstack/compute/fping.py#L75","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a84b0665b9a59944e755eb99035512ebcf7e7d6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    },"},{"line_number":23,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":24,"context_line":"    # As of now Schema validation stripped out the additional parameters and"},{"line_number":25,"context_line":"    # does not raise 400. In the future, we may block the additional parameters"},{"line_number":26,"context_line":"    # by bump in Microversion."},{"line_number":27,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":28,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_b85d4a16","line":26,"range":{"start_line":25,"start_character":25,"end_line":26,"end_character":30},"updated":"2017-11-27 15:11:21.000000000","message":"nit: we could remove this since we\u0027re never going to bump a microversion on this API since it\u0027s deprecated. I realize this is copy/paste text, but it could be omitted here.","commit_id":"848c63946f9f765959f2197fa055a02f68cfb9bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"25b407147bd5e9e3a6c8fae7aadac436e1c08929","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    },"},{"line_number":23,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":24,"context_line":"    # As of now Schema validation stripped out the additional parameters and"},{"line_number":25,"context_line":"    # does not raise 400. In the future, we may block the additional parameters"},{"line_number":26,"context_line":"    # by bump in Microversion."},{"line_number":27,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":28,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_d6efb21b","line":26,"range":{"start_line":25,"start_character":25,"end_line":26,"end_character":30},"in_reply_to":"ff82abbf_b85d4a16","updated":"2017-11-27 23:18:21.000000000","message":"yea, i just copy paste these notes. ll remove it if changing this file in future.","commit_id":"848c63946f9f765959f2197fa055a02f68cfb9bf"}],"nova/tests/unit/api/openstack/compute/test_fping.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9fe3ae7255164ef703d8d44175cf1aaced7a670c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(len(res_dict[\"servers\"]), 1)"},{"line_number":92,"context_line":"        self.assertEqual(res_dict[\"servers\"][0][\"id\"], ids[0])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_fping_index_with_non_int_filters(self):"},{"line_number":95,"context_line":"        req \u003d fakes.HTTPRequest.blank(self._get_url() +"},{"line_number":96,"context_line":"            \u0027/os-fping?all_tenants\u003d-1\u0026include\u003d-21\u0026exclude\u003d-3\u0027,"},{"line_number":97,"context_line":"            use_admin_context\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_0d7a2bf0","line":94,"range":{"start_line":94,"start_character":30,"end_line":94,"end_character":45},"updated":"2017-11-23 15:14:32.000000000","message":"This is confusing, the params below are all integers","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b2e3b511b5964fa78cf87546d425b81785acc9a2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(len(res_dict[\"servers\"]), 1)"},{"line_number":92,"context_line":"        self.assertEqual(res_dict[\"servers\"][0][\"id\"], ids[0])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_fping_index_with_non_int_filters(self):"},{"line_number":95,"context_line":"        req \u003d fakes.HTTPRequest.blank(self._get_url() +"},{"line_number":96,"context_line":"            \u0027/os-fping?all_tenants\u003d-1\u0026include\u003d-21\u0026exclude\u003d-3\u0027,"},{"line_number":97,"context_line":"            use_admin_context\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_a678e0c3","line":94,"range":{"start_line":94,"start_character":30,"end_line":94,"end_character":45},"in_reply_to":"ff82abbf_06bbcc71","updated":"2017-11-25 02:51:59.000000000","message":"int one already tested so renaming it is enough. thanks.","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2829f4e868938c80387c68947dbae3f22780daff","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(len(res_dict[\"servers\"]), 1)"},{"line_number":92,"context_line":"        self.assertEqual(res_dict[\"servers\"][0][\"id\"], ids[0])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_fping_index_with_non_int_filters(self):"},{"line_number":95,"context_line":"        req \u003d fakes.HTTPRequest.blank(self._get_url() +"},{"line_number":96,"context_line":"            \u0027/os-fping?all_tenants\u003d-1\u0026include\u003d-21\u0026exclude\u003d-3\u0027,"},{"line_number":97,"context_line":"            use_admin_context\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_06bbcc71","line":94,"range":{"start_line":94,"start_character":30,"end_line":94,"end_character":45},"in_reply_to":"ff82abbf_0d7a2bf0","updated":"2017-11-25 02:45:13.000000000","message":"this i added for negative int, let me split it into 2 tests for clarity.","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9fe3ae7255164ef703d8d44175cf1aaced7a670c","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_fping_index_pagination_with_additional_filter(self):"},{"line_number":121,"context_line":"        req \u003d fakes.HTTPRequest.blank(self._get_url() +"},{"line_number":122,"context_line":"            \u0027/os-fping?all_tenants\u003d1\u0026include\u003dUUID1\u0026exclude\u003dUUID2additional\u003d3\u0027,"},{"line_number":123,"context_line":"            use_admin_context\u003dTrue)"},{"line_number":124,"context_line":"        self.controller.index(req)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_4d227302","line":122,"updated":"2017-11-23 15:14:32.000000000","message":"Did you missed a \u0027\u0026\u0027 between UUID2 and additional\u003d3?","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2829f4e868938c80387c68947dbae3f22780daff","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_fping_index_pagination_with_additional_filter(self):"},{"line_number":121,"context_line":"        req \u003d fakes.HTTPRequest.blank(self._get_url() +"},{"line_number":122,"context_line":"            \u0027/os-fping?all_tenants\u003d1\u0026include\u003dUUID1\u0026exclude\u003dUUID2additional\u003d3\u0027,"},{"line_number":123,"context_line":"            use_admin_context\u003dTrue)"},{"line_number":124,"context_line":"        self.controller.index(req)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_469c740e","line":122,"in_reply_to":"ff82abbf_4d227302","updated":"2017-11-25 02:45:13.000000000","message":"oops, you have eagle eye :)","commit_id":"342077be9be0caa124b5b2a1c33c94550b0cc5d5"}]}