)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add AggregatedProviderSummary and AggregatedProviderSummaryList objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"AggregatedProviderSummary is an object which aggreates the resource provider"},{"line_number":10,"context_line":"with those sharing resource providers that are in the same aggregate."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Each AggregatedProviderSummary object is a combination of the resource provider"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_4148bc85","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":67},"updated":"2017-10-24 21:07:49.000000000","message":"anchor/main/base/target/selfish [1]\n\n[1] https://doodle.com/poll/9fkqidtfzwh7y9tr#table","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add AggregatedProviderSummary and AggregatedProviderSummaryList objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"AggregatedProviderSummary is an object which aggreates the resource provider"},{"line_number":10,"context_line":"with those sharing resource providers that are in the same aggregate."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Each AggregatedProviderSummary object is a combination of the resource provider"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_e1a8c820","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":76},"updated":"2017-10-24 21:07:49.000000000","message":"line width","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"AggregatedProviderSummary is an object which aggreates the resource provider"},{"line_number":10,"context_line":"with those sharing resource providers that are in the same aggregate."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Each AggregatedProviderSummary object is a combination of the resource provider"},{"line_number":13,"context_line":"which is one allocation request finally."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I64d3b96ccae119c4f03afa7fcbf43382a9775929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_c1a5cc48","line":12,"range":{"start_line":12,"start_character":71,"end_line":12,"end_character":79},"updated":"2017-10-24 21:07:49.000000000","message":"providers.\n\nAnd line width.","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"with those sharing resource providers that are in the same aggregate."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Each AggregatedProviderSummary object is a combination of the resource provider"},{"line_number":13,"context_line":"which is one allocation request finally."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I64d3b96ccae119c4f03afa7fcbf43382a9775929"},{"line_number":16,"context_line":"Partial-implement-blueprint add-trait-support-in-allocation-candidates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_a132d00e","line":13,"range":{"start_line":13,"start_character":6,"end_line":13,"end_character":8},"updated":"2017-10-24 21:07:49.000000000","message":"comprise","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"}],"nova/objects/resource_provider.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":2545,"context_line":""},{"line_number":2546,"context_line":"    @staticmethod"},{"line_number":2547,"context_line":"    def _get_shared_provider_combinations(shared_providers):"},{"line_number":2548,"context_line":"        # FIXME(alex_xu): This is the copy of the current buggy implemenation"},{"line_number":2549,"context_line":"        # of generating the shared providers combiantion. Please refer:"},{"line_number":2550,"context_line":"        # BUG #1702420"},{"line_number":2551,"context_line":"        return zip("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_a7bd40d9","line":2548,"range":{"start_line":2548,"start_character":64,"end_line":2548,"end_character":77},"updated":"2017-10-24 21:07:49.000000000","message":"implementation","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":2546,"context_line":"    @staticmethod"},{"line_number":2547,"context_line":"    def _get_shared_provider_combinations(shared_providers):"},{"line_number":2548,"context_line":"        # FIXME(alex_xu): This is the copy of the current buggy implemenation"},{"line_number":2549,"context_line":"        # of generating the shared providers combiantion. Please refer:"},{"line_number":2550,"context_line":"        # BUG #1702420"},{"line_number":2551,"context_line":"        return zip("},{"line_number":2552,"context_line":"            shared_providers[shared_rc_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_e7ed78f0","line":2549,"range":{"start_line":2549,"start_character":45,"end_line":2549,"end_character":56},"updated":"2017-10-24 21:07:49.000000000","message":"combination","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":2555,"context_line":""},{"line_number":2556,"context_line":"    @classmethod"},{"line_number":2557,"context_line":"    def get_all_with_any_resource_and_trait("},{"line_number":2558,"context_line":"            cls, context, resources, required\u003dNone):"},{"line_number":2559,"context_line":"        ret \u003d []"},{"line_number":2560,"context_line":"        provider_summaries \u003d ("},{"line_number":2561,"context_line":"            ProviderSummaryList.get_all_with_any_resource_and_trait(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_47ad6c99","line":2558,"range":{"start_line":2558,"start_character":35,"end_line":2558,"end_character":50},"updated":"2017-10-24 21:07:49.000000000","message":"strike","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":2567,"context_line":"            get_root_providers_by_rp_id())"},{"line_number":2568,"context_line":""},{"line_number":2569,"context_line":"        for root_id, provider_summary in root_providers_by_rp_id.items():"},{"line_number":2570,"context_line":"            agg_provider \u003d AggregatedProviderSummary(context)"},{"line_number":2571,"context_line":"            agg_provider.provider_summaries \u003d []"},{"line_number":2572,"context_line":"            for shared_provider_tuple in cls._get_shared_provider_combinations("},{"line_number":2573,"context_line":"                    shared_providers_by_rc_id):"},{"line_number":2574,"context_line":"                shared_provider \u003d list(*shared_provider_tuple)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_e7c21834","line":2571,"range":{"start_line":2570,"start_character":0,"end_line":2571,"end_character":48},"updated":"2017-10-24 21:07:49.000000000","message":"Set the aggregate_uuid","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":2570,"context_line":"            agg_provider \u003d AggregatedProviderSummary(context)"},{"line_number":2571,"context_line":"            agg_provider.provider_summaries \u003d []"},{"line_number":2572,"context_line":"            for shared_provider_tuple in cls._get_shared_provider_combinations("},{"line_number":2573,"context_line":"                    shared_providers_by_rc_id):"},{"line_number":2574,"context_line":"                shared_provider \u003d list(*shared_provider_tuple)"},{"line_number":2575,"context_line":"                agg_provider.provider_summaries.extend("},{"line_number":2576,"context_line":"                    [provider_summary] + shared_provider)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_871a44c9","line":2573,"range":{"start_line":2573,"start_character":20,"end_line":2573,"end_character":45},"updated":"2017-10-24 21:07:49.000000000","message":"No, this is going to grab any sharing RP with any resource - not limited to those in the same aggregate as the root provider of the current iteration.","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":2573,"context_line":"                    shared_providers_by_rc_id):"},{"line_number":2574,"context_line":"                shared_provider \u003d list(*shared_provider_tuple)"},{"line_number":2575,"context_line":"                agg_provider.provider_summaries.extend("},{"line_number":2576,"context_line":"                    [provider_summary] + shared_provider)"},{"line_number":2577,"context_line":"            ret.append(agg_provider)"},{"line_number":2578,"context_line":""},{"line_number":2579,"context_line":"        agg_provider_list \u003d cls(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_c7427cab","line":2576,"range":{"start_line":2576,"start_character":20,"end_line":2576,"end_character":39},"updated":"2017-10-24 21:07:49.000000000","message":"This will add the root RP\u0027s provider summary multiple times.","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":2576,"context_line":"                    [provider_summary] + shared_provider)"},{"line_number":2577,"context_line":"            ret.append(agg_provider)"},{"line_number":2578,"context_line":""},{"line_number":2579,"context_line":"        agg_provider_list \u003d cls(context)"},{"line_number":2580,"context_line":"        agg_provider_list.objects \u003d ret"},{"line_number":2581,"context_line":"        return agg_provider_list"},{"line_number":2582,"context_line":""},{"line_number":2583,"context_line":""},{"line_number":2584,"context_line":"@db_api.api_context_manager.reader"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_a7b9c0cc","line":2581,"range":{"start_line":2579,"start_character":0,"end_line":2581,"end_character":32},"updated":"2017-10-24 21:07:49.000000000","message":"or\n\n return cls(context, objects\u003dret)","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"}],"nova/tests/unit/objects/test_resource_provider.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0f53bb5a072191d74edf3c9c749eeaf24f0a87f9","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    @mock.patch.object(resource_provider.ProviderSummaryList,"},{"line_number":507,"context_line":"                       \u0027get_all_with_any_resource_and_trait\u0027)"},{"line_number":508,"context_line":"    def test_get_all_with_any_resource_and_trait(self,"},{"line_number":509,"context_line":"            mock_summary_get_all):"},{"line_number":510,"context_line":"        mock_summary_get_all.return_value \u003d self._get_fake_summary_list()"},{"line_number":511,"context_line":"        cls \u003d resource_provider.AggregatedProviderSummaryList"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_c71b9cc7","line":508,"updated":"2017-10-24 21:07:49.000000000","message":"Clearly need richer/deeper testing here.","commit_id":"8579a5d75ecced0bb6bfaaf67a32a895d05b63f3"}]}